From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7620AC31E47 for ; Sat, 15 Jun 2019 12:12:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4084821473 for ; Sat, 15 Jun 2019 12:12:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="n+tga348"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jjCiZX5E" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4084821473 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CcUgTE+UULJyX8P5LGhGsRRmM08heL0v89bWlF2T64w=; b=n+tga348hS2FgjMga5J8L9l/i /okhv+5XIMpDjK+oUFGIyjfyA4AWaWHs+ydx2qamibGr5SEshvb2DjOe9xgH2+hMXnkZkE5mTWmxD 0RfiGUn7HQKz/Cmvk6WuW8rTlR8Kq8AkpwTm49MQcnEIjuTS9R87YZnJGy+g/ifFasPd3PKplMHJC JSdJbAahdonONaMwsyQjZx6jvvYZe676nkyyJa6qingxHLnGBlMcmBcW3HvBzzpGhrstyrEGL5ZJv +6jAYDRetHU1c4WYTPjQZEjCD6bwkUafYhIhSQzGJnJc+CI5Jn+hs4OJfPs0Yp7LYm4tqSMa/ywFx EJxCF9hhQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hc7Y3-0000q8-NY; Sat, 15 Jun 2019 12:12:43 +0000 Received: from mail-qk1-x741.google.com ([2607:f8b0:4864:20::741]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hc7Xz-0000pe-M3; Sat, 15 Jun 2019 12:12:41 +0000 Received: by mail-qk1-x741.google.com with SMTP id b18so3409709qkc.9; Sat, 15 Jun 2019 05:12:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=inRr4CIO+m2MnMN+UoknQRa/5PVtmKpMFRVNhhThkrA=; b=jjCiZX5E0qW6WES3BwYF3kpVF0I32Bl8mV4LQP22iER/ygXFQi3ggLvAt9Cy82w6ds CO0+XzmYagn1XgEJv15bI2c8patMC0eBUJknratHBcXQAuq6l6wkLRsnYLW5t4GYsWzF XBoX62ScD1h1njfG2SHMtHb/4r4Y1H9kMw4sg3kloM3HGoVV//OQwQ98V3+ce/XnoCkK njtPUN8WcYWrdZRlh7OaKfWAjbwiHlHhfucxQNX/0KX58ShnEBXLVQtNBIQkndkafBJY 5bxrVgG9wWMfwaHLJA6rOE25BIFJgnauPfl7bnm0T9FKmCdo0VgF8tyNYoUIVt4hMsoG 3Smw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=inRr4CIO+m2MnMN+UoknQRa/5PVtmKpMFRVNhhThkrA=; b=DYFCUdjcZ5uwKVzBDBkbT2/gJediZhzE6QI/75ElsyHB1W5k3NtAM7gxMaw+qAkcIH 0YZ6N0H37Bm+vVlcsEVqMPRLTRK/YpJG2A656PSNw2CmO6oMwdBl+nij+kNRDSgzRyS4 VkoGQsQYH0ef16+j2NxQPBmxJxKbPS2CdHNvhtrBDSDebqSphrQC6TB+gMrkfot0S37w lwCo/jmIOTKJ2vem1r+/TL7fkovy6zxQI3sUcxy8Tml7G/qB4yVqGiPoly6DM9jd0Xi5 SmyxYc7KLS2lqloTZ2OV8UCtprFdNZ0L+D1XLHfABTK6Tc97D9tsBNb/XKXWBpxm03uj 9rVw== X-Gm-Message-State: APjAAAXlAmFfQh4a6GOgVLUyJgYsrBm4mmdzhkZlyMzFVAktyAM8Iu2U /gaRnCEfVMjRaQa0ckohCJ0yNXtG4RI= X-Google-Smtp-Source: APXvYqyiTf3HnTZs3MMs7IAw0mHRPbED9YwhOkFchUCDomSUrB04yrQpaHrMXLkrdEO4inE5zz5nnw== X-Received: by 2002:a37:5942:: with SMTP id n63mr67499055qkb.69.1560600756482; Sat, 15 Jun 2019 05:12:36 -0700 (PDT) Received: from ?IPv6:2601:153:900:ebb:d1e6:5a48:e4d5:c6a6? ([2601:153:900:ebb:d1e6:5a48:e4d5:c6a6]) by smtp.gmail.com with ESMTPSA id p64sm3169167qkf.60.2019.06.15.05.12.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 15 Jun 2019 05:12:35 -0700 (PDT) Subject: Re: [PATCH] arm64: dts: rockchip: improve rk3328-roc-cc rgmii performance. To: "Leonidas P. Papadakos" References: <20190607123731.8737-1-pgwipeout@gmail.com> <1559912295.22520.0@gmail.com> <1560547631.1367.4@gmail.com> From: Peter Geis Message-ID: <71dc10a5-1024-d849-336e-476d183e5f46@gmail.com> Date: Sat, 15 Jun 2019 08:12:36 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <1560547631.1367.4@gmail.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190615_051239_915667_58F20AC5 X-CRM114-Status: GOOD ( 15.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jose Abreu , devicetree@vger.kernel.org, Heiko Stuebner , linux-rockchip@lists.infradead.org, Rob Herring , Robin Murphy , linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 6/14/2019 5:27 PM, Leonidas P. Papadakos wrote: > > >> The big change was actually snps,aal. >> As per the TRM, DMA channels not address aligned have severe >> limitations, if they work at all. >> >> Setting the DMA ops as address aligned fixed my 30mbps TX issue when >> combined with your snps,txpbl = <0x4>. > > Honestly, I don't notice any difference either way with aal. So what > happens without it? If You only use the 0x4 txpbl and having removed > thresh dma mode, (2 things then) do you get bad tx? > > I'm unsure why, but I think there might be small variations in the different boards (Firefly, Libre). On my board (Libre) with just 0x4 txpbl and thresh dma removed I get a whopping 30mbps. Adding aal brought it up to 900 mbps. I also had stability issues on rx, where it would bounce between 200 and 400 mbps, which adding 0x4 rxpbl helped. I still haven't been able to get rx above 400mpbs though. It's definitely the MTU issue, since setting the max mtu to 1496 fixes most problems. I have to wonder if the pl330 in the rk3328 is bugged, since all of the hardware that misbehaves (usb3, mmc, rgmii) require the dma engine. If this works as a valid replacement for thresh dma mode, then I can submit it for merging. I would like a few more people to test it first. Anyone else with a rk3328-roc-cc board that can test this patch? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel