Re: [PATCH 0/4] media: mediatek: vcodec: VP9 slice setup cleanups and fixes

[Nicolas Dufresne <nicolas@ndufresne.ca>]

[-- Attachment #1: Type: text/plain, Size: 1414 bytes --]

Hi,

Le mercredi 06 mai 2026 à 16:41 +0800, Haoxiang Li a écrit :
> Patches 1 and 2 change the signatures of two functions to void, removing
> the now-unnecessary return value and its associated dead error checks.
> Patches 3 and 4 add missing memory release operations in error paths,
> fixing resource leaks.
> 
> These patches are carried out under the guidance of Nicolas Dufresne.
> Thanks, Nicolas!

Thanks a lot for the patches. Something to improve, as I suppose you are fairly
knew to this, is that when sending a new version of a existing patch, we try and
make it clear and make version the subjects (e.g. [PATCH v2 ...) and in the
cover letter, we summarize the changes from v1 -> v2. If you use tools like b4,
the process become painless. Meanwhile, this is fresh in my memory, so its fine.

cheers,
Nicolas

> 
> Haoxiang Li (4):
>   media: mediatek: vcodec: remove redundant return value of
>     vdec_vp9_slice_setup_lat_buffer()
>   media: mediatek: vcodec: remove redundant return value of
>     vdec_vp9_slice_setup_prob_buffer()
>   media: mediatek: vcodec: free working buf on error path in
>     vdec_vp9_slice_setup_lat()
>   media: mediatek: vcodec: free working buf in
>     vdec_vp9_slice_setup_single()
> 
>  .../vcodec/decoder/vdec/vdec_vp9_req_lat_if.c | 29 +++++++------------
>  1 file changed, 11 insertions(+), 18 deletions(-)

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]