From: Auger Eric <eric.auger@redhat.com>
To: linmiaohe <linmiaohe@huawei.com>,
maz@kernel.org, pbonzini@redhat.com, rkrcmar@redhat.com,
james.morse@arm.com, julien.thierry.kdev@gmail.com,
suzuki.poulose@arm.com, christoffer.dall@arm.com,
catalin.marinas@arm.com, gregkh@linuxfoundation.org,
will@kernel.org, andre.przywara@arm.com, tglx@linutronix.de
Cc: kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: arm64: eliminate unnecessary var err and jump label in set_core_reg()
Date: Thu, 28 Nov 2019 09:56:54 +0100 [thread overview]
Message-ID: <7210b73f-66a0-e276-74b4-83d011b57d21@redhat.com> (raw)
In-Reply-To: <1574910598-14468-1-git-send-email-linmiaohe@huawei.com>
Hi,
On 11/28/19 4:09 AM, linmiaohe wrote:
> From: Miaohe Lin <linmiaohe@huawei.com>
>
> The var err and jump label out isn't really needed in
> set_core_reg(). Clean them up.
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Thanks
Eric
> ---
> arch/arm64/kvm/guest.c | 13 ++++---------
> 1 file changed, 4 insertions(+), 9 deletions(-)
>
> diff --git a/arch/arm64/kvm/guest.c b/arch/arm64/kvm/guest.c
> index 3b836c91609e..88eb6e5399ed 100644
> --- a/arch/arm64/kvm/guest.c
> +++ b/arch/arm64/kvm/guest.c
> @@ -159,7 +159,6 @@ static int set_core_reg(struct kvm_vcpu *vcpu, const struct kvm_one_reg *reg)
> __uint128_t tmp;
> void *valp = &tmp;
> u64 off;
> - int err = 0;
>
> /* Our ID is an index into the kvm_regs struct. */
> off = core_reg_offset_from_id(reg->id);
> @@ -173,10 +172,8 @@ static int set_core_reg(struct kvm_vcpu *vcpu, const struct kvm_one_reg *reg)
> if (KVM_REG_SIZE(reg->id) > sizeof(tmp))
> return -EINVAL;
>
> - if (copy_from_user(valp, uaddr, KVM_REG_SIZE(reg->id))) {
> - err = -EFAULT;
> - goto out;
> - }
> + if (copy_from_user(valp, uaddr, KVM_REG_SIZE(reg->id)))
> + return -EFAULT;
>
> if (off == KVM_REG_ARM_CORE_REG(regs.pstate)) {
> u64 mode = (*(u64 *)valp) & PSR_AA32_MODE_MASK;
> @@ -200,14 +197,12 @@ static int set_core_reg(struct kvm_vcpu *vcpu, const struct kvm_one_reg *reg)
> return -EINVAL;
> break;
> default:
> - err = -EINVAL;
> - goto out;
> + return -EINVAL;
> }
> }
>
> memcpy((u32 *)regs + off, valp, KVM_REG_SIZE(reg->id));
> -out:
> - return err;
> + return 0;
> }
>
> #define vq_word(vq) (((vq) - SVE_VQ_MIN) / 64)
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-11-28 8:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-28 3:09 [PATCH] KVM: arm64: eliminate unnecessary var err and jump label in set_core_reg() linmiaohe
2019-11-28 8:56 ` Auger Eric [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7210b73f-66a0-e276-74b4-83d011b57d21@redhat.com \
--to=eric.auger@redhat.com \
--cc=andre.przywara@arm.com \
--cc=catalin.marinas@arm.com \
--cc=christoffer.dall@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=james.morse@arm.com \
--cc=julien.thierry.kdev@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linmiaohe@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=suzuki.poulose@arm.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).