From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/8] arm: add device-tree SoC bindings for Axis Artpec-6
Date: Thu, 11 Feb 2016 15:14:56 +0100 [thread overview]
Message-ID: <7242985.WgQduhPVkk@wuerfel> (raw)
In-Reply-To: <0f096d1ad277cf94032ca274ced0cb35cb5d967c.1455198819.git.larper@axis.com>
On Thursday 11 February 2016 15:04:37 Lars Persson wrote:
> +
> +The DMA configuration unit muxes dma request lines between single and burst
> +alternatives.
> +
> +Required properties:
> +- compatible: axis,artpec6-dmacfg
> +- reg: Address and length of DMACFG register.
> +
> +Example:
> + dmacfg {
> + compatible = "axis,artpec6-dmacfg";
> + reg = <0xf8000010 4>;
> + };
> +
This method looks better than before, but putting a single register
into DT looks wrong. I can almost guarantee that there are more
registers at 0xf8000000-0xf8000fff (or more) that belong to either
some system controller or a DMA controller.
Whatever it is, please describe it in the DT in a sensible way based
on what the hardware does and what other resources it uses (interrupts
etc) rather than what today's kernel happens to need.
Arnd
next prev parent reply other threads:[~2016-02-11 14:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-11 14:04 [PATCH v2 0/8] arm: Add Artpec-6 SoC Lars Persson
2016-02-11 14:04 ` [PATCH v2 1/8] clk: add device tree binding for artpec-6 pll1 clock Lars Persson
2016-02-11 14:04 ` [PATCH v2 2/8] clk: add artpec-6 pll1 clock driver Lars Persson
2016-02-11 14:04 ` [PATCH v2 3/8] arm: add device-tree SoC bindings for Axis Artpec-6 Lars Persson
2016-02-11 14:14 ` Arnd Bergmann [this message]
2016-02-11 14:04 ` [PATCH v2 4/8] arm: dts: add Artpec-6 SoC dtsi file Lars Persson
2016-02-11 14:04 ` [PATCH v2 5/8] arm: dts: add Artpec-6 development board dts Lars Persson
2016-02-11 14:04 ` [PATCH v2 6/8] arm: initial machine port for artpec-6 SoC Lars Persson
2016-02-11 14:04 ` [PATCH v2 7/8] arm: multi_v7_defconfig: add MACH_ARTPEC6 Lars Persson
2016-02-11 14:04 ` [PATCH v2 8/8] arm: mach-artpec: add entry to MAINTAINERS Lars Persson
2016-02-11 14:17 ` [PATCH v2 0/8] arm: Add Artpec-6 SoC Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7242985.WgQduhPVkk@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).