From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03A79C43381 for ; Mon, 1 Apr 2019 09:00:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C331C213A2 for ; Mon, 1 Apr 2019 09:00:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CC/OlNYd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C331C213A2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=H2gEfw76H2XTyIsh55RhiFFkewTTvM81agvTiRR9ToE=; b=CC/OlNYdk+IhSA 4uSyZTnIvkdlZy2FWxpW1strxL8z5R/0jhFK+0eWHsF8j8XrgdV6+vHiVRl7WkoJP32OKEwODy5SW /rDTJA+RYEKH3lx+lqfcHWT1kG+f3ZpEGxyorEFaymUSfbnuRpU5ptZQQ9JSu2IZSou49dfOoF0mt DcQ/JtHsNRyVJVl0A9BOSO6nn3+3QuTNDWRCZNLncQMicAcfInZgAouEmlhH7qzJRtVQvebMCh/K7 yaQJ9NfAuRmGTXbGYH7TVQ8fCAps4f0WuopWFchgy0eMP/rXXfCUv6AXy3cDGNL1xr+nJ0L7z0yxE ToN7HYH1leNYXw65BR3w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hAsoG-0007Q8-NW; Mon, 01 Apr 2019 09:00:52 +0000 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70] helo=foss.arm.com) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hAsoD-0007Pm-5w for linux-arm-kernel@lists.infradead.org; Mon, 01 Apr 2019 09:00:50 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A5144374; Mon, 1 Apr 2019 02:00:46 -0700 (PDT) Received: from [10.1.196.72] (e119884-lin.cambridge.arm.com [10.1.196.72]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 947553F690; Mon, 1 Apr 2019 02:00:45 -0700 (PDT) Subject: Re: [PATCH 1/5] arm64: compat: Alloc separate pages for vectors and sigpage To: Catalin Marinas References: <20190319151542.19557-1-vincenzo.frascino@arm.com> <20190319151542.19557-2-vincenzo.frascino@arm.com> <20190329121211.gv7i7fqt74h3rtls@mbp> From: Vincenzo Frascino Message-ID: <725414ad-63a3-1d4f-1cd4-3c406bc809c5@arm.com> Date: Mon, 1 Apr 2019 10:00:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190329121211.gv7i7fqt74h3rtls@mbp> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190401_020049_227919_FDD083F5 X-CRM114-Status: GOOD ( 15.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, Mark Rutland , Will Deacon , linux-arm-kernel@lists.infradead.org, Jann Horn Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Catalin, thank you for your review. On 29/03/2019 12:12, Catalin Marinas wrote: > On Tue, Mar 19, 2019 at 03:15:38PM +0000, Vincenzo Frascino wrote: >> +static int __init aarch32_alloc_vdso_pages(void) >> { >> extern char __kuser_helper_start[], __kuser_helper_end[]; >> extern char __aarch32_sigret_code_start[], __aarch32_sigret_code_end[]; >> >> int kuser_sz = __kuser_helper_end - __kuser_helper_start; >> int sigret_sz = __aarch32_sigret_code_end - __aarch32_sigret_code_start; >> - unsigned long vpage; >> + unsigned long vdso_pages[2]; >> >> - vpage = get_zeroed_page(GFP_ATOMIC); >> + vdso_pages[0] = get_zeroed_page(GFP_ATOMIC); >> + if (!vdso_pages[0]) >> + return -ENOMEM; >> >> - if (!vpage) >> + vdso_pages[1] = get_zeroed_page(GFP_ATOMIC); >> + if (!vdso_pages[1]) >> return -ENOMEM; >> >> /* kuser helpers */ >> - memcpy((void *)vpage + 0x1000 - kuser_sz, __kuser_helper_start, >> - kuser_sz); >> + memcpy((void *)(vdso_pages[0] + 0x1000 - kuser_sz), >> + __kuser_helper_start, >> + kuser_sz); >> >> /* sigreturn code */ >> - memcpy((void *)vpage + AARCH32_KERN_SIGRET_CODE_OFFSET, >> - __aarch32_sigret_code_start, sigret_sz); >> + memcpy((void *)vdso_pages[1], >> + __aarch32_sigret_code_start, >> + sigret_sz); >> >> - flush_icache_range(vpage, vpage + PAGE_SIZE); >> - vectors_page[0] = virt_to_page(vpage); >> + flush_icache_range(vdso_pages[0], vdso_pages[0] + PAGE_SIZE); >> + flush_icache_range(vdso_pages[1], vdso_pages[1] + PAGE_SIZE); > > I wonder whether we still need the flush_icache_range() calls here. > Normally set_pte_at() handles cache maintenance automatically if > PG_dcache_clean is not set. We could probably just call > flush_dcache_page() here. > I agree, I am going to update the code accordingly and re-post the set. -- Regards, Vincenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel