From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] PCI: keystone: update to support multiple pci ports
Date: Fri, 05 Sep 2014 19:54:58 +0200 [thread overview]
Message-ID: <7260053.FoBVhTXVfj@wuerfel> (raw)
In-Reply-To: <1409938782-31460-1-git-send-email-m-karicheri2@ti.com>
On Friday 05 September 2014 13:39:42 Murali Karicheri wrote:
> +
> /* enable RC mode in devcfg */
> val = readl(reg_p);
> - val &= ~PCIE_MODE_MASK;
> - val |= PCIE_RC_MODE;
> + port_id <<= 1;
> + val &= ~(PCIE_MODE_MASK << port_id);
> + val |= (PCIE_RC_MODE << port_id);
> writel(val, reg_p);
> + devm_iounmap(dev, reg_p);
> + devm_release_mem_region(dev, res->start, resource_size(res));
This looks like it's a shared register of some sort that doesn't
really belong into the registers of a particular port. Could it
be that it's actually for the PHY?
Arnd
next prev parent reply other threads:[~2014-09-05 17:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-05 17:39 [PATCH] PCI: keystone: update to support multiple pci ports Murali Karicheri
2014-09-05 17:54 ` Arnd Bergmann [this message]
2014-09-05 18:33 ` Murali Karicheri
2014-09-05 19:00 ` Arnd Bergmann
2014-09-05 20:37 ` Murali Karicheri
2014-09-05 21:11 ` Arnd Bergmann
2014-09-08 15:52 ` Murali Karicheri
2014-09-09 10:24 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7260053.FoBVhTXVfj@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox