From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E00BC3DA49 for ; Tue, 16 Jul 2024 14:45:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:Subject:Cc:To:From:Date:References:In-Reply-To:Message-Id: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HdJd8R2v0UjEhqZCfsPDGAEjh3MgAu1qHR6wGuu4iUc=; b=RNau1mH3KqGQA0IdqD/RXhAm4e r5gR+nJNixLkXPCJj0kcd+1dJXgFXuHUq92ByTBu1hMJ6aBNC+xT8ekaPgMk6w2GB/Rl4b65673rJ ZfXFzJXjJX/b5aGISsOdm8BOF2smpH0L3KlSxfsr3EVk6jshAmQXy5fHLGvYC16quUodsJDGaziA8 ruEAw59m/j/esjlsQPo1RuWOss1SbxTHnpHMyWB0DImRFk04NIaWYd5f0U2LMQxJgZfwVl4nPDlzM x7jQP290e6Oh3GUJlcKsxyQKDLMu4M95f3I/dnREDf2ntxqU42YY5er2QOSwzhJdLq2moUqiTSdWW 9798Ci9A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTjQI-0000000AnES-0RF7; Tue, 16 Jul 2024 14:44:58 +0000 Received: from flow6-smtp.messagingengine.com ([103.168.172.141]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTjPw-0000000An8N-39WC for linux-arm-kernel@lists.infradead.org; Tue, 16 Jul 2024 14:44:38 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailflow.nyi.internal (Postfix) with ESMTP id C3416200EC4; Tue, 16 Jul 2024 10:44:34 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute5.internal (MEProxy); Tue, 16 Jul 2024 10:44:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1721141074; x=1721148274; bh=HdJd8R2v0UjEhqZCfsPDGAEjh3MgAu1qHR6wGuu4iUc=; b= KrQ+Yfl5XPrmhmvBUQ4viYOZ5BU/9t0cJnJKfn8BzZOV7J86Dc27qIzbbyRqmZkN L+RIF+FYOYSlA9jzGLh0YACdteyqUPbTWf9bhfOoBLC0IKbem2Y746umkeJYhKO1 USpO3R7/KM1Wn2fyqJ+PdyaVweaCMbG3cg1BWFtXYswGobw0QF1w5cXK1lFrfVCL epgUay9MYSblfwLMYArlaz3dDnUSHBJBEZjVSObVyw1Ia/vi93VsmBqTnsPDPHag X48V1hTibYmOFiSNVL8LG1ruAqTy1hNeTfL87eAwqTxlXqaIHQXOT9vz+ojWX8b5 koXReCi+2dgp1vgChQ7PmA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1721141074; x= 1721148274; bh=HdJd8R2v0UjEhqZCfsPDGAEjh3MgAu1qHR6wGuu4iUc=; b=h oW7cth5YO/ae5/c6V4w0yozDre/5a5M2vpdkW4jmES5p+r7bMWgWijNxf6QCEgkY +orQ7LceDdtdadru66WV0LDdiGUFhuMR9cwR1xXsuX+qWEUbiqvcib5Fuuc1cdQB wFtLMZYDjgUFrpD16fAfTeDvShFoJn5y/czLAJl7qglL02WVe7DCyjzVztlH4pGF 2SA7oPuno3JGV//uaX0SF/7bJmIMI8PScam2x1TXXqZkZ8IUC6IB1BC/o2uUDHjy kg101OgHbfAm2gyi9YYXQkVDtgwxhwDj2X99XzouZvFD2fTyXPMDC3Bwfx68wG7i MpJWTiBA7vxwW04Hy2DRA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrgeeggdejlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvvefutgfgsehtqhertderreejnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepgeefjeehvdelvdffieejieejiedvvdfhleeivdelveehjeelteegudektdfg jeevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id B26ACB6008D; Tue, 16 Jul 2024 10:44:33 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.11.0-alpha0-568-g843fbadbe-fm-20240701.003-g843fbadb MIME-Version: 1.0 Message-Id: <7289bb54-99f2-4630-a437-21997a9e2b1f@app.fastmail.com> In-Reply-To: <20240715141229.506bfff7@bootlin.com> References: <20240627091137.370572-1-herve.codina@bootlin.com> <20240627091137.370572-7-herve.codina@bootlin.com> <20240711152952.GL501857@google.com> <20240711184438.65446cc3@bootlin.com> <2024071113-motocross-escalator-e034@gregkh> <20240712151122.67a17a94@bootlin.com> <83f7fa09-d0e6-4f36-a27d-cee08979be2a@app.fastmail.com> <20240715141229.506bfff7@bootlin.com> Date: Tue, 16 Jul 2024 16:44:12 +0200 From: "Arnd Bergmann" To: "Herve Codina" Cc: "Rob Herring" , "Conor Dooley" , "Conor Dooley" , "Greg Kroah-Hartman" , "Lee Jones" , "Andy Shevchenko" , "Simon Horman" , "Krzysztof Kozlowski" , UNGLinuxDriver@microchip.com, "Saravana Kannan" , "Bjorn Helgaas" , "Philipp Zabel" , "Lars Povlsen" , "Steen Hegelund" , "Daniel Machon" , "David S . Miller" , "Eric Dumazet" , "Jakub Kicinski" , "Paolo Abeni" , "Horatiu Vultur" , "Andrew Lunn" , devicetree@vger.kernel.org, Netdev , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "Allan Nielsen" , "Luca Ceresoli" , "Thomas Petazzoni" Subject: Re: [PATCH v3 6/7] mfd: Add support for LAN966x PCI device Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240716_074436_879418_276BD1C9 X-CRM114-Status: GOOD ( 18.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 15, 2024, at 14:12, Herve Codina wrote: > Hi Arnd, > > On Fri, 12 Jul 2024 16:14:31 +0200 > "Arnd Bergmann" wrote: > >> On Fri, Jul 12, 2024, at 15:11, Herve Codina wrote: >> > On Thu, 11 Jul 2024 14:33:26 -0600 Rob Herring wr= ote: =20 >> >> On Thu, Jul 11, 2024 at 1:08=E2=80=AFPM Greg Kroah-Hartman wrote: =20 >>=20 >> >> > > >> >> > > This PCI driver purpose is to instanciate many other drivers u= sing a DT >> >> > > overlay. I think MFD is the right subsystem. =20 >> >>=20 >> >> It is a Multi-function Device, but it doesn't appear to use any of= the >> >> MFD subsystem. So maybe drivers/soc/? Another dumping ground, but = it >> >> is a driver for an SoC exposed as a PCI device. >> >> =20 >> > >> > In drivers/soc, drivers/soc/microchip/ could be the right place. >> > >> > Conor, are you open to have the PCI LAN966x device driver in >> > drivers/soc/microchip/ ? =20 >>=20 >> That sounds like a much worse fit than drivers/mfd: the code >> here does not actually run on the lan966x soc, it instead runs >> on whatever other machine you happen to plug it into as a >> PCI device. > > Maybe drivers/misc ? That's probably a little better, and there is already drivers/misc/mchp_pci1xxxx in there, which also has some aux devices. Maybe we need a new place and then move both of these and some of the similar devices from drivers/mfd to that, but we don't really have to pick one now. Arnd