From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 12418C77B61 for ; Sat, 8 Apr 2023 21:46:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7KFLayNLrE57nKORgbdwKLrp01lOp7rqsvDEzZWucuM=; b=RNe7pTEv9/ELdc yGf3U50++R+iklAl0tFGSa5ZndACbH5+6GJDg6iim5CxC+n7H8fEsiLn+vgWq7/FUnFEmOxIaDXXK QiJKhN56czcF9zSN5Hr1Yq3TsqlT8Lx23OlxfxtVGyBIYCcL9Dwx9yKIIzrlFyLX41Rlaip5sB13a MiL/DVk2bJtN9vW7WH1sSblwVdnn5UUkWEeRIyOh8nesHjr4NsvmLjq6LtcTjEK1so4YUEr9AGVIa Itno5ZGezr5uBScF/m0zrRfSuAGbW3jYVKzUggV1/FkNt2d8p8aWzgXbr6ubo9B/akIvIOFs9jwRJ ZaO9miJUY5qhiNJsR1jQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1plGNT-00Cqw3-3B; Sat, 08 Apr 2023 21:45:44 +0000 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1plGNQ-00Cqve-0o for linux-arm-kernel@lists.infradead.org; Sat, 08 Apr 2023 21:45:41 +0000 Received: by mail-pl1-x634.google.com with SMTP id p8so1791286plk.9 for ; Sat, 08 Apr 2023 14:45:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680990338; x=1683582338; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=zqgSPZYBsDtVwiEZJVoDEmESaLU5H7DMz1BSoSn2S1Y=; b=mSJ/X1rr3c3vVPHxFoGeOmsi6zaCi+/+edXfzwes87BlIz/bdb4KVwCpsAogLkEECe H6FQLGTn8KB+93PdqO6eDEMypOPMpiVhXpRRuSCABL+waC1lujqqI8kO7eC+mqqDXbOf VkrdcDUSM/E758jYGxcj+lFncSdPQmn9mShx0nPK6hZTgsEzv8SY5ngjuqGyh5iaHbMg sDH/6uTCb8YCLZKmpujxpog07gJAhEeHLDUW99I6XiP6icQSyI0sY8u6cbjbdbPs9H3U OUUDM2C3G0I+H8BXAav2HpVuaS/92Ay35V+8b825chzgZfM3iGRm5tBSUFdh4G6p2jNC xgLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680990338; x=1683582338; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zqgSPZYBsDtVwiEZJVoDEmESaLU5H7DMz1BSoSn2S1Y=; b=5/iRbYBR2xo3Q9Eyz7zD8R1ETTelpxrsBNLS6xqh9bmPlzYiNA1HZrUKm97SZK8pqW UD/kwKbP272syPe6QDiQPpIFiQ6CQkhjJrcygzci5NK1YIGSzJ72cyyJVwTVsalrzjV/ HLLAcjbyIPaQWOrasA+8Cag+SNlikjxSa9+JaVUefMVOKqX3egLRVjvLh6G+UOI4xe/m 5dt9n+U9wzFiU3e3wMOO2AyEJsrx+Peh2StfKOnaaTbNe/9Bz2cnwE13XkkL6AxUrvJf ZgFN4nrmeTExVimkxVtHeGJOG5VcFN/AmtR3Y0fiigWMdJz486I6jwjE8C5snebraCb+ bnTg== X-Gm-Message-State: AAQBX9ddd9tEoRri60J5ZPh7c9I94+nDGU2j90LaapR4WlvV77Dw1/UK +WoqJcCzT1t58qW+Mr8gyPc= X-Google-Smtp-Source: AKy350YeQ+EjOvH0//H82sraUYKe/H1jY2NGbOgELoyt7GUy4+kORmVMIBbchbzc/x3LIarUd4YXuA== X-Received: by 2002:a17:90b:1e0f:b0:23f:ebf2:d3e9 with SMTP id pg15-20020a17090b1e0f00b0023febf2d3e9mr7851623pjb.6.1680990338393; Sat, 08 Apr 2023 14:45:38 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id g15-20020a17090a7d0f00b002309279baf8sm6586668pjl.43.2023.04.08.14.45.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Apr 2023 14:45:37 -0700 (PDT) Date: Sat, 8 Apr 2023 14:45:36 -0700 From: Guenter Roeck To: Tom Rix Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, wim@linux-watchdog.org, nathan@kernel.org, ndesaulniers@google.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH] watchdog: s3c2410: remove unused freq_to_wdt and s3c2410wdt_is_running functions Message-ID: <72a085ff-172f-4378-8ee2-5bf1e47958bf@roeck-us.net> References: <20230321183439.1826823-1-trix@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230321183439.1826823-1-trix@redhat.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230408_144540_427550_28856E80 X-CRM114-Status: GOOD ( 15.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 21, 2023 at 02:34:39PM -0400, Tom Rix wrote: > clang with W=1 reports > drivers/watchdog/s3c2410_wdt.c:311:35: error: unused function > 'freq_to_wdt' [-Werror,-Wunused-function] > static inline struct s3c2410_wdt *freq_to_wdt(struct notifier_block *nb) > ^ > drivers/watchdog/s3c2410_wdt.c:446:19: error: unused function > 's3c2410wdt_is_running' [-Werror,-Wunused-function] > static inline int s3c2410wdt_is_running(struct s3c2410_wdt *wdt) > ^ > These functions are not used, so remove them. > > Signed-off-by: Tom Rix > Reviewed-by: Andi Shyti Reviewed-by: Guenter Roeck > --- > drivers/watchdog/s3c2410_wdt.c | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/drivers/watchdog/s3c2410_wdt.c b/drivers/watchdog/s3c2410_wdt.c > index 200ba236a72e..6394dda7a5dc 100644 > --- a/drivers/watchdog/s3c2410_wdt.c > +++ b/drivers/watchdog/s3c2410_wdt.c > @@ -308,11 +308,6 @@ static inline unsigned int s3c2410wdt_max_timeout(struct s3c2410_wdt *wdt) > / S3C2410_WTCON_MAXDIV); > } > > -static inline struct s3c2410_wdt *freq_to_wdt(struct notifier_block *nb) > -{ > - return container_of(nb, struct s3c2410_wdt, freq_transition); > -} > - > static int s3c2410wdt_disable_wdt_reset(struct s3c2410_wdt *wdt, bool mask) > { > const u32 mask_val = BIT(wdt->drv_data->mask_bit); > @@ -443,11 +438,6 @@ static int s3c2410wdt_start(struct watchdog_device *wdd) > return 0; > } > > -static inline int s3c2410wdt_is_running(struct s3c2410_wdt *wdt) > -{ > - return readl(wdt->reg_base + S3C2410_WTCON) & S3C2410_WTCON_ENABLE; > -} > - > static int s3c2410wdt_set_heartbeat(struct watchdog_device *wdd, > unsigned int timeout) > { _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel