From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B4B27C7EE43 for ; Tue, 13 Jun 2023 02:19:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Oet2Byyj4AqQW9a+bMVI8m2gjl3aF4PsBQJ9HI4dINw=; b=lwsV5fr44oYM2K TjBvVMB3Ymn9HmO9iS8Y98WsIxdbhhDCfNbTyFyQTn3Nqa4AofXyOjXmV7l4HX4tEb0XerBykqNjp Wo5AS13mGY9LTIPbvSV/Kd+uCyNZGwrmLr3P5X3V2HPMS0aioawlY6WD1HVCLwnE/YFfyPMZBf5rc LH2/4qfdpJQETNK2Qeb2I4bla925lSx9HpYI2xMsWby13HRFucPyt67rZ9BRRpC/mXzPI9aXVEztx BY6IitqmoZZLStGS4ogaY+ANkg20PhI1IZJXIRV5AlgwSVP0JJ/ly9svz0/9+BxDvVcmzZ8nP4MrJ kPwHriIOhTZbfX8uPf/w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q8td1-006evP-0u; Tue, 13 Jun 2023 02:19:27 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q8tcx-006etj-0v; Tue, 13 Jun 2023 02:19:25 +0000 X-UUID: b19f39e6099011ee912e1518a6540028-20230612 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=MIME-Version:Content-Transfer-Encoding:Content-ID:Content-Type:In-Reply-To:References:Message-ID:Date:Subject:CC:To:From; bh=z+89LRzux1llJZDsU9oW/y2sS6oTabgmm+ABowQx170=; b=RMa2A/4PEd72Ceh+25CZqS5l46/ZNLtqMAJ2DLrsygBG8BmyuQOu0NmK0RbKyVydfbNSrWReF49JN6sr0gNTnTeA9KOqgex+6fKggmI2xZZIEVpqovbzn7ChKdTXRRCwWr9X4o85++6MM7wu0lqFM5oz8PauoJ+WXW7QS4fjD9s=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.26,REQID:6778717f-0707-4641-bb11-2dfcbca880aa,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:cb9a4e1,CLOUDID:abcddd6e-2f20-4998-991c-3b78627e4938,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-UUID: b19f39e6099011ee912e1518a6540028-20230612 Received: from mtkmbs11n1.mediatek.inc [(172.21.101.185)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 2126699046; Mon, 12 Jun 2023 19:19:15 -0700 Received: from mtkmbs10n1.mediatek.inc (172.21.101.34) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Tue, 13 Jun 2023 10:19:13 +0800 Received: from APC01-SG2-obe.outbound.protection.outlook.com (172.21.101.237) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Tue, 13 Jun 2023 10:19:12 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MTU/ZK767ViiItoO/sVoP47BiLWyn/jFhqMcMh6OMhqzUz5Ifm6A8S8zDN3xcm4z+/eVVWXwxO7aZbdvsHvy4rI9uWKD/KGAOO+DLjnQvxvuPPbP3CJmMVUj8fqijk0p0qivXSvGqBRg4z/Ja0yqYbHclavOy0XcIc07j5Bvs5tElJDz0ABMZMF06ZCeSiEjdb7wUsPJhnT5DyDO5QusE5bA+yKzcJlUIxLTxuqPa80r70MmvE81uySZHMSObYmyk+hZ0zXWOaeNjVjh9LQlL5YF4gsZHrxBD14xIejvny2IACG9qDbHV41e6I3REE6F4nBhtREQOdj7qVv0MFD+/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=z+89LRzux1llJZDsU9oW/y2sS6oTabgmm+ABowQx170=; b=YB+pMhB2naO1nFHNGaqEzx9XSQ1WhxOF7nS+smy9HTy01SVMePa90Xuw9tZd9VOtOC8T+1AcswIOoA9qjjj0IsKY+/oe0ETHA2T88xaEUQIVuHPXrKVWf3G0x5ufszCy/09D+r8JT+j/Wp2zjgr2ExLFVnBfALq/UUPwocK83rgTBmR7MlEywa+uabiy98JRs8MGyfI4ISsneW2IqSnQruPFpq2MrC/7gzBPUhAhBon7SZuDL4esj2iRa0A4nS05w8+Z6X2QA1wGZ6jiOZ0PhfZGa5nBULPX4RUbnOE+8KoB4+0w2ifZkWXK0Lxpja6KvFwy/ugf9kzx51ohnPkXkw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mediatek.com; dmarc=pass action=none header.from=mediatek.com; dkim=pass header.d=mediatek.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mediateko365.onmicrosoft.com; s=selector2-mediateko365-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z+89LRzux1llJZDsU9oW/y2sS6oTabgmm+ABowQx170=; b=TvKq6SjkA0aGk+LjBWftno1mjohUaoIiwLjlMZUeTPOKR2bHkLk3WvtTWRyp1GWI30Y0teLQGrDrOj060a4tWIcXr0BbJ/DdVFOSW9U2Ho22EfX7pNa2lCpnxHoouOHt3ldicwFaq3MiLIB19SJ7kLegkqbZsRk8fDLPzBrD7OI= Received: from TYZPR03MB6624.apcprd03.prod.outlook.com (2603:1096:400:1f4::13) by TYUPR03MB7207.apcprd03.prod.outlook.com (2603:1096:400:344::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.33; Tue, 13 Jun 2023 02:19:10 +0000 Received: from TYZPR03MB6624.apcprd03.prod.outlook.com ([fe80::6fdb:ba2c:bcfc:d5ed]) by TYZPR03MB6624.apcprd03.prod.outlook.com ([fe80::6fdb:ba2c:bcfc:d5ed%6]) with mapi id 15.20.6455.037; Tue, 13 Jun 2023 02:19:10 +0000 From: =?utf-8?B?Q0sgSHUgKOiDoeS/iuWFiSk=?= To: "robh+dt@kernel.org" , "kishon@ti.com" , =?utf-8?B?Q2h1bmZlbmcgWXVuICjkupHmmKXls7Ap?= , "chunkuang.hu@kernel.org" , =?utf-8?B?Sml0YW8gU2hpICjnn7PorrDmtpsp?= , "daniel@ffwll.ch" , "granquet@baylibre.com" , "p.zabel@pengutronix.de" , "airlied@gmail.com" , "krzysztof.kozlowski+dt@linaro.org" , "vkoul@kernel.org" , "matthias.bgg@gmail.com" CC: "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , =?utf-8?B?TWFjIFNoZW4gKOayiOS/iik=?= , "devicetree@vger.kernel.org" , "krzysztof.kozlowski@linaro.org" , =?utf-8?B?U3R1YXJ0IExlZSAo5p2O57+wKQ==?= , "dri-devel@lists.freedesktop.org" , "linux-arm-kernel@lists.infradead.org" , "angelogioacchino.delregno@collabora.com" Subject: Re: [PATCH v4 5/8] drm/mediatek: hdmi: add v2 support Thread-Topic: [PATCH v4 5/8] drm/mediatek: hdmi: add v2 support Thread-Index: AQHZkjsmmHc/VTGOHU6M5MEfnDzs/6+IFmcA Date: Tue, 13 Jun 2023 02:19:10 +0000 Message-ID: <72a13a42260d39c2495c59241d661f3a7a18c492.camel@mediatek.com> References: <20220919-v4-0-687f09a06dd9@baylibre.com> <20220919-v4-5-687f09a06dd9@baylibre.com> In-Reply-To: <20220919-v4-5-687f09a06dd9@baylibre.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=mediatek.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYZPR03MB6624:EE_|TYUPR03MB7207:EE_ x-ms-office365-filtering-correlation-id: 823c2220-213c-49d3-0f0e-08db6bb492fa x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: hS37FRpPJ6JUWCuWb9hb+U+Z5buujOYWslDFM9XTxe0NwCBZV22nS/AK16LDEoLk0z3IaCsKa0nkEtZI/dzNnxxmcRm8L0rAdjrm+DgsbTmz1L2mUd1v5kgUs1jumXGZsOqqR5uPEjhOvKkPMs5SCCJrqEmR+oaGsnF5GMgCGqND9ggcdNf1akg2Uy1/IiRT+8nrXodzP/QFBSKDBIk3rVzmsmYnFfmpgPT30UvT3+w/52iBOwywss+EZpIUhLgqMLnOWXtqQXhAuXpC+WEMymF1q/cgKuFR5322mgkHs/Dw6X1bFt/ZPBXNcv0A15EURRxspxxmk5DOsZAOCwf7XEUbw2g+gp/6DHOeJt/TU92gUrGQQd0mS/tSLlzKjLEnhBbQOq1aoDWgAudTxUq4fYvGJz6dxq9nZpjBtaBGtapXAWQBhUC4CBMoVpG6yXLSlTKI4eCCsESFC3FYScGteL6uzfSqDcuTZM08gTSchQ/8lwKOtGeL1UOzeFPp4o3Js9XV9SiDVoK5Gs5txErt/Y8SN04rQpOzjhc7dvJfN34jWKi5C10fzSACxEOhlHKGF06e+IptPsBH8OjB4W8gsS1d8KdXpMcP0LjeDfahJhJndNRpgQLlyjraCCjLJ2BjGG2ZM7VMkRrd4Y+OdAkIlA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TYZPR03MB6624.apcprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(396003)(376002)(39860400002)(366004)(136003)(451199021)(66946007)(8676002)(4326008)(66556008)(76116006)(36756003)(85182001)(41300700001)(64756008)(66476007)(66446008)(316002)(6486002)(8936002)(86362001)(83380400001)(7416002)(5660300002)(2906002)(54906003)(110136005)(478600001)(71200400001)(38070700005)(38100700002)(186003)(122000001)(2616005)(921005)(6512007)(6506007)(26005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?bGUvUVR0QUd5RDF2bUdFZmxGbUp0N04vOWJ6Y3NzaWlhOUlITFFsclZvOVF3?= =?utf-8?B?ZEorRUxrc1Z3OU90M0ZqbjBpOWYzRWt2Y1l2TzM2WGZaS3V1UUhENDhUT1JP?= =?utf-8?B?ZlVxd3NOd0d0RmhPYTFuVU1uTm5tUXg2d1Z6OVA1a2JYanJMVTZaajBJSjBj?= =?utf-8?B?T25ndGZkb1VHOS94WFFtcExlaGk2eS84Nk5EZGdrTDdIZDRyNnJyQWhibmEw?= =?utf-8?B?c1ZOaGFGWFhodGJ0cnZ3Y3Y3RC82SUU1eUc4eWt4TUpZbUxISEJkQnZXbklM?= =?utf-8?B?eTg3VG1EckZvdmVaSm5rc2s1L0dwMzdkU1dzQVN2Y0VUSTEyZFBQK0ExTmox?= =?utf-8?B?OFlSaDRJeDUwWldRT1JESURVQ1JpTVdqWmZqcGkyeE5FSGpWanpJTlpjQno3?= =?utf-8?B?Vm5XVlFMdU0xRW8zV1hqamM5dzZselBZRnBjMkluNTA1TTVuN3pFMURVYTRL?= =?utf-8?B?OFF2NXVwVFdrT0p1ZXg1M2dhcllvalJZTkZxUDZ6eEowdWYrYTIvdVpwdzBt?= =?utf-8?B?eDZhaVM2R0xGaXhFU2JqWVpQTnFOZVA2cG9WNG5XbEhCcnNrYklscUNHYU5n?= =?utf-8?B?dTdIUC9tOXA2ZzdwREN0c1JSRkltL3Ayby8yc2RLUHA2cXB1bXN6VlkvcnBQ?= =?utf-8?B?VVBKQ0M5alJEczJKbFEvbFhZRVdmWEpsb2tYRzhWL01UUUNwdXJDUWNvNkhw?= =?utf-8?B?R3loYlk0bStZVW1nb0ZkMFpza01rYVIzbGpJcWdJUXR5Q0dnUVBGRC9IZFJp?= =?utf-8?B?UmtOSkVOMFVmdGN0V3dTK0hwc3ZNRjFzSWZnZDZRS1k5aG51NWtxelEvTDNF?= =?utf-8?B?VlB6WkF2bDkvUmcvZ1dnbFk3S2VZT2hld2ZmVGdxS3NtS2NoOXQxaGdlaTEv?= =?utf-8?B?akZ3bjJiYnhRY1VaajM5WjdrUkw3bjFsVS9waVJBZE9pSXpURXBQRG1XanFT?= =?utf-8?B?eWlxR3VMbklxRlFFTjhINTBTTmZQeE4xdVdETUdvMVdxYWI1OWNsU1crU1hX?= =?utf-8?B?dUJpaEtpN2NrUlIzZzBIc0pVMmsrM2tXZTNUNHh1UGpzTW1kU3FNVDhDMENU?= =?utf-8?B?ZEFhWTVUNi9KRG00TnRFMElMdGVCcEsvbHdLK09UUG5aNjU0RlIzdFBUNlpF?= =?utf-8?B?K3pZT05wK0o0c05rd1RNcE5TaXNyTlBqQmJFeEVqSEZleU1raTYrUmRoZndz?= =?utf-8?B?WkFHRXVUUUdQOWFEd1hzMENXSFN6QzFCb0ZtYkd2aU5NWklzWWtHaVMxOFVr?= =?utf-8?B?RjBYWDVMSURhYXFDNXdNMHQzdmhFL25uRU9yUGk2eW0xQ1FJQS84c2tYNmpw?= =?utf-8?B?bUlVNkpWMzVBV2N5QVRNY1N0WU12Rlk4VDZTTlpMZU5qeVkrb2xDSzRyYTZD?= =?utf-8?B?eTVQc0ttMzdiYzdvaEtDT213eTVqemdMaGsxTDJvR1JKWTNjRTlnVURYYTJu?= =?utf-8?B?WGp4TjVBd0RFRktOaml1RWhzeE5KR281WXQyUWVrVTBLUm94UCtKVnUrcUsy?= =?utf-8?B?aGd0b0RGbmdjTWZ5N2g5SENrakJGdzlUOGlheC9Ka3BqV3p4UWxyeE04NHRo?= =?utf-8?B?emJmdG95K3RSdGEyVERqZ01ic0hlTVo2eWlOMXVTN3hFNit2SWtta2hlUW5j?= =?utf-8?B?S1ZzekNnd21acUd2aDA4ZmZFeXp5ZTM1bmRwcThDTjVZTDMvTmZKWXlNT09j?= =?utf-8?B?WjRIOGI2bWxsSTRTRG0rTE1rdGNuTll5MmtkMHJneWxrZng0K3V5ZFZ3dmM2?= =?utf-8?B?TUw0czA1OWtVYzFVd2I5UUxObTAzMEpmRXdZNG1rNFBhdldDbzhYNitGeE5Y?= =?utf-8?B?QU5qbVZwbnNJcDQzVmkyWHVXREJnVmNlTlhqS2puZFRWL21xWHpUdlU5NVAy?= =?utf-8?B?UTZYMEN6S0ZEaEhrZmtBZ1dvazl6ekhBWkJEajBRWEIzK2dCVS9DZkh4Ukxw?= =?utf-8?B?dVgzTXRyTU5rYTVGNHZVVlF2N2xMWGw5SUVLV3FqT09BenNpUDR1Lzh1VTJX?= =?utf-8?B?bXI1MXp0dXBzbGZyK3ltRTV4d1FqVmtnVVhTOXI1T0o2L1VHT0l3Tld6TWNi?= =?utf-8?B?cjZldnVBMCtHTlhXSVNnQlV2T0cwOTA0SzJVL20zWXFnbnp2Uk5waitscm4w?= =?utf-8?Q?pOYE1IpYXz5vMhH6fA3zt6Xcw?= Content-ID: <1C31301C935D9E4199FEA32ADC86FCDC@apcprd03.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYZPR03MB6624.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 823c2220-213c-49d3-0f0e-08db6bb492fa X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jun 2023 02:19:10.6672 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a7687ede-7a6b-4ef6-bace-642f677fbe31 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +KJCa+KSGp6o+5/fNAhTRMmwQosgtsvYycNe+XajKd9O7tq17fjo1UlsJFFPftw+cKw2hlh9vBX3ioz8g4jehw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYUPR03MB7207 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230612_191923_623264_C5D701E9 X-CRM114-Status: GOOD ( 18.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Guillaume: On Mon, 2023-05-29 at 16:31 +0200, Guillaume Ranquet wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > Adds hdmi and hdmi-ddc support for v2 IP. > > Signed-off-by: Guillaume Ranquet > --- [snip] > + > +static bool fg_ddc_data_read(struct mtk_hdmi_ddc *ddc, > + unsigned char b_dev, > + unsigned char b_data_addr, > + unsigned char b_data_count, > + unsigned char *pr_data) > +{ > +int ret; > + > +mutex_lock(&ddc->mtx); Why do you need this mutex? fg_ddc_data_read() and fg_ddc_data_write() are called by mtk_hdmi_ddc_xfer() which is the callback function of master_xfer. In original hdmi driver, it's not necessary to use a mutex to protect master_xfer, so I think this is not necessary. Regards, CK > + > +hdmi_ddc_request(ddc); > +ret = vddc_read(ddc, DDC2_CLOK, b_dev, b_data_addr, SIF_8_BIT_HDMI, > + pr_data, b_data_count); > +mutex_unlock(&ddc->mtx); > + > +return ret == b_data_count; > +} > + > +static void fg_ddc_data_write(struct mtk_hdmi_ddc *ddc, > + unsigned char b_dev, > + unsigned char b_data_addr, > + unsigned char b_data_count, > + unsigned char *pr_data) > +{ > +unsigned int i; > + > +mutex_lock(&ddc->mtx); > + > +hdmi_ddc_request(ddc); > +for (i = 0; i < b_data_count; i++) > +mtk_ddc_wr_one(ddc, b_dev, b_data_addr + i, *(pr_data + i)); > + > +mutex_unlock(&ddc->mtx); > +} > + > +static int mtk_hdmi_ddc_xfer(struct i2c_adapter *adapter, struct > i2c_msg *msgs, > + int num) > +{ > +struct mtk_hdmi_ddc *ddc = adapter->algo_data; > +struct device *dev = adapter->dev.parent; > +bool ret; > +int i; > +unsigned char offset; > + > +if (!ddc) > +return -EINVAL; > + > +for (i = 0; i < num; i++) { > +struct i2c_msg *msg = &msgs[i]; > + > +if (msg->flags & I2C_M_RD) { > +/* The underlying DDC hardware always issue a write request > + * that assigns the read offset as part of the read operation. > + * Therefore we need to use the offset value assigned > + * in the previous write request from the drm_edid.c > + */ > +ret = fg_ddc_data_read(ddc, msg->addr, > + offset, /* determined by previous write requests */ > + (msg->len), &msg->buf[0]); > +if (!ret) { > +dev_err(dev, "ddc read failed : %d\n", ret); > +return ret; > +} > +} else { > +fg_ddc_data_write(ddc, msg->addr, msg->buf[0], > +(msg->len - 1), &msg->buf[1]); > + > +/* we store the offset value requested by drm_edid framework > + * to use in subsequent read requests. > + */ > +if (DDC_ADDR == msg->addr && 1 == msg->len) > +offset = msg->buf[0]; > +} > +} > + > +return i; > +} > + _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel