From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 003D9C7EE2E for ; Thu, 8 Jun 2023 08:58:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PnPHFvr5iISQV/OJ+cP+4ebcwimX3xBpl+Na2B2oHNw=; b=XogN4gKz6poyRf 6gIiTP0q8F5DOXXopaODXORmiOvJSGXfUO7m/DOB6yL0ZYNPFvZG6/XUcAWdbXugzhGGklN49fGop dZM3DEa/a/WyLv4z3JT0rTMsr2A3EHba+bfSvjfIJAI3SlsyaVvVZJ43nSv982SlpWmYe8ROVDQLg N9vnJhcHbiKVC90dX1ZW1/biWMmYo2wN6m6B7LforfEMCoHFDE483NQE5CSZpPy2+jyWtfvcAqjj/ CUAXM6m9otYzilQAuCerJGNUO3bFCqkTgEmbPJWPUrC229NsKO2/cflNMpuqymt5Uvm2mdQmXZCQW 37+dezpM8ExslMmSfZRw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q7BSv-008cau-0X; Thu, 08 Jun 2023 08:57:57 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q7BSs-008ca6-1y for linux-arm-kernel@lists.infradead.org; Thu, 08 Jun 2023 08:57:55 +0000 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-3f6da07feb2so2856275e9.0 for ; Thu, 08 Jun 2023 01:57:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686214673; x=1688806673; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=jtme5s3dRQf7Gtdgff/AfDj88pgSYDNPfGdCGVzp2R0=; b=gra6jAlodbU30t5m7gbdPhx1pmD3IYs4W5CF5e7hZz0ughSR54Qmhb0FbJWse1Xlm1 XdkDYHT+hlIKFWiiLJznQwhuxbGB9YuXZh4ntt22vuiYvDYkACBpWgER6p6r72F/Rh0H vSqJo1zRg9aIqJRGg10zUQSMhHH4lVZmTeok6WF4OWh8Dn0ls4YORpjvQU30QHQp2hL3 dfhtKEIW5f3FTrczaxzXv1CvHEPVLZ/97Z/FZ1tgXON9l+d8tAUWIpv758ut5jfiDuvl 1lB3D1lkIuQ/yEhN0TUavj6iR5hTRCPAWRUBn/UTtS0tpLfPXvLV0TLHq+nstox4cO/y wszw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686214673; x=1688806673; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jtme5s3dRQf7Gtdgff/AfDj88pgSYDNPfGdCGVzp2R0=; b=gDzqaLoz6J/KbR1WXLsKUDa4WybpKw0S7aXwkMnrCyIPXK5E8mmoY9q2Wpf3JM4a/v gy/nwztZYBNeFJhmvXUu0/ftv0YkTUD8oiQR4fkVXgi10zIua1vE0zPvL+1i4a3HCqxl l3YGenA4uCgeUP6k5rMsCgHigAdtMTZyn4AmLQFQFh2isaB9gbu5CYMZfbpUn1x8Vk11 iXzJ/DIWWvnDIFFaKKqJGL10fDoyMOvnzf5aKhpuN2owN7kJj2oTvb/Z8y8dbu9JBSaD ukFCJCT9Wv8efpSPfUw4AU5UVeHT8eykX9yG49GeTZuQ2mm+jT1r1JZ50CSo2onIsclK Hv8g== X-Gm-Message-State: AC+VfDzbGv7/r+S2kO3sTJQj4WN/3xCvL/LGXih7N/FUcwEIeoEubsnR TuiWC96aPEFKLjt6jbKUefABBA== X-Google-Smtp-Source: ACHHUZ5Oj7KBjt/jU4KYcCWRyKtv4qWOgTZdAtGVt+sxedJk020uqbAfEPNcT/IfNVY3AFUKbwvv7A== X-Received: by 2002:a05:600c:364b:b0:3f1:93c2:4df7 with SMTP id y11-20020a05600c364b00b003f193c24df7mr780513wmq.5.1686214672973; Thu, 08 Jun 2023 01:57:52 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id o17-20020a05600c379100b003f4e3ed98ffsm1259957wmr.35.2023.06.08.01.57.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jun 2023 01:57:50 -0700 (PDT) Date: Thu, 8 Jun 2023 11:57:46 +0300 From: Dan Carpenter To: Trevor Wu =?utf-8?B?KOWQs+aWh+iJryk=?= Cc: "lgirdwood@gmail.com" , "kernel-janitors@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "broonie@kernel.org" , "tiwai@suse.com" , "amergnat@baylibre.com" , "linux-arm-kernel@lists.infradead.org" , "matthias.bgg@gmail.com" , "perex@perex.cz" , "alsa-devel@alsa-project.org" , "angelogioacchino.delregno@collabora.com" Subject: Re: [PATCH v2] SoC: mediatek: mt8188-mt6359: clean up a return in codec_init Message-ID: <72aee5eb-792e-40c0-83a5-79618fca30a3@kadam.mountain> References: <42f2a995-3545-40bf-82a0-fd9b8abc16ce@moroto.mountain> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230608_015754_660126_9CB8E6EE X-CRM114-Status: GOOD ( 20.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBKdW4gMDgsIDIwMjMgYXQgMDQ6MDI6MDdBTSArMDAwMCwgVHJldm9yIFd1ICjlkLPm lofoia8pIHdyb3RlOgo+IE9uIFdlZCwgMjAyMy0wNi0wNyBhdCAxNzo1NyArMDMwMCwgRGFuIENh cnBlbnRlciB3cm90ZToKPiA+ICBUaGlzIGNvZGUgdHJpZ2dlcnMgYSBTbWF0Y2ggc3RhdGljIGNo ZWNrZXIgd2FybmluZyBhbmQgZG9lcyBzb3J0IG9mCj4gPiBsb29rIGxpa2UgYW4gZXJyb3IgcGF0 aC4KPiA+IAo+ID4gc291bmQvc29jL21lZGlhdGVrL210ODE4OC9tdDgxODgtbXQ2MzU5LmM6NTk3 Cj4gPiBtdDgxODhfbWF4OTgzOTBfY29kZWNfaW5pdCgpIHdhcm46IG1pc3NpbmcgZXJyb3IgY29k ZT8gJ3JldCcKPiA+IAo+ID4gSG93ZXZlciwgcmV0dXJuaW5nIDAgaXMgaW50ZW50aW9uYWwuICBN YWtlIHRoYXQgZXhwbGljaXQuCj4gCj4gSGkgRGFuLAo+IAo+IFRoZXJlIGFyZSBzZXZlcmFsIHNp bWlsYXIgaW5zdGFuY2VzIGluIHRoaXMgZmlsZS4gSWYgdXNpbmcgJ3JldHVybgo+IHJldDsnIGlz IG5vdCByZWNvbW1lbmRlZCwgc2hvdWxkIHdlIHVwZGF0ZSBhbGwgb2YgdGhlbSBzaW11bHRhbmVv dXNseT8KPiAKPiBGb3IgaW5zdGFuY2UsIHRoZSB2YWx1ZSBvZiAncmV0JyBhdCB0aGUgZW5kIG9m IHRoaXMgZnVuY3Rpb24gc2hvdWxkCj4gYWxzbyBiZSB6ZXJvLgo+IAoKSSB3b3VsZCBwcmVmZXIg dGhhdCwgeWVzLiAgInJldHVybiAwOyIgaXMgYWx3YXlzIG1vcmUgY2xlYXIgdGhhbgoicmV0dXJu IHJldDsiCgpJIGRpZG4ndCBjaGFuZ2UgdGhlICJyZXR1cm4gcmV0OyIgYXQgdGhlIGVuZCBvZiB0 aGUgZnVuY3Rpb25zIGJlY2F1c2UKdGhleSB3ZXJlIG9idmlvdXNseSBpbnRlbnRpb25hbC4gIEkn bSBkb2luZyBzdGF0aWMgYW5hbHlzaXMgYW5kIEkgaGF2ZQphbiB1bnB1Ymxpc2hlZCBjaGVjayB3 aGljaCBjb21wbGFpbnMgYWJvdXQgdGhlIHJldHVybiByZXQgYXQgdGhlIGVuZApvZiB0aGUgZnVu Y3Rpb24gYnV0IEknbSBub3QgZ29pbmcgdG8gcHVibGlzaCBpdCBiZWNhdXNlIHRoYXQgZG9lc24n dApmaW5kIGJ1Z3MgYW5kIEknbSBvbmx5IGZvY3VzZWQgb24gYnVncy4KCldoZW4gd2UgaGF2ZSBj b2RlIGxpa2U6CgoJcmV0ID0gZnJvYigpOwoJaWYgKHJldCkKCQlyZXR1cm4gcmV0OwoKCWlmICh4 ID09IDEpCgkJcmV0dXJuIHJldDsKCk1vcmUgb2Z0ZW4gdGhhbiBub3QsIHRoYXQgaXMgYSBidWcu ICBCdXQgaWYgaXQncyBjb2RlIGxpa2U6CgoJcmV0ID0gZnJvYigpOwoJaWYgKHJldCkKCQlyZXR1 cm4gcmV0OwoKCWZyb2IoKTsKCWZyb2IoKTsKCWZyb2IoKTsKCglyZXR1cm4gcmV0OwoKVGhlbiB0 aGF0J3MgcHJvYmFibHkgbm90IGEgYnVnLgoKcmVnYXJkcywKZGFuIGNhcnBlbnRlcgoKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJu ZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRw Oi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK