From: Markus Elfring <Markus.Elfring@web.de>
To: Karl Mehltretter <kmehltretter@gmail.com>,
linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com,
Adrian Hunter <adrian.hunter@intel.com>,
Al Cooper <alcooperx@gmail.com>,
Kamal Dasu <kamal.dasu@broadcom.com>,
Ulf Hansson <ulfh@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Gregor Herburger <gregor.herburger@linutronix.de>
Subject: Re: [PATCH] mmc: sdhci-brcmstb: don't log an error for missing BOOT registers
Date: Fri, 9 Oct 2026 11:40:41 +0200 [thread overview]
Message-ID: <72b28833-fa0f-461b-a30f-bc15c1b34cea@web.de> (raw)
In-Reply-To: <20261009003201.68288-1-kmehltretter@gmail.com>
…
> +++ b/drivers/mmc/host/sdhci-brcmstb.c
> @@ -491,6 +491,7 @@ static int sdhci_brcmstb_probe(struct platform_device *pdev)
> struct sdhci_brcmstb_priv *priv;
> u32 actual_clock_mhz;
> struct sdhci_host *host;
> + struct resource *boot_res;
…
I suggest to reduce the scope for this local variable because you would like to use it only
within a selected if branch.
https://elixir.bootlin.com/linux/v7.3-rc6/source/drivers/mmc/host/sdhci-brcmstb.c#L535-L540
Regards,
Markus
prev parent reply other threads:[~2026-10-09 9:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-09 0:32 [PATCH] mmc: sdhci-brcmstb: don't log an error for missing BOOT registers Karl Mehltretter
2026-10-09 7:11 ` Gregor Herburger
2026-10-09 9:40 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72b28833-fa0f-461b-a30f-bc15c1b34cea@web.de \
--to=markus.elfring@web.de \
--cc=adrian.hunter@intel.com \
--cc=alcooperx@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=florian.fainelli@broadcom.com \
--cc=gregor.herburger@linutronix.de \
--cc=kamal.dasu@broadcom.com \
--cc=kmehltretter@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulfh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).