From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91123C433EF for ; Fri, 8 Oct 2021 06:21:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 54AC960F5B for ; Fri, 8 Oct 2021 06:21:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 54AC960F5B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BrJaihOLlI0J/DT40jvgEniWKn9sYsPGkTYkucIE3DY=; b=pvSxd3WUrowHRJ 9YG0rZ554pn+WEZw8OIaWOOiHhVfJFxS6Sf8QUr50RIxAxodt31AOsXrmnaLGGebTjYe1wqtL4iLt r1BIJ7hIbIcLGkeWO+Ey1xKUVxHIW10eRsJmqzkYBqHUcgQmU8laA2H/d26upBCVXDjYdZ7vGYRkk 6IKeAuwCOHp565WQlNYKH3lCh/ms6PZGrVBC9nDHczXsZuy1TWfTJA2mh6mWmRfdVJzl/tUjfKgNo VngLK/i6EoKeTE84yTrOlhMRBINwE8HXB3o4c0+p82eGBHhf5JYkhhk26QxEoA/JYdZcyeI18ADpQ HHLRVl0d3of5oqy9dOng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mYjE7-001gsd-G2; Fri, 08 Oct 2021 06:19:27 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mYjE3-001grt-OG; Fri, 08 Oct 2021 06:19:25 +0000 X-UUID: 19b36eece01c46aa8b97011949810c77-20211007 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=DXaYlcXovTi8AVzeCqHB6o3jCTRK2bXcD3iWckAtv/E=; b=FFXNRkuW2sVUU64o/3ccYTYeEgQVly/HNW/PlfPmgPDAi51jX3BxSGIhLiwCJx9oaHf5/zQDS5I/OqbUbK1DcoSjHGiSwPcNssnVm9u4RrP4JEZL7fdKHlKgg9xeSxI8TwLdye5x+Lfo1gYZadb2yFuIeQxMfZJ7ZQHcVYyciCI=; X-UUID: 19b36eece01c46aa8b97011949810c77-20211007 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 2068906278; Thu, 07 Oct 2021 23:19:18 -0700 Received: from mtkmbs10n1.mediatek.inc (172.21.101.34) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 7 Oct 2021 23:19:16 -0700 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.15; Fri, 8 Oct 2021 14:19:15 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 8 Oct 2021 14:19:14 +0800 Message-ID: <72d26b0622538bdfda4e64519d34088e8c21656a.camel@mediatek.com> Subject: Re: [PATCH v7 2/7] i2c: mediatek: Reset the handshake signal between i2c and dma From: Kewei Xu To: Wolfram Sang CC: , , , , , , , , , , , , , Date: Fri, 8 Oct 2021 14:19:17 +0800 In-Reply-To: References: <20210917101416.20760-1-kewei.xu@mediatek.com> <20210917101416.20760-3-kewei.xu@mediatek.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211007_231923_836725_ED49D997 X-CRM114-Status: GOOD ( 11.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, 2021-10-02 at 08:30 +0200, Wolfram Sang wrote: > > +#define I2C_CLR_DEBUGCTR 0x0000 > > Hmm, I don't think that a macro to clear a register helps > readability... > > > + mtk_i2c_writew(i2c, I2C_CLR_DEBUGCTR, > > OFFSET_DEBUGCTRL); > > .. > > + mtk_i2c_writew(i2c, 0, OFFSET_DEBUGCTRL); > > looks good to me. Anyhow, it is not a big issue. Let me know if you > want > to change it or keep it. > OK, I will use 0x00 instead of macro on V8 version,Thanks. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel