From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B6BA6C74A5B for ; Tue, 21 Mar 2023 03:55:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zKjvuXO5Km0kx6OBNGYwBWVyu+iRV4f3FLbfWj/gEa4=; b=UKR1H2bLP/TXnf BhveaVWvMjDZ4CdNd1a4aPj3PoAR4NlSYCQWKmIYWW5dWpadozD6P7FKgdUvf9Uq4WvHK76oMtFid Qmssl7/bUknC06SpgQgCHWquzb3ROomv9wNbfUpwCf69Orj6VAFuuauFO2xSItGlDYTDd0zaUbUOc ow/FSM5kxHyl3GKnp6l6NmDj6jBaIN2Az8/DxpPAS6bhAsvFLw8ihiEnZE0V4KsYKJCrmhvV/pNPB RpHFzzAiAVE92eEkelBX0Sm6396dQbl9QwAZERHTWlSahDccgLskly7xjCA4OjVeaGABvWqU7wsfW 4QBDkmSI2lsvz7o3lz5g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1peT4i-00B8Fp-0R; Tue, 21 Mar 2023 03:54:16 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1peT4e-00B8Ek-1N for linux-arm-kernel@lists.infradead.org; Tue, 21 Mar 2023 03:54:14 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 99695AD7; Mon, 20 Mar 2023 20:54:50 -0700 (PDT) Received: from [10.162.42.6] (unknown [10.162.42.6]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0E8FC3F67D; Mon, 20 Mar 2023 20:54:04 -0700 (PDT) Message-ID: <730417dd-43b6-67f4-922a-97d2ceb298bc@arm.com> Date: Tue, 21 Mar 2023 09:24:02 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] arm64: Support CMDLINE_EXTEND Content-Language: en-US To: Chris Packham , catalin.marinas@arm.com, will@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230320211451.2512800-1-chris.packham@alliedtelesis.co.nz> From: Anshuman Khandual In-Reply-To: <20230320211451.2512800-1-chris.packham@alliedtelesis.co.nz> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230320_205412_531939_09866E55 X-CRM114-Status: GOOD ( 17.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Chris, On 3/21/23 02:44, Chris Packham wrote: > Support extending the bootloader provided command line for arm64 > targets. This support is already present via generic DT/EFI code the > only thing required is for the architecture to make it selectable. Does this config really depend on given platform's active support or it is just matter of selecting this for interested platforms ? Could this config definition be unified in a single place i.e arch/Kconfig and be selected (unconditionally or conditionally) on all subscribing platforms. There seems to be a redundancy in defining the exact same config the same way, on multiple platforms. $git grep "config CMDLINE_EXTEND" arch/arm/Kconfig:config CMDLINE_EXTEND arch/loongarch/Kconfig:config CMDLINE_EXTEND arch/powerpc/Kconfig:config CMDLINE_EXTEND arch/riscv/Kconfig:config CMDLINE_EXTEND arch/sh/Kconfig:config CMDLINE_EXTEND I guess this redundancy should be removed as a pre-requisite, before enabling it on arm64 as proposed here, which in itself seems alright. > > Signed-off-by: Chris Packham > --- > arch/arm64/Kconfig | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index 1023e896d46b..3c837b085f21 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -2228,6 +2228,12 @@ config CMDLINE_FROM_BOOTLOADER > the boot loader doesn't provide any, the default kernel command > string provided in CMDLINE will be used. > > +config CMDLINE_EXTEND > + bool "Extend bootloader kernel arguments" > + help > + The command-line arguments provided by the boot loader will be > + appended to the default kernel command string. > + > config CMDLINE_FORCE > bool "Always use the default kernel command string" > help _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel