From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EA269C46467 for ; Mon, 16 Jan 2023 07:29:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jRIQ8q4varuxJqY1tTnFUruwHz3YxxtErik7erkUPR4=; b=WLUSMtOpojFgi1 Fn6A09t1mFkftk9DkvsH8NjHqw3R/1p4Bg3QiTHBHea1Pu7DcRjx/It7VAmNuyKTHcVSWr81yy+D5 lNZk4RBO4qqYZDxkTcEzEVuefmhct6ojUL61B1XIPtkLl63H1HqJhhOmO1v5K2zqdDAs06ivlBnj6 1idQSAV0ic4gQEri78LD51G1UFmvni51KyQg0L3B46twjvwSwFpvKN0fWw0ujS5G2pohO3/6ownaR m5IxTa6eyUtmlHkh2f20dkZokfDP0kt2GNl7J94eDP32jaH7mMHT4otXftJhge/MyoShhKhYQGakz qgXsnmCH6L4ASX5yYFRQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pHJv7-008yMx-Nu; Mon, 16 Jan 2023 07:28:41 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pHJv5-008yLx-1K; Mon, 16 Jan 2023 07:28:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=MIME-Version:Content-Transfer-Encoding :Content-ID:Content-Type:In-Reply-To:References:Message-ID:Date:Subject:CC:To :From:Sender:Reply-To:Content-Description; bh=iVSb7qI+h0DXVUDVDn5DzJtzTzwM3+bWYDGf7hqo/AQ=; b=SIA+xVWk8/oh3F06GaxavuNkjx NxDAd2EycuLt4XQLk+w/zmJgCsEKKoyQc3I2YIel6Ju03cU0GQp4ZjgAjhPJ0DNJf4EbXeGR+6qsI NFBVj2eNCVNKIyNtjLZe98hLM7gMkuDmxwVyTwZmIf9WUR/9q1lbjAzA68mLFpmkPgdualPMQM4kx KcrFvciRlTkYNOoXinJiyf6KW01FXT03GOAWPkZLSpQm4vVy6nEuI48a49jc3/nckqmXIdHqvP1bL 8ljO7eyPU4r/fIo1SX3XFvIkBVKXeug+5meaovxII5arYGx0lpMuzGo5ypNLpRv0809SnXjoLpSpq Z9oRbUFw==; Received: from mailgw01.mediatek.com ([216.200.240.184]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pHJun-005W0f-0e; Mon, 16 Jan 2023 07:28:27 +0000 X-UUID: 43f1ffa4956f11edbbe3f76fe852e059-20230116 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=MIME-Version:Content-Transfer-Encoding:Content-ID:Content-Type:In-Reply-To:References:Message-ID:Date:Subject:CC:To:From; bh=iVSb7qI+h0DXVUDVDn5DzJtzTzwM3+bWYDGf7hqo/AQ=; b=YY/xXDNCFZGShZmgA7vEV8fvGRbzPUYqaFWGpSq18MW5o7BYnwGs6lev5JufVa34nu+f+VANrKC6IAKLpNZ4F3r3s1Ol2ONdv6JLWYCQ8tmbVjJZxnbsDurY+qj7INxIZZVajCZWfcbJdpXm/qixzw9vg6g6aS/3fNOMS8rCnEg=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.17,REQID:05abd7f4-223f-4e4e-91a9-ac036438f8d9,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:-5,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:-5 X-CID-INFO: VERSION:1.1.17,REQID:05abd7f4-223f-4e4e-91a9-ac036438f8d9,IP:0,URL :0,TC:0,Content:0,EDM:0,RT:0,SF:-5,FILE:0,BULK:0,RULE:Release_Ham,ACTION:r elease,TS:-5 X-CID-META: VersionHash:543e81c,CLOUDID:b30becf5-ff42-4fb0-b929-626456a83c14,B ulkID:230116152742P6ZX7WML,BulkQuantity:1,Recheck:0,SF:17|19|102,TC:nil,Co ntent:0,EDM:-3,IP:nil,URL:11|1,File:nil,Bulk:40,QS:nil,BEC:nil,COL:0,OSI:0 ,OSA:0 X-CID-APTURL: Status:success,Category:nil,Trust:0,Unknown:0,Malicious:0 X-CID-BVR: 0,NGT X-UUID: 43f1ffa4956f11edbbe3f76fe852e059-20230116 Received: from mtkmbs13n1.mediatek.inc [(172.21.101.193)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1864256987; Mon, 16 Jan 2023 00:27:43 -0700 Received: from mtkmbs10n2.mediatek.inc (172.21.101.183) by mtkmbs11n1.mediatek.inc (172.21.101.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.15; Mon, 16 Jan 2023 15:27:40 +0800 Received: from APC01-PSA-obe.outbound.protection.outlook.com (172.21.101.239) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server id 15.2.792.3 via Frontend Transport; Mon, 16 Jan 2023 15:27:40 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hifzYC0lwK1mSiIaxVreO8oGlHDJ2DlAJGm/UT9w5sd6Sulttf3xMMQpv76bdVWSJE6EIx8BQnu+FXMRXKK3kk6CQqoyrsbiCcEQtTCqbzE2dG/E9LW1mUwX+XaXRQEUqwF/x82SzFyuiBAhdEtdDFDEsvZIBZkmqOZBfuuVFA/Li/uRyqaf5I/ikThTyZbavrTbxPIe3N71Aw8SPr+8Jb3j+/Xb4q7Mb3aTX6i0x0Ee/AqvcQw92XYctHqsX5Rt2ywCHmiOmntU1P7Hrq9oTxN9WbBGf09X20/8Vm2nsiJE84iiAuJMebshURrqP2kUOLvJpdypKbkOsXSTHAmX7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iVSb7qI+h0DXVUDVDn5DzJtzTzwM3+bWYDGf7hqo/AQ=; b=BYChYXW0aKzi1RObRs+kq3XhdwFgKE/fGFRXTkH0Xv8AXwOctoSKXM0TMr85StDp6ydZzfInzFI+oCO7kg5fJK77ue8bVvwZqFVyjIeblAtOkPwFP/SUSmoR7TH7m22Cky6HpC0Y0nLazHL7wHjCCRqo5QVS1p2Lzg2+zG5HfFQGsxny6ITgU8wmjI1at/yTZBcOsoie52gG018ScaW3E8KRpIqASY4ucSV6SG3zpDSHYEUNCZa9CWKAXYYF+xtmTS/gP8mNFNgVKnkDxsrMBaLmpc2PKIDbW+E3UvZDNbsN2TRtoLGecHSeFb+KDoSVsC+6y17uvtEcfdtflOk9lA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mediatek.com; dmarc=pass action=none header.from=mediatek.com; dkim=pass header.d=mediatek.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mediateko365.onmicrosoft.com; s=selector2-mediateko365-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iVSb7qI+h0DXVUDVDn5DzJtzTzwM3+bWYDGf7hqo/AQ=; b=TGVpTGmu8uGmeBMSdbGob2Dh1s+++S9USdsK7qKO3EyKj+M4OeEf3+oa9+/D3LvGk0PV45UUX29J8wtvEI00lXrRb364NPdeaPseztqJQLhgZ9sK3sNaV8VwVsrO7Fljt27Y2kHPMpOH9sp5qYRjNQs3Q8DmSeNz405TyxvDV2A= Received: from KL1PR03MB5062.apcprd03.prod.outlook.com (2603:1096:820:1a::22) by KL1PR0302MB5234.apcprd03.prod.outlook.com (2603:1096:820:49::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.12; Mon, 16 Jan 2023 07:27:38 +0000 Received: from KL1PR03MB5062.apcprd03.prod.outlook.com ([fe80::5e9b:f4cf:8d7f:60d1]) by KL1PR03MB5062.apcprd03.prod.outlook.com ([fe80::5e9b:f4cf:8d7f:60d1%3]) with mapi id 15.20.5986.023; Mon, 16 Jan 2023 07:27:38 +0000 From: =?utf-8?B?Q2h1bmZlbmcgWXVuICjkupHmmKXls7Ap?= To: "vkoul@kernel.org" CC: "llvm@lists.linux.dev" , "linux-mediatek@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "nathan@kernel.org" , "kishon@kernel.org" , =?utf-8?B?RWRkaWUgSHVuZyAo5rSq5q2j6ZGrKQ==?= , "linux-arm-kernel@lists.infradead.org" , "matthias.bgg@gmail.com" , "linux-phy@lists.infradead.org" , "trix@redhat.com" , "angelogioacchino.delregno@collabora.com" , "ndesaulniers@google.com" Subject: Re: [PATCH v6 3/3] phy: mediatek: tphy: add debugfs files Thread-Topic: [PATCH v6 3/3] phy: mediatek: tphy: add debugfs files Thread-Index: AQHZIEA44YFL/mrrbEuqD9Ku1qRfkq6ctaeAgAQB3IA= Date: Mon, 16 Jan 2023 07:27:38 +0000 Message-ID: <731a1382b969269ba0a482b766ac4dfb6fdc115d.camel@mediatek.com> References: <20230104132646.7100-1-chunfeng.yun@mediatek.com> <20230104132646.7100-3-chunfeng.yun@mediatek.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=mediatek.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: KL1PR03MB5062:EE_|KL1PR0302MB5234:EE_ x-ms-office365-filtering-correlation-id: c6abb26b-589c-4d7b-f1b8-08daf7932569 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: hWcRdHPAr8oxvhRf1sIlwnCHvk7WcWXyFrlbvgQR8YguGUFctPA+oJHuXywFxd7bBy/7P51HBAfFu9j6qS6Rjd27eK/ivA0L3tcGhFhhITx9Og7IypdISrafL5OfMQfMr8n/f9iF8oBPEDdHGVcvTe2B04F0FsZE1Qhvozi6lxbjBodQT/QMLtvLaCigLnjUZATJwfcER85nOEOwOwD19yFe3oUbw8Mfkxyr2oy5BRwyE3Cp1LeugicWfyBO6XRQQKjPAnTBL+64jQu6mnmmfvImWAX+xDbrfcjI7nOy/+DooPDlsn3QQRYdLLEAK2ZvtrlvbiXf/rmOkfd1f69Zlh9mjH9C6G6N1OR7MUuGmY2i7K3yh3yqAmXlX6+VlnHs5M2UXTogJdmnRhtINUj1CWd3xlnWfYCBxABSYdaRsZ682p+fQPYgKLNxaV75oxiwagR7mG5KU7N2t+6dPWs6jN1N3/WDHuR+HGeukcOpIcEHSnorYG9v6cr5l84vdYZRZeCC7jdW2Qn3xfqxhVpx90OJcIIctLx4xQI0Rci7tucNfrtk7uSDYY4Yd4XMLxqM7hWXVDvnWTyW0zH/a0HawuEznk8YKayuOkCi0WEYNufMhVFj1TCDANo/Nc6WTodUUAszpi9ATFvEm3JFZUZFdR6jTsrBihQ/xXLtwKQk+hVRHG34c9aNQGXyJrZt8Kkby9foDrGePaTN4rMiEgWazTq/vNJ2HIZVrv35cxvJNlM= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:KL1PR03MB5062.apcprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(396003)(136003)(366004)(376002)(451199015)(8936002)(76116006)(86362001)(66446008)(6916009)(64756008)(66476007)(66946007)(83380400001)(8676002)(4326008)(38070700005)(122000001)(36756003)(38100700002)(85182001)(6486002)(5660300002)(478600001)(66556008)(7416002)(41300700001)(2906002)(54906003)(6512007)(6506007)(53546011)(26005)(186003)(71200400001)(316002)(2616005)(99106002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ZVNNWk5SaXI4OTBaNGpBUHZsa0xFN3htUW16Y1VycVFzaGhLSkFFQm1wdG9D?= =?utf-8?B?YnlYeThIaEhldDJPd0xpaGErSnRYMTNJVnFiQmxmZ3ZmaFU2WmhiSDVMdERS?= =?utf-8?B?T01hVDJ4b3Uvblp3eTl6V0Era2l0aVB0VDcvUUIzODBHTzhxT1NzZlFXNDZm?= =?utf-8?B?QkxRb0RUTmo1NlpQWXdGUm9DQXVBUG5OWTk4VTdMK280VjV4aUpBYmdZQi91?= =?utf-8?B?NU4xbXJWelcvdmFBZ0FWdkg2aGtHa2FqNzhRc0JxSXFwSm9FY3pXOGVTTEtO?= =?utf-8?B?aXpQVFB1NGdvaW9rQS9YaEFiUmlOdkhtUC9pUUdtWG1raTFhOW1oWktkSnFw?= =?utf-8?B?UytOQ29yQnlPbWhPVGgrcTJDY0gzSjJMZ2E0eUQ1c2RsRk9wdE9IMExYK0E5?= =?utf-8?B?QzhiY1YwUkkxeTEweTJUU3I1N2dacHBmOFByM3RYSFBQNWJFYjZuZTQxMnF0?= =?utf-8?B?WTNhclk4TERiR1lndldJK2ovTHl6aktTZ21ubVMweSszS2RmcTBwY2ZndExB?= =?utf-8?B?Tjc5VEVOM3daNE1ad3BIVm55RGlZTHN4VGdWVkloZ1NjM0dLME5ET1YyOERN?= =?utf-8?B?RkI2STdkYUVqSGZXeWMvc1RscVcyK3BseVBSMEticlAzV1RTVnR0LzN3VDZm?= =?utf-8?B?b0pKSTdxWU5sOUsxdEk3eVBlT2hZR3UvZWZnOEVDZnA1UW5QYXJWc09ab0xh?= =?utf-8?B?Z1Ixc2tlWlNVRnNkZ0owRlVJdnEyUjNpc21hdGRzUmduNzRuVXcxa1F0UmNX?= =?utf-8?B?aGVwczEwL0hCZkowSzRQR3FjVnNOR2lpUk9ZMUd0WnhKb2tLNGRuNWFYSkRy?= =?utf-8?B?M0hveTRrZ2k3T0c0RmQ2WnF0NzV1aUozNlZvb09hSnlIZ29Jbkl5ZXpncXFP?= =?utf-8?B?eWtOYkQzYkh3eWlFWC9MUTFwcWNpcWdoMFo5R3JYS1RKU2FCMWwzR3E2eTlR?= =?utf-8?B?dVB3ekxwUy9pLzlndEU2SGZOZytxM1FzanYwSkxXbVZUa0t0MWw0dXRLYTdF?= =?utf-8?B?Zjd2T3ZRRk5NNFljQ2lRUmo1ZjRhaWZJRlNhSXd2R2svb3hxVmwxcWdqczBm?= =?utf-8?B?V1Q3aUdtY1hZK1N3YndwUzdBZ1N6RTRvb05DZk5mQ011WGphUXZza3JZTWUy?= =?utf-8?B?OEU4WEt5bFN3QU9nb0VoQzhXS1N5cjRyOXRPYlkrQ2Ezd01uNDBSVENVSlNZ?= =?utf-8?B?Ry95c2dEY1VOTkxTa3N2NEh3K1FPNFBzM0dMVkRRbVdmdUdCVGl1U0VvK0Ni?= =?utf-8?B?T0dkWmNLZFRId2pQa1F3ejBGZHFwbmplY01hWitEbFJqRVZWSVFxL2FraW1l?= =?utf-8?B?UEZmMitRTTdUOWFWcGpWWlJOZ3NxTVBaY25CK2h2TWpIY0J0WXNsS3pLbnIx?= =?utf-8?B?U0E3b1VVeWR3aW5qRCtubm9kRytVQ0VKdmVmY1BnWFJtc091SWErUlBYZ0xk?= =?utf-8?B?YTdrNWxtZnAxditmcFd6eFV4L3RUMUtoelVPaHl6TXQrNGdINUs1SGtrN2Jp?= =?utf-8?B?Mm1VOXk3RzRtYnd3a0J1RDljTXFFSWRDUFpWUlVyTmhoM1dWaDdDTFhtcjNY?= =?utf-8?B?R2Q1eHpWUFdObG51TUszbEZ3czRwc0crY2RLQitUZnpkd0wwa0FNbjdWNVpL?= =?utf-8?B?V2w1UDlCM0k1dzNycEFsM2dlM0x5b1hSYVk2YnZYcVJoWEI5L2dQa1daelZx?= =?utf-8?B?Zkp3Z1pXTDQ0QTlkSjBIRmptMTViU3J6NlVYek0rdHQ5aVMycUlmQjVkalZ2?= =?utf-8?B?Y2h1S28xdGZzR0NtamoxZDdwWldKTDVVTTJ0UzVWTGhvcFVwYXRreXlnblhH?= =?utf-8?B?Yk9Qdnp2cHY4Q0t6MmZUMWFCS09KRVd3NVA1eUp2N2RWYXRubEk5YlE1R0FV?= =?utf-8?B?ZXdNWWt4VDROMjJPTnh3cjJzbzQybzYyemh1WXg1QU5udjFaZ2VSYWZ2VmRL?= =?utf-8?B?UHMzNDZYUkxWbU1QbldTODllbCsyNnF1L0F5TXp5NEhyUUcwVTBDU2poQ2RX?= =?utf-8?B?VWpKSEFDZmIweU0rTEs5LzRYWmw3bkxQdWQ0bzlsUm1Ta2hvY00yY0FjYlRt?= =?utf-8?B?bWJqdmk4UVFHL3BIeC95T1R5NnAxMGVVSHM2ODM1anRaSFhsaU5TMmF0Tk9h?= =?utf-8?B?MVlGQzQrTGxqWFZiSE8ydGh2cDNhNTBGZkJQQjhaUjJqNVc0eTRxRzlIUWMz?= =?utf-8?B?VkE9PQ==?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: KL1PR03MB5062.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c6abb26b-589c-4d7b-f1b8-08daf7932569 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jan 2023 07:27:38.5987 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a7687ede-7a6b-4ef6-bace-642f677fbe31 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: TdMZrCSe7OgaIXb1qTJMad1vaYqahq4J/gtP063soPdA90sy3dJTp+JBNaqE828LFIxhphTIdqwmr/dThKLnpKei9+isM3uCjT9ACFIviaw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0302MB5234 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230116_072823_024866_93747548 X-CRM114-Status: GOOD ( 22.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 2023-01-13 at 23:45 +0530, Vinod Koul wrote: > On 04-01-23, 21:26, Chunfeng Yun wrote: > > These debugfs files are mainly used to make eye diagram test > > easier, > > especially helpful to do HQA test for a new IC without efuse > > enabled. > > > > Signed-off-by: Chunfeng Yun > > --- > > v6: no changes > > > > v5: using common debugfs config CONFIG_DEBUG_FS > > > > v4: fix build warning of sometimes uninitialized variable > > > > v3: fix typo of "debugfs" suggested by AngeloGioacchino > > > > v2: add CONFIG_PHY_MTK_TPHY_DEBUGFS suggested by AngeloGioacchino > > --- > > drivers/phy/mediatek/phy-mtk-tphy.c | 405 > > +++++++++++++++++++++++++++- > > 1 file changed, 404 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/phy/mediatek/phy-mtk-tphy.c > > b/drivers/phy/mediatek/phy-mtk-tphy.c > > index e906a82791bd..923e5ee119f3 100644 > > --- a/drivers/phy/mediatek/phy-mtk-tphy.c > > +++ b/drivers/phy/mediatek/phy-mtk-tphy.c > > @@ -7,6 +7,7 @@ > > > > #include > > #include > > +#include > > #include > > #include > > #include > > @@ -264,6 +265,8 @@ > > > > #define TPHY_CLKS_CNT 2 > > > > +#define USER_BUF_LEN(count) min_t(size_t, 8, (count)) > > + > > enum mtk_phy_version { > > MTK_PHY_V1 = 1, > > MTK_PHY_V2, > > @@ -310,6 +313,7 @@ struct mtk_phy_instance { > > struct clk_bulk_data clks[TPHY_CLKS_CNT]; > > u32 index; > > u32 type; > > + struct dentry *dbgfs; > > struct regmap *type_sw; > > u32 type_sw_reg; > > u32 type_sw_index; > > @@ -332,10 +336,391 @@ struct mtk_tphy { > > const struct mtk_phy_pdata *pdata; > > struct mtk_phy_instance **phys; > > int nphys; > > + struct dentry *dbgfs_root; > > int src_ref_clk; /* MHZ, reference clock for slew rate > > calibrate */ > > int src_coef; /* coefficient for slew rate calibrate */ > > }; > > > > +#if IS_ENABLED(CONFIG_DEBUG_FS) > > + > > > > > > > > + > > +DEFINE_SHOW_ATTRIBUTE(tphy_type); > > + > > +static void tphy_debugfs_init(struct mtk_tphy *tphy, struct > > mtk_phy_instance *inst) > > +{ > > + char name[16]; > > + > > + snprintf(name, sizeof(name) - 1, "phy.%d", inst->index); > > I wouold suggest driver name/ device name rather than phy.foo... > again > folks needs to see what is foo Ok, I'll change it, thanks a lot > > > > > > static struct platform_driver mtk_tphy_driver = { > > .probe = mtk_tphy_probe, > > + .remove = mtk_tphy_remove, > > .driver = { > > .name = "mtk-tphy", > > .of_match_table = mtk_tphy_id_table, > > -- > > 2.18.0 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel