From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1430C433DF for ; Wed, 15 Jul 2020 12:27:00 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6F435206E9 for ; Wed, 15 Jul 2020 12:27:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="w38SNl+5"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="QsHwvGAQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6F435206E9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ed/igzFfw63QLMBQx6FUOgjKpE0bG6UsLBoWhKu/Byc=; b=w38SNl+50bgakzeXr+FOpBA/k YeD0BiuyWWXYWFfFhOl+LEaPjeJP1KP6ZygDZOS8t5gzaTEmcxoIhs4/Fn2YR/EZ5MbYufw8i7c8E EoeooCPyALtS8gBRZN9g/MqXO9RdFQxBYB1CSRQDewn32K8YkjNxS1jOM9XKyPAWx3WV/8Kfck0rN x8OKTazgD+9w/bzTEGw3j647JerFG8NpPYs8r54SXrOU1fk95zgy2ZZcRPARjX6bl1Q9aDwrDiwxw nLeVabX7X3+3Z7Y3EiINChTTgMs321JTrEVoIAXZdax01pV1i2H3GMSM1gUlIbsvCdCl5afsl+kiX 6W7JtsVZg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvgTd-0000JN-I7; Wed, 15 Jul 2020 12:25:33 +0000 Received: from mail-qk1-x741.google.com ([2607:f8b0:4864:20::741]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvgTZ-0000Ia-HT for linux-arm-kernel@lists.infradead.org; Wed, 15 Jul 2020 12:25:30 +0000 Received: by mail-qk1-x741.google.com with SMTP id j80so1558021qke.0 for ; Wed, 15 Jul 2020 05:25:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=1t5PpqIFdfAWd4oZlO+yYBTawsdjI8qtrGubmuzcckY=; b=QsHwvGAQvvYePfxwpekvAIAgKDjSdz93PleTHI8xKqrdSjUMOBl0tIBvTCYpfp3lwM jJtuUtvaue4d6PH9RilwWuhsYswSLIgRY4Sq71F0GPFnWqn1Kt8XHJNgzE42Jrg/5wwZ 0ogurReutkKpxZHF62O5X3viWHl//Ct/Cl5I6dLrIYdwasc7YY9ewEC5PTkaMT4oaziH xnc80xkxDWbyZskDblLDn39CxvzczFXhCty3xRVfi3APWW+NCGi/sy7KqZiTPgbnFyDr MaqxZVifV8HuoHVdbz6SVGo5fz8nN7lNWwPCwJBNPTYnz1pTNhKDieXhx2fqUXnMCfD7 DgBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1t5PpqIFdfAWd4oZlO+yYBTawsdjI8qtrGubmuzcckY=; b=VZgKJ1hHHbr/2D5S3iwo+IOfzNgMtAmSq+6jr5Kri3L9sMdayOQzR61d/agy/l7RTi 7zJBioUkNfGpttZSOGMnUsfpTUoS+lXW7zaGqGNZgy6gcVbJbL75DZ3PHi4Y2VGdu67q KJ+/YnFhx1nLdWRCcuPr/LLB3KDT5O3FOsCpmPWiOGUt/j2fDWpmbyY4S/CL6jSwVZDG NPMn7epzXm4UurJjteXWJB8C3dwwfQadkxu8AXT6WTosKNGYCc5Huh72c2ld7XrVGMBU nTpz5uWo9yZAUHz8cOk6gGAdLLAlk0Wra4Dr2E7VEphvA+VQVOPpAOv46YCr7MVFiQLf Nvwg== X-Gm-Message-State: AOAM531TH0yzlhQmHinzpigTMA0FnBQGIuICATJBgKnn/EzMfxD2Aaq8 jHQkqk4zK/qr0lV9ryeL4WXEQg== X-Google-Smtp-Source: ABdhPJyF5jmh8D8P+ViaIdcIViIx03LF/jMe+Ph/xML2TkRKhxGC6gcCp0r4nAjvQ4mdnab1VRmdeQ== X-Received: by 2002:a05:620a:571:: with SMTP id p17mr9625958qkp.482.1594815926144; Wed, 15 Jul 2020 05:25:26 -0700 (PDT) Received: from ?IPv6:2804:7f0:8283:82c3:c4cb:8acd:5887:d86f? ([2804:7f0:8283:82c3:c4cb:8acd:5887:d86f]) by smtp.gmail.com with ESMTPSA id p36sm2857669qte.90.2020.07.15.05.25.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Jul 2020 05:25:25 -0700 (PDT) Subject: Re: [PATCH v3 0/7] arm64: Fix single-step handling and syscall tracing To: Will Deacon , linux-arm-kernel@lists.infradead.org References: <20200710130702.30658-1-will@kernel.org> From: Luis Machado Message-ID: <731c996f-999a-3771-c693-6edace219e68@linaro.org> Date: Wed, 15 Jul 2020 09:25:21 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200710130702.30658-1-will@kernel.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200715_082529_718016_4622FCBD X-CRM114-Status: GOOD ( 24.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , catalin.marinas@arm.com, Keno Fischer , kernel-team@android.com, Kees Cook Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Will, This looks good from GDB's side based on the testsuite results. Thanks for fixing it. Regards, Luis On 7/10/20 10:06 AM, Will Deacon wrote: > Hi folks, > > This is version three of the patches I previous posted here: > > v1: https://lore.kernel.org/r/20200603151033.11512-1-will@kernel.org > v2: https://lore.kernel.org/r/20200702212618.17800-1-will@kernel.org > > This version includes some changes I've been hacking on in relation to > syscall entry/exit, as it seemed worth lumping all this together. I've > also reordered the series to put the fixes at the start. > > Luis -- did you manage to test v2? I'd quite like to queue some of this > soon. If you don't have time, how can I run the GDB testsuite myself? I > tried doing it a _long_ time ago but I remember there being a lot of > failures and flakey tests, so it wasn't very helpful. I have arm64 > hardware running Debian so it's just a question of which buttons to > press :) > > Cheers, > > Will > > Cc: > Cc: Mark Rutland > Cc: Luis Machado > Cc: Keno Fischer > Cc: Kees Cook > > --->8 > > Will Deacon (7): > arm64: ptrace: Consistently use pseudo-singlestep exceptions > arm64: ptrace: Override SPSR.SS when single-stepping is enabled > arm64: compat: Ensure upper 32 bits of x0 are zero on syscall return > arm64: ptrace: Add a comment describing our syscall entry/exit trap > ABI > arm64: syscall: Expand the comment about ptrace and syscall(-1) > arm64: ptrace: Use NO_SYSCALL instead of -1 in syscall_trace_enter() > arm64: Use test_tsk_thread_flag() for checking TIF_SINGLESTEP > > arch/arm64/include/asm/debug-monitors.h | 2 + > arch/arm64/include/asm/syscall.h | 12 +++++- > arch/arm64/include/asm/thread_info.h | 1 + > arch/arm64/kernel/debug-monitors.c | 24 +++++++++--- > arch/arm64/kernel/ptrace.c | 49 +++++++++++++++++++------ > arch/arm64/kernel/signal.c | 11 +----- > arch/arm64/kernel/syscall.c | 21 ++++++++++- > 7 files changed, 90 insertions(+), 30 deletions(-) > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel