From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 128EDC0015E for ; Tue, 15 Aug 2023 22:05:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7/4cHrt4IFqtpHS0QTSZ5DE6iF1436l0G00ZX2/Rx0c=; b=WE+OPp7Mt1Kjtz IZCX1R2+6aDcb8KJm5AKluS0EFXNQaYhwDK/e/oaAwpycyUgqe8ih8dFOCYJkxMMYGfIGKzuwImkw jmolYAcxmapBEi0V3GlLsAv/X6g4T7GqK3o8iLAt4GdNd/y1RnBzdoHvHjasFle1hEgBb8Ev1axrC eG6d9KCGU38+hjjibTbF60rT0Bjztqrz1WhswBurJEK6dVtVl5SLrpF4DYO8NvFOYrwxhAYCUoGPd DePnHEIBTRoVdUL33LmKvsOcVFn521XLDG9Wl83J7JUP7fMV3O15acwtrU4bQ9cHLGAsCdUe8BeLw oW4SZ9HRQA7urGh0L1nw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qW29b-002fiQ-21; Tue, 15 Aug 2023 22:04:43 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qW29Z-002fhz-36 for linux-arm-kernel@bombadil.infradead.org; Tue, 15 Aug 2023 22:04:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID: Sender:Reply-To:Content-ID:Content-Description; bh=ZEHRtmD5N4HTql+UiCFlYekUgyF4BWm0VvzhV82SRN0=; b=GtfsEExn8bpGvShHM7NsHJeXFN kcXMGUh288eN5NCTtjiLuXTbpf8OSNIQOWmeRChBJhXNobUNcAM/vIgU29jrC9U9oRE04WUK0gy7y iBMiVEMCacf+acdmIiTwT7I9lAjQBLLSA17cClyFekGhkaNQfxHVM9cMMGDI5PcA2G81y5I24lkUD F8zL/VdsPuoTPJFuYyTlR3itdK9UfO0iF/QZaz367mDRvHupinzStu9MnClu5+XI4jV+S4mdWH/A5 jvFBZlDlGYf5Ozt0zJC1XfFqhQGvheUI8mMuyQT6tXYL+qElIc0htgjLcIX7eZFF2YYnP/aWmjY1n pf6BN7yA==; Received: from linux.microsoft.com ([13.77.154.182]) by desiato.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qW29V-00C8Zj-2L for linux-arm-kernel@lists.infradead.org; Tue, 15 Aug 2023 22:04:40 +0000 Received: from [192.168.0.5] (71-212-112-68.tukw.qwest.net [71.212.112.68]) by linux.microsoft.com (Postfix) with ESMTPSA id D3EF6211F5F2; Tue, 15 Aug 2023 15:04:32 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com D3EF6211F5F2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1692137073; bh=ZEHRtmD5N4HTql+UiCFlYekUgyF4BWm0VvzhV82SRN0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=SFIuoHSLj1VV/9AYugSnRc/MkZdJpJh3pKm9QzPJZ9Y82LTeDtKNBvwgEiCBS5xpl 6ErqlGWT4kVlijHahPaLgxGzURL6e5jVy9cXzqpWDYhdbSXSWuEzhYMlkM+xddANhT MpTaZ49LM8nABke03H4jvxc7AajZtfMckpA/8D70= Message-ID: <73250561-fb75-47bd-a41d-0dc3d8dc9ddf@linux.microsoft.com> Date: Tue, 15 Aug 2023 15:04:32 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 05/15] hyperv: Move hv_connection_id to hyperv-tlfs Content-Language: en-US To: Wei Liu Cc: linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, mikelley@microsoft.com, kys@microsoft.com, haiyangz@microsoft.com, decui@microsoft.com, ssengar@linux.microsoft.com, mukeshrathor@microsoft.com, stanislav.kinsburskiy@gmail.com, jinankjain@linux.microsoft.com, apais@linux.microsoft.com, Tianyu.Lan@microsoft.com, vkuznets@redhat.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, will@kernel.org, catalin.marinas@arm.com References: <1690487690-2428-1-git-send-email-nunodasneves@linux.microsoft.com> <1690487690-2428-6-git-send-email-nunodasneves@linux.microsoft.com> From: Nuno Das Neves In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230815_230438_133488_BA23A7DC X-CRM114-Status: GOOD ( 15.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/2/2023 4:55 PM, Wei Liu wrote: > On Thu, Jul 27, 2023 at 12:54:40PM -0700, Nuno Das Neves wrote: >> This structure should be in hyperv-tlfs.h anyway, since it is part of >> the TLFS document. > > Missing blank line here. > Thanks, will fix. >> The definition conflicts with one added in hvgdk.h as part of the mshv >> driver so must be moved to hyperv-tlfs.h. >> >> Signed-off-by: Nuno Das Neves >> --- >> include/asm-generic/hyperv-tlfs.h | 9 +++++++++ >> include/linux/hyperv.h | 9 --------- >> 2 files changed, 9 insertions(+), 9 deletions(-) >> >> diff --git a/include/asm-generic/hyperv-tlfs.h b/include/asm-generic/hyperv-tlfs.h >> index 373f26efa18a..8fc5e5a9d7cb 100644 >> --- a/include/asm-generic/hyperv-tlfs.h >> +++ b/include/asm-generic/hyperv-tlfs.h >> @@ -845,4 +845,13 @@ struct hv_mmio_write_input { >> u8 data[HV_HYPERCALL_MMIO_MAX_DATA_LENGTH]; >> } __packed; >> >> +/* Define connection identifier type. */ >> +union hv_connection_id { >> + u32 asu32; >> + struct { >> + u32 id:24; >> + u32 reserved:8; >> + } u; >> +}; >> + > > Missing __packed here, but since this is already aligned it probably > doesn't matter much. > Yes, it should be fine without __packed. >> #endif >> diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h >> index bfbc37ce223b..f90de5abcd50 100644 >> --- a/include/linux/hyperv.h >> +++ b/include/linux/hyperv.h >> @@ -748,15 +748,6 @@ struct vmbus_close_msg { >> struct vmbus_channel_close_channel msg; >> }; >> >> -/* Define connection identifier type. */ >> -union hv_connection_id { >> - u32 asu32; >> - struct { >> - u32 id:24; >> - u32 reserved:8; >> - } u; >> -}; >> - >> enum vmbus_device_type { >> HV_IDE = 0, >> HV_SCSI, >> -- >> 2.25.1 >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel