Re: [PATCH 1/2] drm/mediatek/hdmi: Use syscon_regmap_lookup_by_phandle_args

Krzysztof Kozlowski
2025-01-13T13:07:19Z

On 13/01/2025 13:41, AngeloGioacchino Del Regno wrote:
> Il 12/01/25 14:47, Krzysztof Kozlowski ha scritto:
>> Use syscon_regmap_lookup_by_phandle_args() which is a wrapper over
>> syscon_regmap_lookup_by_phandle() combined with getting the syscon
>> argument. Except simpler code this annotates within one line that given
>> phandle has arguments, so grepping for code would be easier.
>>
>> There is also no real benefit in printing errors on missing syscon
>> argument, because this is done just too late: runtime check on
>> static/build-time data. Dtschema and Devicetree bindings offer the
>> static/build-time check for this already.
>>
>
> I agree with this change but can you please rebase it over [1]?
>
> The same code got migrated to mtk_hdmi_common.c instead :-)
>
> [1]:
> https://lore.kernel.org/r/20250108112744.64686-1-angelogioacchino.delregno@collabora.com
My is 2-patch cleanup, your is 34 patch rework and new features with
existing build reports, so rebase is not reasonable. It would make this
2-patch cleanup wait for many cycles.

Best regards,
Krzysztof