Re: [PATCH] arm: kprobes: add missing MODULE_DESCRIPTION() macro

Jeff Johnson
2024-07-19T14:03:59Z

On 7/19/2024 4:28 AM, Arnd Bergmann wrote:
> On Tue, Jul 9, 2024, at 21:53, Jeff Johnson wrote:
>> On 6/22/2024 9:34 PM, Jeff Johnson wrote:
>>> With ARCH=arm, make allmodconfig && make W=1 C=1 reports:
>>> WARNING: modpost: missing MODULE_DESCRIPTION() in arch/arm/probes/kprobes/test-kprobes.o
>>>
>>> Add the missing invocation of the MODULE_DESCRIPTION() macro.
>>>
>>> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
>>> ---
>>> arch/arm/probes/kprobes/test-core.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/arch/arm/probes/kprobes/test-core.c b/arch/arm/probes/kprobes/test-core.c
>>> index 171c7076b89f..6e9041a76b8b 100644
>>> --- a/arch/arm/probes/kprobes/test-core.c
>>> +++ b/arch/arm/probes/kprobes/test-core.c
>>> @@ -1664,6 +1664,7 @@ static void __exit kprobe_test_exit(void)
>>>
>>> module_init(run_all_tests)
>>> module_exit(kprobe_test_exit)
>>> +MODULE_DESCRIPTION("ARM kprobes test module");
>>> MODULE_LICENSE("GPL");
>>>
>>> #else /* !MODULE */
>>>
>>> ---
>>> base-commit: 563a50672d8a86ec4b114a4a2f44d6e7ff855f5b
>>> change-id: 20240622-md-arm-arch-arm-probes-kprobes-34037098a2c3
>>
>> I don't see this in linux-next yet so following up to see if anything else is
>> needed to get this merged.
>
> Hi Jeff,
>
> The arm tree uses a separate submission system for reviewed
> patches to get into the tree, see
>
> https://www.arm.linux.org.uk/developer/patches/info.php
> https://www.arm.linux.org.uk/developer/patches/section.php?section=0

Thanks for the pointer. Hard to keep track of these when submitting tree-wide!

> I looked at this file as well during build testing
> and ended up combining the change with a cleanup,
> If you like, I can send my version instead, see below.

Please send your version since it has additional cleanup.

/jeff