From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 83660CD4F21 for ; Thu, 14 May 2026 01:27:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PD4vmUsyi450CgjFvjHafW4NPixqyJDZ6LAHzwCiTdI=; b=3PakSxZZmfAGmHmjQ2V9tBn9GA zT/vC7obalZg2lEJEgsDQpD+FBvgbRUE2TPdKlv88I6vMSNTcUy5VVVsdWZuyZfjCdVsi4it3tXqQ g5wGcQM2wqpeEqqr/1J/qH3kUZcHa3NS157LBiJxmhA7FLmTgYAQRgW1vPsx3strNh7kRgu7Cwb0+ 1AXP8bMkI/7CVswwGyHeamEtrBOjJbXrDTIrV8aqruxSGAKy0Pp9l/p3P3dYYTj3B5Pc6j9W1NWI7 5mjpmQFB8rwhXWTdkRm5c302lFob0OsafvWVcUXsBvjgtakelgElASOy+xSD79a2UV+36N+RRieZ5 bt7nZuEA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wNKre-00000004Ghl-0BKb; Thu, 14 May 2026 01:27:50 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wNKrd-00000004Ghd-1VZT for linux-arm-kernel@lists.infradead.org; Thu, 14 May 2026 01:27:49 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 6225760052; Thu, 14 May 2026 01:27:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 81F48C19425; Thu, 14 May 2026 01:27:44 +0000 (UTC) Message-ID: <734e2323-78dc-43c7-b5fc-0a35cc72e035@linux-m68k.org> Date: Thu, 14 May 2026 11:27:40 +1000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 03/11] m68k: mcf5441x: setup DAC clock name as per driver name To: Angelo Dureghello , Geert Uytterhoeven , Steven King , Arnd Bergmann , Maxime Coquelin , Alexandre Torgue , Jonathan Cameron , David Lechner , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: Greg Ungerer , linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org References: <20260513-wip-stmark2-dac-v2-0-fcdae50cf51a@baylibre.com> <20260513-wip-stmark2-dac-v2-3-fcdae50cf51a@baylibre.com> Content-Language: en-US From: Greg Ungerer In-Reply-To: <20260513-wip-stmark2-dac-v2-3-fcdae50cf51a@baylibre.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Angelo, On 13/5/26 19:14, Angelo Dureghello wrote: > From: Angelo Dureghello > > Later in this patchset, the mcf54415 DAC driver is added. > Considering some other different ColdFire cpu DACs exists, the DAC driver > is named as "mcf54415_dac", related to the mcf5441x family SoCs with > DACs (mcf54415/6/7/8). > > So updating DAC clock names to bind with proper driver name. I am not sure I like naming the clocks here with a prefix for the specific SoC part number this is in. It might be unlikely now, but what if another ColdFire family SoC member uses this same hardware block? That is very common amongst other hardware blocks within the ColdFire family. Can we come up with a name more specific to just this type of DAC hardware block? Regards Greg > Signed-off-by: Angelo Dureghello > --- > arch/m68k/coldfire/m5441x.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/m68k/coldfire/m5441x.c b/arch/m68k/coldfire/m5441x.c > index 5b5e09ecf487..b724d7fc1a08 100644 > --- a/arch/m68k/coldfire/m5441x.c > +++ b/arch/m68k/coldfire/m5441x.c > @@ -43,8 +43,8 @@ DEFINE_CLK(0, "mcfpit.2", 34, MCF_BUSCLK); > DEFINE_CLK(0, "mcfpit.3", 35, MCF_BUSCLK); > DEFINE_CLK(0, "mcfeport.0", 36, MCF_CLK); > DEFINE_CLK(0, "mcfadc.0", 37, MCF_CLK); > -DEFINE_CLK(0, "mcfdac.0", 38, MCF_CLK); > -DEFINE_CLK(0, "mcfdac.1", 39, MCF_CLK); > +DEFINE_CLK(0, "mcf54415_dac.0", 38, MCF_CLK); > +DEFINE_CLK(0, "mcf54415_dac.1", 39, MCF_CLK); > DEFINE_CLK(0, "mcfrtc.0", 42, MCF_CLK); > DEFINE_CLK(0, "mcfsim.0", 43, MCF_CLK); > DEFINE_CLK(0, "mcfusb-otg.0", 44, MCF_CLK); > @@ -106,8 +106,8 @@ static struct clk_lookup m5411x_clk_lookup[] = { > CLKDEV_INIT("mcfpit.3", NULL, &__clk_0_35), > CLKDEV_INIT("mcfeport.0", NULL, &__clk_0_36), > CLKDEV_INIT("mcfadc.0", NULL, &__clk_0_37), > - CLKDEV_INIT("mcfdac.0", NULL, &__clk_0_38), > - CLKDEV_INIT("mcfdac.1", NULL, &__clk_0_39), > + CLKDEV_INIT("mcf54415_dac.0", NULL, &__clk_0_38), > + CLKDEV_INIT("mcf54415_dac.1", NULL, &__clk_0_39), > CLKDEV_INIT("mcfrtc.0", NULL, &__clk_0_42), > CLKDEV_INIT("mcfsim.0", NULL, &__clk_0_43), > CLKDEV_INIT("mcfusb-otg.0", NULL, &__clk_0_44), >