From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A2693C4332F for ; Mon, 25 Apr 2022 15:39:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VZXhMeF1lMiPX/E00xaTE07wCVZMwLkSZenvCC/dFdo=; b=h56OnPJ33UNBiN /8MaCaHLwpgxz2tUhrdDmNhX72wKP4kbfIPvs/tALELX9Gc+Gj4QZ/CxV5pTKLy/hqocsfQzMbJ2f TwgDqaIARPP7MwK2wiUR6+3UlGAl/MWWzlW1LDKbrRuSslh7U8wDH5au6WEcZekFkzhsqMuwn9piP KwkadKMRaFcvMaN6ohj9MKacTNA3puJrfmYNCIwneF25TScTiJhChF4Ouuic5h1maVrFneJag/o/9 YWFUI5BSfLNGLnQJ+gRYrdDKV/oxZDKFfF90nU+pFEzEV+AyqZk/8wRwLyb0eaMm+ZjX36kNDryp5 jHRKbebumRetpf/AGbgQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nj0nX-00A8Do-1T; Mon, 25 Apr 2022 15:38:47 +0000 Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nj0nR-00A8CP-US for linux-arm-kernel@lists.infradead.org; Mon, 25 Apr 2022 15:38:43 +0000 Received: by mail-ed1-x535.google.com with SMTP id g23so11893625edy.13 for ; Mon, 25 Apr 2022 08:38:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lyKb4FdguiCq+rrS9QTQp8nb4hp+SYmLFGLR3Wa4zP0=; b=oR0hgVe+fDdxZD9+CK6avbwwxst9IxTbsMtLq6aW8nl049044HLXTgVi9nHCY+Qc5n GMmxTLe9j6AsomYiIspYq9X9YCBjYb3QrCgO8e75oi5Ip2iR02r/0xDDKIkN8H1V6398 DH6oUE+7acEJ3s3LcKhnf8heFGPMFI6NahiyzttiY/ZuPZH/iQpUsjjgiZ72ISHVHT2z 2KB4ViwjkhWkcWf4b6u6ZOACe4oj+ACgcDAqUtvRFigC8GlOAdb8EKLWIFqsR7uj3FgR CfhJl9XUC0NooRA5BFTahfsDuLxzdbTtqP56TE5L6rOke5C+YgB+2Mi4TOTlVYB2TmN7 BiMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lyKb4FdguiCq+rrS9QTQp8nb4hp+SYmLFGLR3Wa4zP0=; b=7LMMKGuv5BPELK9mpqRJfW7hw8rf483oPpBVmRAl8ExEPCNHrYeC2BilXni6kE7PnC v4OR1c4PQtpH+Lwnx50cZbLWR7ZeD5IEylcD5ZRK3gKxPirmDCO5eD6IAOICFdlE7VrM vr/MPiSrKkZW8pFm+guFN+lEovDcRVc7lSYLYcJvFYFyPhiVXZ+mA6rUw9NAMaFTnSp7 n2sjsDC3n0wsltaW16R1VJGRoGS4IlcBtnrWl0p4zT577suAyexh6FRfjmFyIbThnIKt NxRZ9ntNcuCPMvdpWyp++oJsu76q0u36ZuWvkn3TKuMJaCRHIkb54bfRNPxTOKuXA/Kr ardQ== X-Gm-Message-State: AOAM530nF/M8R2YkIPZtxO83p8+3WMx44b23p20h6CaYvUxG8JPgBNpj TnXRe1e5UFQ8pS+eWlIlQTw= X-Google-Smtp-Source: ABdhPJy7/i2EjP7Cft8S7OWZdF41cMgkZwTrPEfilPCAN8PeG/6lORkVjz6ueYqKFCMOyADTntHYyA== X-Received: by 2002:a05:6402:1e93:b0:424:1b50:688d with SMTP id f19-20020a0564021e9300b004241b50688dmr19810193edf.405.1650901119465; Mon, 25 Apr 2022 08:38:39 -0700 (PDT) Received: from kista.localnet (cpe-86-58-32-107.static.triera.net. [86.58.32.107]) by smtp.gmail.com with ESMTPSA id e22-20020a170906505600b006da7d71f25csm3747575ejk.41.2022.04.25.08.38.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Apr 2022 08:38:39 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Ulf Hansson , linux-mmc@vger.kernel.org, Samuel Holland Cc: Samuel Holland , Andre Przywara , Chen-Yu Tsai , Maxime Ripard , Yangtao Li , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH] mmc: sunxi-mmc: Fix DMA descriptors allocated above 32 bits Date: Mon, 25 Apr 2022 17:38:37 +0200 Message-ID: <7372337.EvYhyI6sBW@kista> In-Reply-To: <20220424231751.32053-1-samuel@sholland.org> References: <20220424231751.32053-1-samuel@sholland.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220425_083842_035049_89C7FA26 X-CRM114-Status: GOOD ( 17.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne ponedeljek, 25. april 2022 ob 01:17:50 CEST je Samuel Holland napisal(a): > Newer variants of the MMC controller support a 34-bit physical address > space by using word addresses instead of byte addresses. However, the > code truncates the DMA descriptor address to 32 bits before applying the > shift. This breaks DMA for descriptors allocated above the 32-bit limit. > > Fixes: 3536b82e5853 ("mmc: sunxi: add support for A100 mmc controller") > Signed-off-by: Samuel Holland Reviewed-by: Jernej Skrabec Best regards, Jernej > --- > > drivers/mmc/host/sunxi-mmc.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/host/sunxi-mmc.c b/drivers/mmc/host/sunxi-mmc.c > index c62afd212692..46f9e2923d86 100644 > --- a/drivers/mmc/host/sunxi-mmc.c > +++ b/drivers/mmc/host/sunxi-mmc.c > @@ -377,8 +377,9 @@ static void sunxi_mmc_init_idma_des(struct sunxi_mmc_host *host, > pdes[i].buf_addr_ptr1 = > cpu_to_le32(sg_dma_address(&data->sg[i]) >> > host->cfg->idma_des_shift); > - pdes[i].buf_addr_ptr2 = cpu_to_le32((u32)next_desc >> > - host- >cfg->idma_des_shift); > + pdes[i].buf_addr_ptr2 = > + cpu_to_le32(next_desc >> > + host->cfg->idma_des_shift); > } > > pdes[0].config |= cpu_to_le32(SDXC_IDMAC_DES0_FD); > -- > 2.35.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel