From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFD05C28CBC for ; Thu, 7 May 2020 03:13:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6FA422068E for ; Thu, 7 May 2020 03:13:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="O2sffXH3"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="a/LVzhYP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6FA422068E Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OeIziclKJ/oJMOdVhVpg7S370xE1GXvRemll43f7D8I=; b=O2sffXH3A7J4Jy XUARjJbgfIj0w1Pg9J/sD+5/ybJxK5MW7R/X7K0kcVusWDZ8IybubByigsb70QT0OeY1h9q6n+ueW 6NnynL0ftclVE+YrwKTr8yLTiy8wUnvbGnHtWxusD4n0iYT/tRF2AWb9OSnEM5D/PIUNXsLz5Z3eC 8K3ig1dBVFMvr/Vhqf9ic8b3pW1s+dQcgpTs3dyu/fW2YU1UGzKVuRYWZT1Kx6S84U7T0D/B1W9oI gbCN/HDWIjedQ/mrbgUJ8m/JTIMMt2VP2YvXN1S2R3Doe2byF/TeUlbqHfpWoigw+269IxeGCK5NZ m9ZwBcegYBu9ZJh0tWHw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWWyM-0006rK-Ne; Thu, 07 May 2020 03:13:18 +0000 Received: from fllv0015.ext.ti.com ([198.47.19.141]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWWyI-0006q4-5e; Thu, 07 May 2020 03:13:16 +0000 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 0473CwVp111905; Wed, 6 May 2020 22:12:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1588821178; bh=pcn5RsTpVgMyrDv8WDPeFMl6cdwdI2B8kCKhic2Xr9g=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=a/LVzhYPf8uuIgW9nGMnK78KLa02MqUh7QPp/VvdE9BKyRt5Pa+J324420treT5W7 EUEwBn7u9uhft7R3nBmRSLGpbzkex1J6iEee9VMY/n4YGwDtrtMLpgbikDTzQ/dlyQ oVlHpfa+37OCL1e7NQ1DjJKg5GUrLaArNGVZ5HB8= Received: from DLEE104.ent.ti.com (dlee104.ent.ti.com [157.170.170.34]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 0473CwJF041499 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 6 May 2020 22:12:58 -0500 Received: from DLEE110.ent.ti.com (157.170.170.21) by DLEE104.ent.ti.com (157.170.170.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Wed, 6 May 2020 22:12:57 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE110.ent.ti.com (157.170.170.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Wed, 6 May 2020 22:12:57 -0500 Received: from [10.250.233.85] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 0473Cpfh015052; Wed, 6 May 2020 22:12:52 -0500 Subject: Re: [PATCH v9 0/8] Add endpoint driver for R-Car PCIe controller To: "Lad, Prabhakar" , Lorenzo Pieralisi References: <1587666159-6035-1-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com> <20200505094416.GA12543@e121166-lin.cambridge.arm.com> From: Kishon Vijay Abraham I Message-ID: <73b446db-9bfa-eb50-96c8-865b9b79c7e4@ti.com> Date: Thu, 7 May 2020 08:42:51 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200506_201314_298542_47D7D5DB X-CRM114-Status: GOOD ( 23.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Heiko Stuebner , Jingoo Han , Yoshihiro Shimoda , linux-pci , LKML , Lad Prabhakar , Linux-Renesas , "open list:ARM/Rockchip SoC..." , Tom Joseph , Rob Herring , Geert Uytterhoeven , Gustavo Pimentel , Bjorn Helgaas , Marek Vasut , Shawn Lin , LAK , Andrew Murray Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Prabhakar, On 5/5/2020 3:17 PM, Lad, Prabhakar wrote: > Hi Lorenzo, > > On Tue, May 5, 2020 at 10:44 AM Lorenzo Pieralisi > wrote: >> >> On Thu, Apr 30, 2020 at 09:43:20AM +0100, Lad, Prabhakar wrote: >>> Hi Kishon, >>> >>> On Thu, Apr 23, 2020 at 7:23 PM Lad Prabhakar >>> wrote: >>>> >>>> Hi All, >>>> >>>> This patch series adds support for endpoint driver for R-Car PCIe controller on >>>> R-Car/RZ-G2x SoC's, this also extends the epf framework to handle multiple windows >>>> supported by the controller for mapping PCI address locally. >>>> >>>> Note: >>>> The cadence/rockchip/designware endpoint drivers are build tested only. >>>> >>>> Changes for v9 (Re-spun this series as there were minimal changes requested): >>>> * Rebased patches on top of v5.7.rc1 >>>> * Replaced mdelay(1) with usleep_range(1000, 1001) in rcar_pcie_ep_assert_intx() >>>> * Added a check for max_functions read from DT to restrict with >>>> RCAR_EPC_MAX_FUNCTIONS >>>> * Replaced MSICAP0_MMENUM with MSICAP0_MMESE >>>> * Retry ioremap for other windows on failure in pci_epc_mem_alloc_addr() >>>> * Fixed looping for number windows in pci_epc_mem_exit() >>>> * Set maximum to 1 for max-functions in DT binding (I have restored the acks >>>> from Rob and Shimoda-san) >>>> * Sorted the entry in MAINTAINERS >>>> >>>> Changes for v8: >>>> * Dropped adding R8A774C0 (0x002d) pci-id in pci_ids.h >>>> * Fixed typo in commit message for patch 2/8 >>>> * Reworded commit message for patch 5/8 as suggested by Bjorn >>>> * Split up patch to add pci_epc_mem_init() interface to add page_size argument >>>> as suggested by Bjorn. >>>> >>>> Changes for v7: >>>> * Fixed review comments pointed by Shimoda-san >>>> 1] Made DT bindings dual licensed, added Shimoda-san as maintainer and fixed >>>> the example as its built with #{address,size}-cells = <1>. I have still >>>> restored the Ack from Rob and Shimoda-san with these changes. >>>> 2] Split up the patches so that they can be picked up by respective subsystem >>>> patches 1/4-9/11 are now part of this series. >>>> 3] Dropped altering a comment in pci-epc.h >>>> 4] Used a local variable align_size in pci_epc_mem_alloc_addr() so that size >>>> variable doesn't get overwritten in the loop. >>>> 5] Replaced i-=1 with i-- >>>> 6] Replaced rcar with R-Car in patch subject and description. >>>> 7] Set MACCTLR in init() callback >>>> >>>> Changes for v6: >>>> 1] Rebased patches on endpoint branch of https://git.kernel.org/pub/ >>>> scm/linux/kernel/git/lpieralisi/pci.git/ >>>> 2] Fixed review comments from Shimoda-san >>>> a] Made sure defconfig changes were in separate patch >>>> b] Created rcar_pcie_host/rcar_pcie_ep structures >>>> c] Added pci-id for R8A774C0 >>>> d] Added entry in MAINTAINERS for dt-binding >>>> e] Dropped unnecessary braces >>>> 3] Added support for msi. >>>> >>>> Changes for v5: >>>> 1] Rebased patches on next branch of https://git.kernel.org/pub/scm/ >>>> linux/kernel/git/helgaas/pci.git >>>> 2] Fixed review comments reported by Kishon while fetching the matching >>>> window in function pci_epc_get_matching_window() >>>> 3] Fixed review comments reported by Bjorn >>>> a] Split patch up first patch so that its easier to review and incremental >>>> b] Fixed typos >>>> 4] Included Reviewed tag from Rob for the dt-binding patch >>>> 5] Fixed issue reported by Nathan for assigning variable to itself >>>> >>>> Changes for v4: >>>> 1] Fixed dtb_check error reported by Rob >>>> 2] Fixed review comments reported by Kishon >>>> a] Dropped pci_epc_find_best_fit_window() >>>> b] Fixed initializing mem ptr in __pci_epc_mem_init() >>>> c] Dropped map_size from pci_epc_mem_window structure >>>> >>>> Changes for v3: >>>> 1] Fixed review comments from Bjorn and Kishon. >>>> 3] Converted to DT schema >>>> >>>> Changes for v2: >>>> 1] Fixed review comments from Biju for dt-bindings to include an example >>>> for a tested platform. >>>> 2] Fixed review comments from Kishon to extend the features of outbound >>>> regions in epf framework. >>>> 3] Added support to parse outbound-ranges in OF. >>>> >>>> Lad Prabhakar (8): >>>> PCI: rcar: Rename pcie-rcar.c to pcie-rcar-host.c >>>> PCI: rcar: Move shareable code to a common file >>>> PCI: rcar: Fix calculating mask for PCIEPAMR register >>>> PCI: endpoint: Pass page size as argument to pci_epc_mem_init() >>>> PCI: endpoint: Add support to handle multiple base for mapping >>>> outbound memory >>> Could you please do the needy for the above two patches, so that this >>> can be picked up by Lorenzo. >> >> Yes please. I would kindly ask you to rebase it on top of my >> pci/rcar branch - with Kishon's ACK when provided. >> > Sure will do that as soon as I get Kishon's Ack. I've given my Acked by on the two endpoint core patches. I've also tested my endpoint series [1] after applying this series. Thanks Kishon [1] -> http://lore.kernel.org/r/20200506151429.12255-1-kishon@ti.com > > Cheers, > --Prabhakar > >> Thanks, >> Lorenzo >> >>> Cheers, >>> --Prabhakar >>> >>>> dt-bindings: PCI: rcar: Add bindings for R-Car PCIe endpoint >>>> controller >>>> PCI: rcar: Add endpoint mode support >>>> MAINTAINERS: Add file patterns for rcar PCI device tree bindings >>>> >>>> .../devicetree/bindings/pci/rcar-pci-ep.yaml | 77 ++ >>>> MAINTAINERS | 1 + >>>> drivers/pci/controller/Kconfig | 18 + >>>> drivers/pci/controller/Makefile | 3 +- >>>> .../pci/controller/cadence/pcie-cadence-ep.c | 2 +- >>>> .../pci/controller/dwc/pcie-designware-ep.c | 16 +- >>>> drivers/pci/controller/pcie-rcar-ep.c | 557 ++++++++ >>>> drivers/pci/controller/pcie-rcar-host.c | 1065 +++++++++++++++ >>>> drivers/pci/controller/pcie-rcar.c | 1206 +---------------- >>>> drivers/pci/controller/pcie-rcar.h | 140 ++ >>>> drivers/pci/controller/pcie-rockchip-ep.c | 2 +- >>>> drivers/pci/endpoint/pci-epc-mem.c | 204 ++- >>>> include/linux/pci-epc.h | 38 +- >>>> 13 files changed, 2078 insertions(+), 1251 deletions(-) >>>> create mode 100644 Documentation/devicetree/bindings/pci/rcar-pci-ep.yaml >>>> create mode 100644 drivers/pci/controller/pcie-rcar-ep.c >>>> create mode 100644 drivers/pci/controller/pcie-rcar-host.c >>>> create mode 100644 drivers/pci/controller/pcie-rcar.h >>>> >>>> -- >>>> 2.17.1 >>>> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel