From: nicolas.ferre@microchip.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] ARM: dts: at91: sama5d2: use sama5d2 compatible string for SMC
Date: Tue, 11 Jul 2017 10:07:00 +0200 [thread overview]
Message-ID: <73c25b77-856b-b4c3-7e53-8f60c72dbc6e@microchip.com> (raw)
In-Reply-To: <20170711075829.5rzdrjgao6efiuj2@rfolt0960.corp.atmel.com>
On 11/07/2017 at 09:58, Ludovic Desroches wrote:
> On Tue, Jul 11, 2017 at 09:52:58AM +0200, Nicolas Ferre wrote:
>> On 11/07/2017 at 09:40, Ludovic Desroches wrote:
>>> A new compatible string has been introduced for sama5d2 SMC to allow to
>>> manage the registers mapping change.
>>>
>>> Signed-off-by: Ludovic Desroches <ludovic.desroches@microchip.com>
>>> ---
>>> arch/arm/boot/dts/sama5d2.dtsi | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi
>>> index 4fcd5bb219e3..60e69aeacbdb 100644
>>> --- a/arch/arm/boot/dts/sama5d2.dtsi
>>> +++ b/arch/arm/boot/dts/sama5d2.dtsi
>>> @@ -1048,7 +1048,7 @@
>>> };
>>>
>>> hsmc: hsmc at f8014000 {
>>> - compatible = "atmel,sama5d3-smc", "syscon", "simple-mfd";
>>> + compatible = "atmel,sama5d2-smc", "syscon", "simple-mfd";
>>
>> You'd better use something like:
>> compatible = "atmel,sama5d2-smc", "atmel,sama5d3-smc", "syscon", "simple-mfd";
>
> But it's not true, during data interface setup, we will write values in
> the wrong place if we fallback on "atmel,sama5d3-smc".
Yes, I wrote too quickly: sorry for the noise ;-)
Bye,
>> So that this patch is independent from the rest of the series and
>> we can avoid to having to synchronize with mfd or mtd/nand for this part.
>>
>> Regards,
>>
>>> reg = <0xf8014000 0x1000>;
>>> interrupts = <17 IRQ_TYPE_LEVEL_HIGH 6>;
>>> clocks = <&hsmc_clk>;
>>>
>>
>>
>> --
>> Nicolas Ferre
>
--
Nicolas Ferre
next prev parent reply other threads:[~2017-07-11 8:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-11 7:40 [PATCH 0/3] Fix SMC layout register for sama5d2 Ludovic Desroches
2017-07-11 7:40 ` [PATCH 1/3] mfd: syscon: update Atmel SMC binding doc Ludovic Desroches
2017-07-14 16:06 ` Rob Herring
2017-07-18 8:10 ` Lee Jones
2017-07-11 7:40 ` [PATCH 2/3] mfd: syscon: atmel-smc: add helper to retrieve register layout Ludovic Desroches
2017-07-11 8:07 ` Boris Brezillon
2017-07-18 8:15 ` Lee Jones
2017-07-18 9:12 ` Lee Jones
2017-07-18 9:23 ` Nicolas Ferre
2017-07-18 9:37 ` Lee Jones
2017-07-18 9:56 ` Ludovic Desroches
2017-07-18 9:24 ` Alexandre Belloni
2017-07-11 7:40 ` [PATCH 3/3] ARM: dts: at91: sama5d2: use sama5d2 compatible string for SMC Ludovic Desroches
2017-07-11 7:52 ` Nicolas Ferre
2017-07-11 7:58 ` Ludovic Desroches
2017-07-11 8:07 ` Nicolas Ferre [this message]
2017-07-11 8:08 ` Ludovic Desroches
2017-07-11 9:25 ` Lee Jones
2017-07-12 13:59 ` Alexandre Belloni
2017-07-13 7:59 ` Lee Jones
2017-07-17 9:17 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73c25b77-856b-b4c3-7e53-8f60c72dbc6e@microchip.com \
--to=nicolas.ferre@microchip.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox