From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 848D3C54FD0 for ; Mon, 27 Apr 2020 17:30:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3DE5020775 for ; Mon, 27 Apr 2020 17:30:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="C0HxH098"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="f7u4o2sK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3DE5020775 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=d2RYIqDGC/wsf0oX5v/RxAeng1Lmuosxi+o8Mg1i64o=; b=C0HxH098vscG2Hbq5sd8sF1FjF Xl+GX0CLF1jp+2lOSWOtTZufxunZP3vXF/iO8nGmvRgVVy3L+B5m88GqcrZdCHualjuzkRx826t61 a70hzdzZlNHXjLiX8EnwjrDvpFM10yfAVVr6PGEKHgT5+NybzHIF4480ZLnrQwehqIerMpeC/vG94 wwElXmwbYzC2B2YwVgc67C8cL7roCxuD8XUKhy9yR6vyeTDk9negl5ur9qVgA6gHxGX1BRuZs1Xrs 2w3dbXRyHnUTPMSi/BLpez2o+zajBIzrRNnHCMXjGHvm4nh8HYCabsWRKfptkhZwrR8+UBHStZy5u RUJV5euQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jT7a1-0008H3-3j; Mon, 27 Apr 2020 17:30:05 +0000 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jT7Zy-0007lG-B6 for linux-arm-kernel@lists.infradead.org; Mon, 27 Apr 2020 17:30:03 +0000 Received: by mail-pf1-x443.google.com with SMTP id d184so9328273pfd.4 for ; Mon, 27 Apr 2020 10:30:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=SCLyDRiJjkisSI5+I7kNMlITwcAUmvW5WBS3LcGSTZs=; b=f7u4o2sKuPfQQUUeIiWva27PcW47sExOw2ojdV1iJqO2YiekLlLQPdnrUK+CgZhhfG cJ+ZgM4cPD7Y5oXHfP1JI9yj1gmTLQnN42FMZiF4iS0jQG9ocWgmH7gSirxMIvMmnn37 /lKlbgE9xfA929pEOUYZiTjseraB5PJQgyhO23j194oD+QjFpU1H46lSOKsyuh93rsEk 35afT3WPxbKMLvr22/qWiT1enHGec0iP/pL33VaHplNezHvl02oBGpKQ3YTOr3YjRB2P 3Ij9FTxtADBjH4qD0IK8bbqe7j3tXMbRQLrit3H3nqsBJwOQfm/2ExV+mpjsXDupHPec hr1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=SCLyDRiJjkisSI5+I7kNMlITwcAUmvW5WBS3LcGSTZs=; b=JSM7fitEi9FyFpgokbaMG70kNT4m3vd7YwNqsW2dQarMq2KNtn/i9a8SzJXaEP+Vel iZalbZw7vZMRmw1Ey4KNc2tEmEwzTrRV3bjb7TL9W3QSePWdbcXiZGADJsY3VLwoNYBD VAhGl1Wmutj5dcdTOmGCnigWAKCILj5wYBfsZMwH511PqLdFcv2GMTZ1+UDYBWXhDfKu 86t8NY4A+D9HztDFQDBv4KUQwnL7mSjhPnDaaUD9HCV2soOfhKK7QJyJNL00xjOJuk5q WEaknqpBtAVe74Gk8qhaSBl2YGFZzMQ8pH67NzxXj3/klrPBH/+tmYT6ddyOK9mlWuLy uu8A== X-Gm-Message-State: AGi0PuZ6qa3vJ1ospQQkF6TlTLG/wEezqgc7LDaOHx8aqUS6FFrJMSps 6BQp4+nJkFji8CoGNbEd0Xg= X-Google-Smtp-Source: APiQypLAkvMyKxt4+GqBWPPQov4z6yuIinvDdHdu3rfRqyLGtyrl9GGPdWcRQ69bAKSDmiis+wgM8A== X-Received: by 2002:a63:f843:: with SMTP id v3mr24542277pgj.421.1588008601102; Mon, 27 Apr 2020 10:30:01 -0700 (PDT) Received: from [10.69.79.32] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id ml24sm11558508pjb.48.2020.04.27.10.29.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Apr 2020 10:30:00 -0700 (PDT) Subject: Re: [PATCH -next] tty: serial: bcm63xx: fix missing clk_put() in bcm63xx_uart To: Jiri Slaby , Zou Wei , gregkh@linuxfoundation.org, bcm-kernel-feedback-list@broadcom.com, linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <1587472306-105155-1-git-send-email-zou_wei@huawei.com> <4cd8f963-9292-faef-1e24-df90821274d6@suse.cz> From: Florian Fainelli Message-ID: <73c4cebb-467b-e5d5-89bf-8a6fe29cf858@gmail.com> Date: Mon, 27 Apr 2020 10:29:58 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Firefox/68.0 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <4cd8f963-9292-faef-1e24-df90821274d6@suse.cz> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200427_103002_423172_7460760D X-CRM114-Status: GOOD ( 12.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/26/2020 11:19 PM, Jiri Slaby wrote: > On 21. 04. 20, 14:31, Zou Wei wrote: >> This patch fixes below error reported by coccicheck >> >> drivers/tty/serial/bcm63xx_uart.c:848:2-8: ERROR: missing clk_put; >> clk_get on line 842 and execution via conditional on line 846 >> >> Fixes: ab4382d27412 ("tty: move drivers/serial/ to drivers/tty/serial/") >> Reported-by: Hulk Robot >> Signed-off-by: Zou Wei >> --- >> drivers/tty/serial/bcm63xx_uart.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/tty/serial/bcm63xx_uart.c b/drivers/tty/serial/bcm63xx_uart.c >> index 5674da2..ed0aa5c 100644 >> --- a/drivers/tty/serial/bcm63xx_uart.c >> +++ b/drivers/tty/serial/bcm63xx_uart.c >> @@ -843,8 +843,10 @@ static int bcm_uart_probe(struct platform_device *pdev) >> if (IS_ERR(clk) && pdev->dev.of_node) >> clk = of_clk_get(pdev->dev.of_node, 0); >> >> - if (IS_ERR(clk)) >> + if (IS_ERR(clk)) { >> + clk_put(clk); > > Why would you want to put an erroneous clk? Doh, somehow I completely missed, you are right this does not look legit. -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel