From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D69D1C31E49 for ; Wed, 19 Jun 2019 11:54:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 80C712075E for ; Wed, 19 Jun 2019 11:54:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lh/sR4dE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 80C712075E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ASGW74VekdL6dsN5Y+BGJAo3Q1dPse94vERlI/gQnLQ=; b=lh/sR4dEAN21O5 PT380qIdp1nbr5vuYusXLO4E6YXI3e2CVsOMsBWV8yEU1UmNMvl8if3TUZbcmqbcmgqvdWaS7qE1i rz9BoX6aXfxe01NJyMbNbwkAvhHra2B6h5sxb7nA0ThDqbNZylIQSgGbpGilRMY6SLh5E8o3f3Xq5 DgD/45jDzsX59yHtpVQ54jSEz3SwJ+1M1xWEuHpIUaxKBkuLnvpk58EJvvvrjfbMCkzZ2Lxua8uhj 2nna3Fbc54divU2La3Sgv438HGNSsKpnvY7wIlnzhEn6+slpVLe12WYEyZu6Cjwd+lDlwlzOt3f5m /KP9aF8rQpKIIu31xqaA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hdZAR-0004m9-TB; Wed, 19 Jun 2019 11:54:19 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hdZAP-0004lg-Gn for linux-arm-kernel@lists.infradead.org; Wed, 19 Jun 2019 11:54:18 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 89DB6360; Wed, 19 Jun 2019 04:54:16 -0700 (PDT) Received: from [10.1.196.129] (ostrya.cambridge.arm.com [10.1.196.129]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 71F893F738; Wed, 19 Jun 2019 04:56:01 -0700 (PDT) Subject: Re: [PATCH 3/8] iommu/arm-smmu-v3: Support platform SSID To: Will Deacon References: <20190610184714.6786-1-jean-philippe.brucker@arm.com> <20190610184714.6786-4-jean-philippe.brucker@arm.com> <20190618180851.GK4270@fuggles.cambridge.arm.com> From: Jean-Philippe Brucker Message-ID: <73cfb797-5ae7-b9d9-01ea-fe98a1bed5c3@arm.com> Date: Wed, 19 Jun 2019 12:53:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190618180851.GK4270@fuggles.cambridge.arm.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190619_045417_604009_D67AACF5 X-CRM114-Status: GOOD ( 15.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "devicetree@vger.kernel.org" , "jacob.jun.pan@linux.intel.com" , "joro@8bytes.org" , "linux-kernel@vger.kernel.org" , "eric.auger@redhat.com" , "iommu@lists.linux-foundation.org" , "robh+dt@kernel.org" , Robin Murphy , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 18/06/2019 19:08, Will Deacon wrote: >> + /* >> + * If the SMMU doesn't support 2-stage CD, limit the linear >> + * tables to a reasonable number of contexts, let's say >> + * 64kB / sizeof(ctx_desc) = 1024 = 2^10 >> + */ >> + if (!(smmu->features & ARM_SMMU_FEAT_2_LVL_CDTAB)) >> + master->ssid_bits = min(master->ssid_bits, 10U); > > Please introduce a #define for the 10, so that it is computed in the way > you describe in the comment (a bit like we do for things like queue sizes). Ok >> + >> group = iommu_group_get_for_dev(dev); >> if (!IS_ERR(group)) { >> iommu_group_put(group); >> diff --git a/drivers/iommu/of_iommu.c b/drivers/iommu/of_iommu.c >> index f04a6df65eb8..04f4f6b95d82 100644 >> --- a/drivers/iommu/of_iommu.c >> +++ b/drivers/iommu/of_iommu.c >> @@ -206,8 +206,12 @@ const struct iommu_ops *of_iommu_configure(struct device *dev, >> if (err) >> break; >> } >> - } >> >> + fwspec = dev_iommu_fwspec_get(dev); >> + if (!err && fwspec) >> + of_property_read_u32(master_np, "pasid-num-bits", >> + &fwspec->num_pasid_bits); >> + } > > Hmm. Do you know if there's anything in ACPI for this? Yes, IORT version D introduced a "substream width" field for the Named component node (platform device). I don't think it existed last time I checked, so I'll see about supporting it. Thanks, Jean _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel