From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8ADA1C27C78 for ; Wed, 12 Jun 2024 00:44:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5NTY7O9vlYiJDnsoEIMvSsij28gjoEQl+bA1Z5C+Mlg=; b=vabNpIWKB8IWqUWUVoTGk8iU1f r81fEk+vcFKCHe1T438MmEGIzmigf2MKC9aflgPzqaM8i3YzK3QThgjrqj6Srl4chpC3WfppPgyHj ZQCHv/o3YJmi3jJvCjNhSFcxIXBVeE+qplXubLoJjZvtyvxpEdk+DykrovU2O3rDPERATFj1jS5sT KPFK8+zaL/Ytmc3vUXiq8zDeim3ovyAFgx5tnf9pFKL+gdbjbpdW4hc63i4R5YUQK64fjKeyo3eHv QOQcxUIQ5uSXq/Vmp4GCNZCMVa1fo0zFJpU+1813vpl+RVJfUTpJ7UPmhas8mHSrEe3p4WB8zWUXt /kvnVpzA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sHC5r-0000000Ac9e-00ND; Wed, 12 Jun 2024 00:44:03 +0000 Received: from mail-ot1-x330.google.com ([2607:f8b0:4864:20::330]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sHC5o-0000000Ac96-0493 for linux-arm-kernel@lists.infradead.org; Wed, 12 Jun 2024 00:44:01 +0000 Received: by mail-ot1-x330.google.com with SMTP id 46e09a7af769-6f8d0a1e500so4609240a34.3 for ; Tue, 11 Jun 2024 17:43:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718153037; x=1718757837; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5NTY7O9vlYiJDnsoEIMvSsij28gjoEQl+bA1Z5C+Mlg=; b=gK6IuHQ9cHCbZ1vinJtagsLK/FadxK+Moff/KWrS62znAH3C2H/WKNk84pBxNEG7mL /q5i+JU56vOsWU/5XU2wrYYQA8mNbj8Vh/REiJUCkjQBJxc0J2drv1cDL6eUtqbcKGkc WBY6LLa22zw1KSZhK8ZzmnRdPoormBnqUSfWLCNUJEMoczFOVOatz1sy6SN7rOX0r5bP /BUlOdXqIoX9PXVMhs0LZncSmiLRfnYNetyWylethFvO2cimncXy6gu0UublYMgDkPxz 1e0QdKZbeu29JMBaJs8dqsovV5TSX+Rj/WJibeZkJiLDWG0fdM370Ubm6HBqsfSht1QJ +wKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718153037; x=1718757837; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5NTY7O9vlYiJDnsoEIMvSsij28gjoEQl+bA1Z5C+Mlg=; b=hMkm0owc4xWdBpIJ9BPD8Hb4DKMW5Zn5jDIOSSkSEZrsbNH31xOuPdIGltgo+kh6gd NKpEhZKt5nk92lFCMS9f6UupG3K7pPZHDvYiDFBD7c2y64fC8M+iNFR3nrdQLx2W/5yw q7KYJpd3rEsI6yYrRswY+JT8Qnsteu0Y073l+gzcByytWwKrzDApSAXnh4LpwS6rI+Ou OxWBkQlvQ+4d0VgrzLpzZVT9kCr5FL3MsONjClCVsvak+u6E8g2FnSW17yh+PXhBiZkc MqDmdaTeHykVilYjCrdx0Jtx9jLq9ywt8N9lGyVgrlataWgfamRX/DrsGSgumCek1tLa qy8w== X-Forwarded-Encrypted: i=1; AJvYcCX2kIuCEdUVMiIQ6mwSstMjXjaZ2JG2Ruw7DQ9hllbpeceeHGUrgUtEc3VTos4mH1WUPXv9wZQ8iY91X+wwBmTG0rqqqiAOeUaIZ0DdpmyxAr4yJNc= X-Gm-Message-State: AOJu0YxK4Y0R30FWbBr5xJ7wW5i3P5ztGSpguAgF0z6BBInhGYqIAwcQ /Csxb9QkXytDdN/Cqa93wHpTR+51bAQ51kL686Bq/yW6Ycw2o1gg X-Google-Smtp-Source: AGHT+IHiQCKVYLK92Z9lWkx2GmQLTJkXl3ttzKo2rRRld+zTQSoZDg5YxwhqKOzQdSXlyDhZJj/k6w== X-Received: by 2002:a05:6871:286:b0:250:8970:499d with SMTP id 586e51a60fabf-25514bfd7b0mr482657fac.3.1718153037424; Tue, 11 Jun 2024 17:43:57 -0700 (PDT) Received: from [172.19.1.47] (60-250-192-107.hinet-ip.hinet.net. [60.250.192.107]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7042d87b216sm6103901b3a.11.2024.06.11.17.43.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Jun 2024 17:43:56 -0700 (PDT) Message-ID: <73d2167a-84ee-40a4-a68d-ba25229ff8ce@gmail.com> Date: Wed, 12 Jun 2024 08:43:54 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] tty: serial: ma35d1: Add a NULL check for of_node To: Greg KH Cc: dan.carpenter@linaro.org, jirislaby@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Jacky Huang References: <20240611092251.159149-1-ychuang570808@gmail.com> <2024061118-sycamore-leggings-05a9@gregkh> Content-Language: en-US From: Jacky Huang In-Reply-To: <2024061118-sycamore-leggings-05a9@gregkh> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240611_174400_076125_510E3C8C X-CRM114-Status: GOOD ( 18.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dear Greg, On 2024/6/11 下午 07:11, Greg KH wrote: > On Tue, Jun 11, 2024 at 09:22:51AM +0000, Jacky Huang wrote: >> From: Jacky Huang >> >> The pdev->dev.of_node can be NULL if the "serial" node is absent. >> Add a NULL check to return an error in such cases. >> >> Signed-off-by: Jacky Huang >> --- >> drivers/tty/serial/ma35d1_serial.c | 13 +++++++------ >> 1 file changed, 7 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/tty/serial/ma35d1_serial.c b/drivers/tty/serial/ma35d1_serial.c >> index 19f0a305cc43..3b4206e815fe 100644 >> --- a/drivers/tty/serial/ma35d1_serial.c >> +++ b/drivers/tty/serial/ma35d1_serial.c >> @@ -688,12 +688,13 @@ static int ma35d1serial_probe(struct platform_device *pdev) >> struct uart_ma35d1_port *up; >> int ret = 0; >> >> - if (pdev->dev.of_node) { >> - ret = of_alias_get_id(pdev->dev.of_node, "serial"); >> - if (ret < 0) { >> - dev_err(&pdev->dev, "failed to get alias/pdev id, errno %d\n", ret); >> - return ret; >> - } >> + if (!pdev->dev.of_node) >> + return -ENODEV; >> + >> + ret = of_alias_get_id(pdev->dev.of_node, "serial"); >> + if (ret < 0) { >> + dev_err(&pdev->dev, "failed to get alias/pdev id, errno %d\n", ret); >> + return ret; >> } >> up = &ma35d1serial_ports[ret]; >> up->port.line = ret; > What commit id does this fix? > > thanks, > > greg k-h This patch fix the in tree ma35d1 serial driver. The last commit for ma35d1_serial.c is '6b64f8e360c00f180cffa1806095cdd2abc55b16'. Best Regards, Jacky Huang