From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 35C00C38A02 for ; Fri, 28 Oct 2022 10:33:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject: CC:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lnmZmUxVQ9Co9hGNJM4ByO+XTfEfN2ZoWgV59WyW9vE=; b=Cv/myggPGcul+x n808sntkx0W3hYZVfs5x7TBVIbHt7jn2fcOMe7LMwfMULlOu9GOtFX08mEpYrSLKgtqF6baakMmQS 2iOK15Xu4TFKGZsciITRUefFHRJ5d28FmKQD3e1DTB42AH4cnXgfZgsIM5T7zxgbdnb26Vc8MId4W KWPr09SD4MlKsj05vdJ5uYCYlYDhaMXYyIxcbj7dhxvOiJqCKgVTfUQfZufdzuJifDMkvUUmW/k0Q U2kT1i3b+sHLOLIXha65Mjp6JbWh+AfkpMIfdblFvKiKNVBx4y2lPRvslpSXnMMbGTfcSkGJZi4Lp SCK952nYnRtvL6z5Gtpw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ooMfU-00Gg29-Fm; Fri, 28 Oct 2022 10:32:52 +0000 Received: from lelv0143.ext.ti.com ([198.47.23.248]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ooMfK-00Gfw0-NV; Fri, 28 Oct 2022 10:32:44 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 29SAWUq8067367; Fri, 28 Oct 2022 05:32:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1666953150; bh=o8nT2/2rUODqSZbBDTj1WsC9qr3f4FxqGs/VuExA9ZM=; h=Date:CC:Subject:To:References:From:In-Reply-To; b=n1lFw3/i08IGVUiRT2zvo2D8a3Z9N44jH45YxH9jbPenxOzb01UC4oMyLCRk4PX5w xKtUgiHJW5I6/KS8Bp3hIkBTkmYt7MwK1TdhgX/Qu6vW3Bo81khX0E9OO50fI9nkPx sjDteAfM0u6u7s1k0S0ApXCKz1snWIwVklCJ2xf0= Received: from DLEE107.ent.ti.com (dlee107.ent.ti.com [157.170.170.37]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 29SAWUcJ051954 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 28 Oct 2022 05:32:30 -0500 Received: from DLEE104.ent.ti.com (157.170.170.34) by DLEE107.ent.ti.com (157.170.170.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.6; Fri, 28 Oct 2022 05:32:30 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE104.ent.ti.com (157.170.170.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.6 via Frontend Transport; Fri, 28 Oct 2022 05:32:30 -0500 Received: from [172.24.145.87] (ileaxei01-snat.itg.ti.com [10.180.69.5]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 29SAWQBP107190; Fri, 28 Oct 2022 05:32:26 -0500 Message-ID: <73df3de9-7f41-1164-b492-b96d6e73d306@ti.com> Date: Fri, 28 Oct 2022 16:02:25 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 CC: , , , , , , , , , , , Subject: Re: [PATCH v3 2/3] phy: ti: gmii-sel: Update methods for fetching and using qsgmii main port To: Roger Quadros References: <20221026074532.109220-1-s-vadapalli@ti.com> <20221026074532.109220-3-s-vadapalli@ti.com> Content-Language: en-US From: Siddharth Vadapalli In-Reply-To: X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221028_033242_983939_69BDF1DF X-CRM114-Status: GOOD ( 26.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Roger, On 28/10/22 15:53, Roger Quadros wrote: > Hi Siddharth, > > On 26/10/2022 10:45, Siddharth Vadapalli wrote: >> The number of QSGMII main ports are specific to the device. TI's J7200 for >> which the QSGMII main port property is fetched from the device-tree has >> only one QSGMII main port. However, devices like TI's J721e support up to >> two QSGMII main ports. Thus, the existing methods for fetching and using >> the QSGMII main port are not scalable. >> >> Update the existing methods for handling the QSGMII main ports and its >> associated requirements to make it scalable for future devices. >> >> Signed-off-by: Siddharth Vadapalli >> --- >> drivers/phy/ti/phy-gmii-sel.c | 29 ++++++++++++++++++++++------- >> 1 file changed, 22 insertions(+), 7 deletions(-) >> >> diff --git a/drivers/phy/ti/phy-gmii-sel.c b/drivers/phy/ti/phy-gmii-sel.c >> index 0bcfd6d96b4d..c8f30d2e1f46 100644 >> --- a/drivers/phy/ti/phy-gmii-sel.c >> +++ b/drivers/phy/ti/phy-gmii-sel.c >> @@ -50,6 +50,7 @@ struct phy_gmii_sel_soc_data { >> const struct reg_field (*regfields)[PHY_GMII_SEL_LAST]; >> bool use_of_data; >> u64 extra_modes; >> + u32 num_qsgmii_main_ports; >> }; >> >> struct phy_gmii_sel_priv { >> @@ -213,6 +214,8 @@ struct phy_gmii_sel_soc_data phy_gmii_sel_cpsw5g_soc_j7200 = { >> .use_of_data = true, >> .regfields = phy_gmii_sel_fields_am654, >> .extra_modes = BIT(PHY_INTERFACE_MODE_QSGMII), >> + .num_ports = 4, >> + .num_qsgmii_main_ports = 1, >> }; >> >> static const struct of_device_id phy_gmii_sel_id_table[] = { >> @@ -378,11 +381,13 @@ static int phy_gmii_sel_init_ports(struct phy_gmii_sel_priv *priv) >> static int phy_gmii_sel_probe(struct platform_device *pdev) >> { >> struct device *dev = &pdev->dev; >> + const struct phy_gmii_sel_soc_data *soc_data; >> struct device_node *node = dev->of_node; >> const struct of_device_id *of_id; >> struct phy_gmii_sel_priv *priv; >> u32 main_ports = 1; >> int ret; >> + u32 i; >> >> of_id = of_match_node(phy_gmii_sel_id_table, pdev->dev.of_node); >> if (!of_id) >> @@ -394,16 +399,26 @@ static int phy_gmii_sel_probe(struct platform_device *pdev) >> >> priv->dev = &pdev->dev; >> priv->soc_data = of_id->data; >> + soc_data = priv->soc_data; >> priv->num_ports = priv->soc_data->num_ports; >> - of_property_read_u32(node, "ti,qsgmii-main-ports", &main_ports); >> + priv->qsgmii_main_ports = 0; >> + >> /* >> - * Ensure that main_ports is within bounds. If the property >> - * ti,qsgmii-main-ports is not mentioned, or the value mentioned >> - * is out of bounds, default to 1. >> + * Based on the compatible, try to read the appropriate number of >> + * QSGMII main ports from the "ti,qsgmii-main-ports" property from >> + * the device-tree node. >> */ >> - if (main_ports < 1 || main_ports > 4) >> - main_ports = 1; >> - priv->qsgmii_main_ports = PHY_GMII_PORT(main_ports); >> + for (i = 0; i < soc_data->num_qsgmii_main_ports; i++) { >> + of_property_read_u32_index(node, "ti,qsgmii-main-ports", i, &main_ports); >> + /* >> + * Ensure that main_ports is within bounds. >> + */ >> + if (main_ports < 1 || main_ports > soc_data->num_ports) { >> + dev_err(dev, "Invalid qsgmii main port provided\n"); > > nit: This message is a bit misleading if the property does not exist in DT. > > How about just "Invalid ti,qsgmii-main-ports" Thank you for reviewing the patch. The variable "main_ports" has been initialized to 1 at the top. Thus, the only way the error condition is entered is if "ti,qsgmii-main-ports" is mentioned in the device-tree with an invalid value. If "ti,qsgmii-main-ports" is not mentioned in the device-tree, then "main_ports" continues being 1, since the function "of_property_read_u32_index()" does not modify "main_ports" if "ti,qsgmii-main-ports" is not present in the device-tree. Thus, in this case, the error condition isn't reached. Regards, Siddharth. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel