From: Michal Simek <michal.simek@amd.com>
To: Yangtao Li <frank.li@vivo.com>, Moritz Fischer <mdf@kernel.org>,
Wu Hao <hao.wu@intel.com>, Xu Yilun <yilun.xu@intel.com>,
Tom Rix <trix@redhat.com>
Cc: linux-fpga@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 8/8] fpga: zynq-fpga: Convert to devm_platform_ioremap_resource()
Date: Fri, 7 Jul 2023 06:55:49 +0200 [thread overview]
Message-ID: <73eaa72b-9ee2-3aca-b5b9-bc53e6a40467@amd.com> (raw)
In-Reply-To: <20230705094655.44753-8-frank.li@vivo.com>
On 7/5/23 11:46, Yangtao Li wrote:
> Use devm_platform_ioremap_resource() to simplify code.
>
> Signed-off-by: Yangtao Li <frank.li@vivo.com>
> ---
> drivers/fpga/zynq-fpga.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/fpga/zynq-fpga.c b/drivers/fpga/zynq-fpga.c
> index f8214cae9b6e..96611d424a10 100644
> --- a/drivers/fpga/zynq-fpga.c
> +++ b/drivers/fpga/zynq-fpga.c
> @@ -555,7 +555,6 @@ static int zynq_fpga_probe(struct platform_device *pdev)
> struct device *dev = &pdev->dev;
> struct zynq_fpga_priv *priv;
> struct fpga_manager *mgr;
> - struct resource *res;
> int err;
>
> priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
> @@ -563,8 +562,7 @@ static int zynq_fpga_probe(struct platform_device *pdev)
> return -ENOMEM;
> spin_lock_init(&priv->dma_lock);
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - priv->io_base = devm_ioremap_resource(dev, res);
> + priv->io_base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(priv->io_base))
> return PTR_ERR(priv->io_base);
>
Acked-by: Michal Simek <michal.simek@amd.com>
M
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-07-07 4:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230705094655.44753-1-frank.li@vivo.com>
2023-07-05 9:46 ` [PATCH 5/8] fpga: xilinx-pr-decoupler: Convert to devm_platform_ioremap_resource() Yangtao Li
2023-07-07 4:55 ` Michal Simek
2023-07-10 8:42 ` Xu Yilun
2023-07-05 9:46 ` [PATCH 8/8] fpga: zynq-fpga: " Yangtao Li
2023-07-07 4:55 ` Michal Simek [this message]
2023-07-10 8:54 ` Xu Yilun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73eaa72b-9ee2-3aca-b5b9-bc53e6a40467@amd.com \
--to=michal.simek@amd.com \
--cc=frank.li@vivo.com \
--cc=hao.wu@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox