public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: s.trumtrar@pengutronix.de (Steffen Trumtrar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: socfpga: Fix NAND controller node compatible
Date: Mon, 14 May 2018 09:11:48 +0200	[thread overview]
Message-ID: <73h8nak8y3.fsf@pengutronix.de> (raw)
In-Reply-To: <20180510125223.16056-1-marex@denx.de>


Marek Vasut <marex@denx.de> writes:

> The compatible string for the Denali NAND controller is 
> incorrect,
> fix it by replacing it with one matching the DT bindings and the
> driver.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Fixes: d837a80d19 ("ARM: dts: socfpga: add nand controller 
> nodes")
> Cc: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> Cc: Dinh Nguyen <dinguyen@kernel.org>
> ---
>  arch/arm/boot/dts/socfpga.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/socfpga.dtsi 
> b/arch/arm/boot/dts/socfpga.dtsi
> index 7e24dc8e82d4..d697f5062624 100644
> --- a/arch/arm/boot/dts/socfpga.dtsi
> +++ b/arch/arm/boot/dts/socfpga.dtsi
> @@ -744,7 +744,7 @@
>  		nand0: nand at ff900000 {
>  			#address-cells = <0x1>;
>  			#size-cells = <0x1>;
> -			compatible = "denali,denali-nand-dt";
> +			compatible = "altr,socfpga-denali-nand";
>  			reg = <0xff900000 0x100000>,
>  			      <0xffb80000 0x10000>;
>  			reg-names = "nand_data", "denali_reg";

Ack. As the binding was changed after d837a80d19 this is obviously
correct.

@Dinh: Maybe you also want to cleanup the socfpga_arria10.dtsi? It 
has
both compatibles, but the "denali,denali-nand-dt" seems to be 
obsolete.

Thanks,
Steffen

-- 
Pengutronix e.K.                           | Steffen Trumtrar 
|
Industrial Linux Solutions                 | 
http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: 
+49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax: 
+49-5121-206917-5555 |

  reply	other threads:[~2018-05-14  7:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-10 12:52 [PATCH] ARM: dts: socfpga: Fix NAND controller node compatible Marek Vasut
2018-05-14  7:11 ` Steffen Trumtrar [this message]
2018-05-14 15:11   ` Dinh Nguyen
2018-05-14 15:11   ` Dinh Nguyen
2018-05-14 15:11   ` Dinh Nguyen
2018-05-14 15:21   ` Dinh Nguyen
2018-05-14 15:21   ` Dinh Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=73h8nak8y3.fsf@pengutronix.de \
    --to=s.trumtrar@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox