From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: debug-ll: fix BCM63xx entry for multiplatform
Date: Mon, 18 Jan 2016 11:42:05 +0100 [thread overview]
Message-ID: <7401195.yJZcvlhzfd@wuerfel> (raw)
In-Reply-To: <20160118095919.GE19062@n2100.arm.linux.org.uk>
On Monday 18 January 2016 09:59:19 Russell King - ARM Linux wrote:
> On Mon, Jan 18, 2016 at 10:51:00AM +0100, Arnd Bergmann wrote:
> > During my randconfig build testing, I found that a kernel with
> > DEBUG_AT91_UART and ARCH_BCM_63XX fails to build:
> >
> > arch/arm/include/debug/at91.S:18:0: error: "CONFIG_DEBUG_UART_VIRT" redefined [-Werror]
>
> Why do we have files defining CONFIG_* symbols? This is the real error
> here - no source file should be defining this.
I agree that we should change that too, I'll send a patch for it as well.
However, this just let me stumble on the problem, without AT91 getting this
wrong, I would not have noticed that bcm63xx breaks other platforms.
The AT91 thing is just confusing but otherwise harmless, and I wouldn't
mark that fix for stable.
Arnd
next prev parent reply other threads:[~2016-01-18 10:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-18 9:51 [PATCH] ARM: debug-ll: fix BCM63xx entry for multiplatform Arnd Bergmann
2016-01-18 9:59 ` Russell King - ARM Linux
2016-01-18 10:42 ` Arnd Bergmann [this message]
2016-01-18 17:41 ` Randy Dunlap
2016-01-18 19:38 ` Arnd Bergmann
2016-01-18 19:07 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7401195.yJZcvlhzfd@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox