From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 736D7C77B61 for ; Thu, 27 Apr 2023 08:32:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WZM5EB2lmMpsdq1oxG6Kcl+QmQNJiic0tqLI1P3R9Vg=; b=TjbLGhMy0TIpa1 Pq9TXkj0TK9Q41HtrggEO1hE0hgMCQ2M+03ezt3LEYpts+y5/VUbYswYvttyos3QIOK95UJBjYBsU PPvmSoyfA9llV9coqImd+CxTd7XCpxtOSSAcN9IDCZTi2L0qpI8vKbf98JH5E5XqWZThZZNxY7lYm 08xOifzQCmHu1eKxequKYFnLZnhm6ARulUVSjDWKAzwcRH17zORh2gRcdmoVrQbLP/VPWlVxJIjCz 7pPDnM27vuJ5++orJG5PuSU1Pc3yahmzIHsdfquEX9YhyQUTKBTc5sygvtKU6SfLkSxvUPaBOBYov WNUQxpxVrs8oKkQ/Dqeg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1prx2C-005p4C-1f; Thu, 27 Apr 2023 08:31:24 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1prx29-005p3S-1e; Thu, 27 Apr 2023 08:31:23 +0000 X-UUID: ddd6d9fee4d511ed8687db9d93187ff1-20230427 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=MIME-Version:Content-Transfer-Encoding:Content-ID:Content-Type:In-Reply-To:References:Message-ID:Date:Subject:CC:To:From; bh=behlzJ7kADJdH96B5eIU9iC/GC1kHI1feLpUNnwI7Yk=; b=ZjkIB06+Zzf04CvsXvjU6/BcOOrP94gdLsQuATs1/tTZmhxQ5bS4+jap2ky6TVX/Q/wceLNZXdbG3j55xrsId6vusjet56XVLAO5rg3Fj0veVnCWc9aw1fryYu7776bdFh0J4E37FJtc2RZAQOLN6yUv7aNervYN1MdplHSDadc=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.22,REQID:e8640c3c-89ae-4e82-b036-5696bf582099,IP:0,U RL:0,TC:0,Content:-5,EDM:0,RT:0,SF:51,FILE:0,BULK:0,RULE:Release_Ham,ACTIO N:release,TS:46 X-CID-INFO: VERSION:1.1.22,REQID:e8640c3c-89ae-4e82-b036-5696bf582099,IP:0,URL :0,TC:0,Content:-5,EDM:0,RT:0,SF:51,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:46 X-CID-META: VersionHash:120426c,CLOUDID:a227156a-2f20-4998-991c-3b78627e4938,B ulkID:2304271631157N1NB920,BulkQuantity:0,Recheck:0,SF:38|29|28|17|19|48|1 02,TC:nil,Content:0,EDM:-3,IP:nil,URL:1,File:nil,Bulk:nil,QS:nil,BEC:nil,C OL:0,OSI:0,OSA:0,AV:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-UUID: ddd6d9fee4d511ed8687db9d93187ff1-20230427 Received: from mtkmbs13n1.mediatek.inc [(172.21.101.193)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 182036031; Thu, 27 Apr 2023 01:31:11 -0700 Received: from mtkmbs10n1.mediatek.inc (172.21.101.34) by mtkmbs11n2.mediatek.inc (172.21.101.187) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Thu, 27 Apr 2023 16:31:09 +0800 Received: from APC01-PSA-obe.outbound.protection.outlook.com (172.21.101.237) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server id 15.2.1118.25 via Frontend Transport; Thu, 27 Apr 2023 16:31:09 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=djRfXIhCOGMHclnhGzCi07ihoc1D4tOhSqrdyY1KpaSqSRaed0WGrsqcHOECIfaM9CzTWWmQbVICs4Ox5DQ8lWNqL3QTfTA9AcK3UA1Mr2R3g91vb8yA5QEk1OLD4/cg9ZhUO+MlSw11mmjNouMAj+Fsm0xWYUyayrgOpyw/Prsk9S8W/HcAocIgqE2kDFdbFjyTMvb1Ksukdq6d+welZs4c7qq/UUSt2axmWTRaXK+4mqXL2TvAhXQBHv4c3uhGTEs4B2SroPcNRKUCUcPeeeMXCKXgjTmtEXkCNMUu0ZZx6xmnnRb2LhOD7eHj6aaE0ESfnuUKlGzNraq4dcd5yQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=behlzJ7kADJdH96B5eIU9iC/GC1kHI1feLpUNnwI7Yk=; b=XUw9dsT55fpHcBBHA0VPIYirwbw4ZTyWBv54xkAuTyZCf/KrYSrKcQ+mC3Tqt1oMmyAdFiRlMKgLEQPl26JQ5EX5bVcytHDht6hx9bFEc0x+tJUBaapvq5vpl5x9aKoGmazY7UE4r2Hmv++TRGZyZWfu402l3T5f5P03LW8UC42JxWjv2TRn1N3ZO0CbYha+OU4yjm08HTDOYAZM08AYqPwNaX4a5rIUXN4yOTo5CoMUSlooOh32d8O0CUX2Sk5puyqSXRnn83WrNy6fjWd+cSqjOUUrlagp8lTn/mqHOn4RAnqI9Hnh3SMAqzHn+q5+cMNRIesCu4X3drsZd9NUHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mediatek.com; dmarc=pass action=none header.from=mediatek.com; dkim=pass header.d=mediatek.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mediateko365.onmicrosoft.com; s=selector2-mediateko365-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=behlzJ7kADJdH96B5eIU9iC/GC1kHI1feLpUNnwI7Yk=; b=WFX0DdEwZ8qZpm+uB/AFu0CaMF5vaz1hSwFW+alwaIprIZxi23GUyGej09ayZP2YFQZuPFO7Z2G4ydPbLKh3SVZTUV9QqFDwy9mmr+6+OYdrRk6YHeqKZlO4ARPtSJDUlU6JYH2ukv7BVb+sO8ucUxxD9z/L1mu6xjmPRcN2UrU= Received: from PSAPR03MB5365.apcprd03.prod.outlook.com (2603:1096:301:17::5) by TYZPR03MB5214.apcprd03.prod.outlook.com (2603:1096:400:37::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.22; Thu, 27 Apr 2023 08:31:07 +0000 Received: from PSAPR03MB5365.apcprd03.prod.outlook.com ([fe80::6eca:1bb6:7d2c:a4e0]) by PSAPR03MB5365.apcprd03.prod.outlook.com ([fe80::6eca:1bb6:7d2c:a4e0%6]) with mapi id 15.20.6340.022; Thu, 27 Apr 2023 08:31:07 +0000 From: =?utf-8?B?Smlhbmp1biBXYW5nICjnjovlu7rlhpsp?= To: "frank-w@public-files.de" , "linux@fw-web.de" CC: "linux-mediatek@lists.infradead.org" , "linux-kernel@vger.kernel.org" , =?utf-8?B?SmlleXkgWWFuZyAo5p2o5rSBKQ==?= , "robh@kernel.org" , "kw@linux.com" , "linux-arm-kernel@lists.infradead.org" , "matthias.bgg@gmail.com" , "linux-pci@vger.kernel.org" , "lpieralisi@kernel.org" , Ryder Lee , "bhelgaas@google.com" Subject: Re: Aw: [PATCH] PCI: mediatek-gen3: handle PERST after reset Thread-Topic: Aw: [PATCH] PCI: mediatek-gen3: handle PERST after reset Thread-Index: AQHZZWUN3oyBy4cfO0S7ujfcGrEDja8+AfWAgAD4eAA= Date: Thu, 27 Apr 2023 08:31:07 +0000 Message-ID: <74149a72313c1b944c870a45b55893e1b9331c8e.camel@mediatek.com> References: <20230402131347.99268-1-linux@fw-web.de> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=mediatek.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PSAPR03MB5365:EE_|TYZPR03MB5214:EE_ x-ms-office365-filtering-correlation-id: 96e1be67-e8b4-4a6c-3fa2-08db46f9bf4a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 098oIE9ENfoNYlwHxJUI2sQPQg5DXdPLOOM7NcT0TSxXMm8af0znul7b/g2Fp3crKjjisagxdfjwewgtmquAC9ardpAmL7wjmZ9u0VXfTfF3ZlzuWPw9twBiVl58Rq8xEi7SjCBTPpT4Hny4Dc7mdsmEO57ycgTsq9uYeyiwHI6uDHcXOnucvtO3A7yVZa07EsNZczTvGSQsrmsqLPlF/+g45jIM1lnGCQAZVy7ueUwBCM6zvhaV53qmpHgyZv+5HymOLZGq1PEc78mxghjndC+MWJgRTlspBRJ9EmE7cNWehyV6K+79MY91coRMWDfdSncMhYqpRsipP+7w9GfeAm5kod8VrwkX0GaNOYR7/o9FGpaCGF0At6yA7zGgaCaiOW6s/8fC8fsfDvIfzUxbwuH8GZ6cxe00N75P60hp/RKv7U1uT59IeWAzB547JRaEp+5oO57jNWlNCXVs5qBvUWauEfQGp3oN9w1bhx19FZ7lsnW/ViT1cjXYyOpp6CIn4eDjMll9um3Qely6sOMNKmBJitlbAnv4k9DMyP08rx9YXQtrk+8zMhU4sCSU+bb9g6Us8qfy+2pLlVnmyBmznURFbpXfRXjbL84j4nyjMLY= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PSAPR03MB5365.apcprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(39860400002)(136003)(366004)(396003)(376002)(451199021)(86362001)(38070700005)(36756003)(2906002)(85182001)(6486002)(71200400001)(186003)(83380400001)(2616005)(26005)(6512007)(966005)(6506007)(66476007)(4326008)(66556008)(64756008)(66946007)(110136005)(76116006)(478600001)(91956017)(316002)(66446008)(38100700002)(41300700001)(8676002)(54906003)(5660300002)(122000001)(7416002)(8936002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?L2pxNE5jb0hiNkFzTWZtMjFaTkdoWFRqNHdGRzQ1UGt2Sk1pckhTWTRRd0h0?= =?utf-8?B?VHJqTVJkcCtSOWYvNDhaQTdURk9lbUlwVEI0THpLTWhPL29iSU0wMHlsVWdv?= =?utf-8?B?aE4yRlAxY2VsQU5XWUNYUEZBa1BXODdUM29UM09QUkVzZTVDSzNNTVVlak41?= =?utf-8?B?VjA1NzdGbXhIZ21GaHBTQ3laNDBMU05oT1pFb3pEczhWRHdPT2VpU2h1aWs3?= =?utf-8?B?NkwwbUlyS1hGckxDc013dmd0dTFjMXB4Ny8xU1FGa2FrQjcrMU81TThnTktp?= =?utf-8?B?emxKZGlJdFZHYU5iYmtabVFlbXk3NWIvVUJ5QXZDYlpreWltVWhVbVZ4N0NV?= =?utf-8?B?aHlSa0VaRGd5ZFJYUGF4SityZ1dJRVNwWnZVQTB6d3VKWjQ2aHA5KzUrNnRr?= =?utf-8?B?MGRKd2JsYnMxUXorZU5ENHlXd3h5SjFKcjZUMFhKOGlzcURVR0MxUnd4dXJB?= =?utf-8?B?Q0E0NUFNeXBDSkJ0OTJ3Z2ZSKzZjMWFzdWFvcFRyeG9TMms2eVh6NzFUemdP?= =?utf-8?B?M09jMzg2cFRQK1VmTmIyY0ZUSkJmK3Blb2JRVzZNd3V4VUZaQkVyQ240RnlI?= =?utf-8?B?UC9KektEYm9ydmRtVnNqYUpJSGtDZFdtODlONSsyV3M1R2RsN3FyZzlhbExG?= =?utf-8?B?MEdOaXNWeGl0SzREMkhRbS9PZldDbW9pTzF3V1BXZWVqemUrZlFURzB0TWpD?= =?utf-8?B?QXM3MmNXdE5EYlF2bG8vL0FualV3cEp6eTF2djlsRXhCNmpJcHRBLzBIdmVM?= =?utf-8?B?WW5GTUFHR1puL2NFYlpYZEVmVXUwc1ZuazFtN09kaWVaTzJEamZZUHVScWNx?= =?utf-8?B?WlRhM3ZtL29kU3NLUlIxU0xiZmMyYzk5QXpndnVnZS8rY1A2NTIvL3ZjK2w0?= =?utf-8?B?K25NTDluVTdlV0VUMDJmWFNIdnlxRkpDM0w2aEZWd053UnBnZXZ5bk5VTXlx?= =?utf-8?B?RlJmQ2FlY05vWU5BMGwzRkdPc2NHUEVNemlJQk42UGlpMDBwRVlVMTBKUUh1?= =?utf-8?B?Y2lrRG1iOEQrcGRMdERQL2UwMnZuTGR4SHJUZjBlU0VLL0dhSVArWVRuYjR5?= =?utf-8?B?WjJWTFJaVVQ3QlAwT09JWVJNMDNkSmpsS0pKWVB0dHcxZ2s5UXJlZVhMWUlW?= =?utf-8?B?QktxSnF1QTlBVUNEeUtNTXlyWVFEM3p2YnYxby90Q1p1TDNxYzFobGovcUI3?= =?utf-8?B?dTBHbnpOLy9tYktyUGRqdlpwV1h6amg0RUdjOUZ6OGY5bXpIdUtJUVQrdlZw?= =?utf-8?B?QWV5L2lIZkdjNGJyRlJFZXFkZUJmYkVQMS9pSUxXcjFOTGgzQlJUejR4OHYw?= =?utf-8?B?d0dRekNhMmw3ZDBQeE8zRVA1UGEvajFhM0crT0hjWktwU2pkSXpCK2lHR0R3?= =?utf-8?B?VjdEa0YyM2ZnU1NYdWl1b2x4M3h5RldSZWFaaFgrcjR3TC9FWWpqRURCV1Vq?= =?utf-8?B?NlFQT0dWcVBobHBZdHpEaHFycUhsL2NqQXZoVk40UWc3cmx0dkZrTTBaSVM5?= =?utf-8?B?NVdkSDd5WnFXUGJCY0Z0MHlWQWhuWmh0d2M4MGlOdjZKSnpJelErc1hvTC9Y?= =?utf-8?B?cTFwd0dEajFxNU1kaG5LaWhlVmMyOFEzNU5EakVOWTV6VnJ6VHZTMHVuSndS?= =?utf-8?B?TlBjTDJsQkEzY0Fic3VsS2RWL0dkUG1sQXhoeW15ZC8xbmxBSG50WFFzU1NJ?= =?utf-8?B?SDVocU5OeFNkYXY3enVNR0c5dkV4VGZERG1BTExqTmtFRFdJMEpUWkZjYWgx?= =?utf-8?B?Ky84UkZabzEvK3FPR2Q4WDBvRndXWnFvWHlscjZrVTZjRzh3SnNsaWJoSnJN?= =?utf-8?B?VDh2UjNZRnpGZ0JiVXFVaGp4cnpxN2ZNZzRvc2xDUDdYNXFBZVZSYVU2R01D?= =?utf-8?B?K2NJVEdxZHdYRlRqZkIyUUo5Mjlqb3N6WHB3Z0orOFc2akI1R0FkelRrMzFs?= =?utf-8?B?dUkwV1RIZlE5MEJHZFlRMmk1MjZibjBuTWl6d2tkZFBScXZTcjVMbFBzaW9k?= =?utf-8?B?Z01zTEFnK3huMFA5SFF5aTdFSmN2V2g1V1lHNS8wMWRYZ2tQWUtYay9LcHZa?= =?utf-8?B?Wnp6KzJDZkF3aFZ6K3BVZlRFOVNRcm92a1F1bzZ0SVI5R1cycHkrcEtHMklr?= =?utf-8?B?UXBYakVNams3ZllKYi9ja3h3dGNIanVQRFVQM3kwTmE2cmZ6V2RMNGczcFhZ?= =?utf-8?B?aEE9PQ==?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PSAPR03MB5365.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 96e1be67-e8b4-4a6c-3fa2-08db46f9bf4a X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2023 08:31:07.2705 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a7687ede-7a6b-4ef6-bace-642f677fbe31 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VhPVNlFxnBHh2BDNpby4X/x0I8OLGpTdeIWBT2+fEMKOkFJ3lmdwP8ibPO3y0OB/g4PYOSAFxeQdRXYLQGOmf5vAXSegofbEKRsS8slHAlk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR03MB5214 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230427_013121_597052_D02BFDD1 X-CRM114-Status: GOOD ( 20.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Frank, Seems this patch has huge impact on boot time, I'm curious about the NVMe detection issue on mt7986, can you share the SSD model that you are using and the bootup logs with that SSD? Thanks. On Wed, 2023-04-26 at 19:41 +0200, Frank Wunderlich wrote: > External email : Please do not click links or open attachments until > you have verified the sender or the content. > > > Hi > > > Gesendet: Sonntag, 02. April 2023 um 15:13 Uhr > > Von: "Frank Wunderlich" > > De-assert PERST in separate step after reset signals to fully > > comply > > the PCIe CEM clause 2.2. > > > > This fixes some NVME detection issues on mt7986. > > > > Fixes: d3bf75b579b9 ("PCI: mediatek-gen3: Add MediaTek Gen3 driver > > for MT8192") > > Signed-off-by: Frank Wunderlich > > --- > > Patch is taken from user Ruslan aka RRKh61 (permitted me to send it > > with me as author). > > > > https://urldefense.com/v3/__https://forum.banana-pi.org/t/bpi-r3-nvme-connection-issue/14563/17__;!!CTRNKA9wMg0ARbw!nCXEM685pkUpoiZYGKptPYccNrWMeN2D3jIO5_irwxZJ7c6ZzEeACIx-V2WeZHAP_0FKlDDIQ0RbDJ892prtoToDv30$ > > --- > > drivers/pci/controller/pcie-mediatek-gen3.c | 8 +++++++- > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/pci/controller/pcie-mediatek-gen3.c > > b/drivers/pci/controller/pcie-mediatek-gen3.c > > index b8612ce5f4d0..176b1a04565d 100644 > > --- a/drivers/pci/controller/pcie-mediatek-gen3.c > > +++ b/drivers/pci/controller/pcie-mediatek-gen3.c > > @@ -350,7 +350,13 @@ static int mtk_pcie_startup_port(struct > > mtk_gen3_pcie *pcie) > > msleep(100); > > > > /* De-assert reset signals */ > > - val &= ~(PCIE_MAC_RSTB | PCIE_PHY_RSTB | PCIE_BRG_RSTB | > > PCIE_PE_RSTB); > > + val &= ~(PCIE_MAC_RSTB | PCIE_PHY_RSTB | PCIE_BRG_RSTB); > > + writel_relaxed(val, pcie->base + PCIE_RST_CTRL_REG); > > + > > + msleep(100); > > + > > + /* De-assert PERST# signals */ > > + val &= ~(PCIE_PE_RSTB); > > writel_relaxed(val, pcie->base + PCIE_RST_CTRL_REG); > > > > /* Check if the link is up or not */ > > Hi > > just a friendly reminder....do i miss any recipient? > > regards Frank > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel