From: Heiko Stuebner <heiko@sntech.de>
To: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
guptarud@gmail.com
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
phone-devel@vger.kernel.org, Rudraksha Gupta <guptarud@gmail.com>,
Ondrej Jirman <megi@xff.cz>,
"Leonardo G. Trombetta" <lgtrombetta@gmx.com>,
Pavel Machek <pavel@ucw.cz>
Subject: Re: [PATCH v5 3/4] arm64: dts: rockchip: Add magnetometer sensor to Pinephone Pro
Date: Mon, 15 Dec 2025 12:38:17 +0100 [thread overview]
Message-ID: <7420522.MhkbZ0Pkbq@phil> (raw)
In-Reply-To: <20251124-ppp_light_accel_mag_vol-down-v5-3-f9a10a0a50eb@gmail.com>
Am Dienstag, 25. November 2025, 04:47:02 Mitteleuropäische Normalzeit schrieb Rudraksha Gupta via B4 Relay:
> arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
> index f8c74b43ae9f..03721d71766c 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
> @@ -553,6 +553,21 @@ mpu6500@68 {
> };
> };
>
> +&i2c4 {
> + af8133j: compass@1c {
> + compatible = "voltafield,af8133j";
> + reg = <0x1c>;
> + reset-gpios = <&gpio1 RK_PA1 GPIO_ACTIVE_LOW>;
reset-gpios below dvdd-*
And for completeness sake, you probably want to also add a simple
pinctrl entry
> + avdd-supply = <&vcc_3v0>;
> + dvdd-supply = <&vcc_1v8>;
> +
> + mount-matrix =
> + "0", "1", "0",
> + "-1", "0", "0",
> + "0", "0", "1";
> + };
> +};
> +
Thanks
Heiko
next prev parent reply other threads:[~2025-12-15 11:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-25 3:46 [PATCH v5 0/4] Upstreaming Pinephone Pro Patches Rudraksha Gupta via B4 Relay
2025-11-25 3:47 ` [PATCH v5 1/4] arm64: dts: rockchip: Add light/proximity sensor to Pinephone Pro Rudraksha Gupta via B4 Relay
2025-12-15 11:36 ` Heiko Stuebner
2025-11-25 3:47 ` [PATCH v5 2/4] arm64: dts: rockchip: Add accelerometer " Rudraksha Gupta via B4 Relay
2025-11-25 3:47 ` [PATCH v5 3/4] arm64: dts: rockchip: Add magnetometer " Rudraksha Gupta via B4 Relay
2025-12-15 11:38 ` Heiko Stuebner [this message]
2025-11-25 3:47 ` [PATCH v5 4/4] arm64: dts: rockchip: Fix voltage threshold for volume keys for " Rudraksha Gupta via B4 Relay
2025-12-15 11:47 ` (subset) [PATCH v5 0/4] Upstreaming Pinephone Pro Patches Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7420522.MhkbZ0Pkbq@phil \
--to=heiko@sntech.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=guptarud@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=lgtrombetta@gmx.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=megi@xff.cz \
--cc=pavel@ucw.cz \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).