From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: Marek Vasut <marex@denx.de>
Cc: linux-arm-kernel@lists.infradead.org,
Fabio Estevam <festevam@denx.de>,
Marcel Ziswiler <marcel.ziswiler@toradex.com>,
Peng Fan <peng.fan@nxp.com>, Rob Herring <robh+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
NXP Linux Team <linux-imx@nxp.com>,
devicetree@vger.kernel.org
Subject: Re: Re: [PATCH] arm64: dts: imx8mp: Add SNVS LPGPR
Date: Wed, 31 Aug 2022 16:58:31 +0200 [thread overview]
Message-ID: <7425574.EvYhyI6sBW@steina-w> (raw)
In-Reply-To: <95506426-6458-16c9-19c9-03f07aab734a@denx.de>
Hi Marek,
Am Mittwoch, 31. August 2022, 16:45:31 CEST schrieb Marek Vasut:
> On 8/24/22 07:51, Alexander Stein wrote:
> > Hello Marek,
>
> Hi,
>
> > Am Dienstag, 23. August 2022, 18:56:02 CEST schrieb Marek Vasut:
> >> Add SNVS LPGPR bindings to MX8M Plus, the LPGPR is used to store
> >> e.g. boot counter.
>
> [...]
>
> >> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> >> b/arch/arm64/boot/dts/freescale/imx8mp.dtsi index
> >> f7adcb2c14880..21689e9e68170 100644
> >> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> >> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> >> @@ -478,6 +478,11 @@ snvs_pwrkey: snvs-powerkey {
> >>
> >> wakeup-source;
> >> status = "disabled";
> >>
> >> };
> >>
> >> +
> >> + snvs_lpgpr: snvs-lpgpr {
> >> + compatible =
> >
> > "fsl,imx8mp-snvs-lpgpr",
> >
> >> +
> >
> > "fsl,imx7d-snvs-lpgpr";
> >
> >> + };
> >>
> >> };
> >>
> >> clk: clock-controller@30380000 {
> >
> > Do you have any information that the i.MX8M Plus actually has the HPLR
> > register (at offset 0)? This is used in snvs_lpgpr_write. I can't find it
> > in the RM, although GPR_SL is referenced in LPGPRx register description.
> It seems the HPLR is only documented in the Security RM (MX8MMSRM,
> MX8MPSRM etc), not in the regular RM (MX8MMRM, MX8MPRM etc) . So it
> seems the register does exist, including the soft lock bit, it is only
> omitted from the plain RM.
>
> (also, sorry for the delayed reply)
Ah, there it is. Nice!
Reviewed-by: Alexander Stein <alexander.stein@ew.tq-group.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-08-31 14:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 16:56 [PATCH] arm64: dts: imx8mp: Add SNVS LPGPR Marek Vasut
2022-08-23 17:26 ` Fabio Estevam
2022-08-24 5:51 ` Alexander Stein
2022-08-31 14:45 ` Marek Vasut
2022-08-31 14:58 ` Alexander Stein [this message]
2022-08-31 14:59 ` Marek Vasut
2022-09-04 12:36 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7425574.EvYhyI6sBW@steina-w \
--to=alexander.stein@ew.tq-group.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@denx.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=marcel.ziswiler@toradex.com \
--cc=marex@denx.de \
--cc=peng.fan@nxp.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).