From mboxrd@z Thu Jan 1 00:00:00 1970 From: m.szyprowski@samsung.com (Marek Szyprowski) Date: Tue, 27 Dec 2016 11:17:45 +0100 Subject: [PATCH 6/9] pinctrl: samsung: Replace syscore ops with standard platform device pm_ops In-Reply-To: References: <1482495889-6201-1-git-send-email-m.szyprowski@samsung.com> <1482495889-6201-7-git-send-email-m.szyprowski@samsung.com> Message-ID: <742a6c77-3ae9-ce5f-984d-4da3cc790865@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Krzysztof, On 2016-12-26 06:57, Tomasz Figa wrote: > 2016-12-23 21:24 GMT+09:00 Marek Szyprowski : >> Once the dependency on PMU driver (for pad retention control) has been >> removed, there is no reason to use syscore_ops based suspend/resume. > Does it also hold true for other platforms using this driver? I.e. > s3c24xx, s3c64xx and s5pv210? I've checked and I didn't find any code related to retention control in s3c24xx and 23c64xx, but you are right that I need to add support for s5pv210 (retention is controlled via S5P_OTHERS register). Thanks for pointing this. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland