From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEFDBC433ED for ; Wed, 31 Mar 2021 21:39:09 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 12168601FB for ; Wed, 31 Mar 2021 21:39:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 12168601FB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jOGVf692AJDNv0m198DayMcDUR7+wm1WlMpXAKNNgwo=; b=DgLIe73FmOQWiGIwESMGXTJrc YBG67J4VpOuvLoCvKam9Cn3hhoaxLRCzrpVugfsIgHMcABMEWW6B3YqsRCictUSr3544pAtZTojKa QGpSZoPesXGugVdTJjZao8Os9EEAH3+3v3Rha0nSYb+gO3ui8mG5uZCVK06+91pOLsp5AmujZ/e8l ykn8tGEozw2JQ8BIR7VO4rqlbUC1PvOPx/YZlNfvjJlEsk+XgOjmdZMosdadQXP/ddsPQkN5J25PT jc1s64QZvT/HnZStmNJjZ6rUJ/F3UuGaOQs9/DhtO0UiKo4fbODUUW2nBJq5OyVZ5jlmYbAmVblkY p0nY9U/EA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lRiWl-007iNu-CY; Wed, 31 Mar 2021 21:37:27 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lRiW3-007iAF-99 for linux-arm-kernel@lists.infradead.org; Wed, 31 Mar 2021 21:36:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617226602; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CEkfAOJSRgLmrcmogejiwM3z3x7Jp11CwOAYIRJU/eA=; b=V1uvJEW0kvpG1M+e31bQhBjicjCjiCOpBWu6AmCYWLLEn9gYeuaAA/YIVSfObeqtNMs4vK lF7wCl7/qZJ+SpLyKqyGCy2byrDBJ8vBUrnGSFAchNQpIWttsxac+8pYUUTjl6uZYRoGR+ SZwhD1XXLesNu+1HtNcUiHw0AcjbaHw= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-258-fjr_VA3NPNqP2v4BjgF2SQ-1; Wed, 31 Mar 2021 17:36:38 -0400 X-MC-Unique: fjr_VA3NPNqP2v4BjgF2SQ-1 Received: by mail-wm1-f70.google.com with SMTP id o9-20020a05600c4fc9b029010cea48b602so2356821wmq.0 for ; Wed, 31 Mar 2021 14:36:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=CEkfAOJSRgLmrcmogejiwM3z3x7Jp11CwOAYIRJU/eA=; b=OuFg0kPSnMbMSdUDe0r0ozUdu+71vGOv5+pHdtkn0x9Va+4aPyhwjpv56ZRyX9p4CV t2aa248kvfSL29mI6v/BdHWalciFiCgHBfOpFBEEzRJ7bp0TZIU7c/vqCbZhwj+1qAWr DwtB/YaQjz7a0vRCrkcuo2YNVe1Z3VyOfW8CUzTQgNuky1s+ykxNTpXGdEUVqyvxzNWz BLoWpw7swN/q5v37hmzFXxZtrivqO40tdP3sZGAv3/Rakc818IIeXwPgakzhpc9+PmNr 5Sp6v99BSVKJDwOI5Ut/E5S4DaWdrH84s24H/HVyPgk1LGlrFE5vhG0wXWZJlKmKI7kO JB0g== X-Gm-Message-State: AOAM530KL5ZBnUjulfa5tAJ2pJ2PUe6srMqLdIcbKFzzmICICVhQDdGc W5+ClVyQYJOOkJI5x+J9787JT9XQVLNuHp/0fbYOwIAB82hBHHQXjRd07ARrfvYAMlEjR4TwMf7 p/ZDGd3UGS6ChTHs7Uv5BajlDPK+x/+JX3Ro= X-Received: by 2002:a5d:6a81:: with SMTP id s1mr5824712wru.401.1617226596849; Wed, 31 Mar 2021 14:36:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzxj/Cy9ZlL8PU/jQIPYrj7YXyx+xnD7LhAYpJqpR2c8LjROVyn4i4Jg6Wqcll5JYmuGcjgzQ== X-Received: by 2002:a5d:6a81:: with SMTP id s1mr5824690wru.401.1617226596681; Wed, 31 Mar 2021 14:36:36 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id u63sm5728603wmg.24.2021.03.31.14.36.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Mar 2021 14:36:36 -0700 (PDT) Subject: Re: [PATCH 16/18] KVM: Don't take mmu_lock for range invalidation unless necessary To: Sean Christopherson Cc: Marc Zyngier , Huacai Chen , Aleksandar Markovic , Paul Mackerras , James Morse , Julien Thierry , Suzuki K Poulose , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-kernel@vger.kernel.org, Ben Gardon References: <20210326021957.1424875-1-seanjc@google.com> <20210326021957.1424875-17-seanjc@google.com> <6e7dc7d0-f5dc-85d9-1c50-d23b761b5ff3@redhat.com> <56ea69fe-87b0-154b-e286-efce9233864e@redhat.com> <0e30625f-934d-9084-e293-cb3bcbc9e4b8@redhat.com> From: Paolo Bonzini Message-ID: <743a31e7-03ba-0c64-86ac-c5a0aac4121c@redhat.com> Date: Wed, 31 Mar 2021 23:36:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210331_223643_750498_C377CD56 X-CRM114-Status: GOOD ( 14.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 31/03/21 23:22, Sean Christopherson wrote: > On a related topic, any preference on whether to have an explicit "must_lock" > flag (what I posted), or derive the logic based on other params? > > The helper I posted does: > > if (range->must_lock && > kvm_mmu_lock_and_check_handler(kvm, range, &locked)) > goto out_unlock; > > but it could be: > > if (!IS_KVM_NULL_FN(range->on_lock) && !range->may_block && > kvm_mmu_lock_and_check_handler(kvm, range, &locked)) > goto out_unlock; > > The generated code should be nearly identical on a modern compiler, so it's > purely a question of aesthetics. I slightly prefer the explicit "must_lock" to > avoid spreading out the logic too much, but it also feels a bit superfluous. I do as well, but I hope we don't need any lock after all as in the email I've just sent. Paolo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel