From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7C5EDC77B61 for ; Mon, 10 Apr 2023 17:35:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=m+UAFXjkgu2kgpj7K3YImIPl7Z3IczZdLrBJ3kgf5lE=; b=4cuQoyqAr8Nzcv BnbzD+fT+dFtH8bjuZf44Xm/grKP6rfzucyHV0hjEbnwsfY7EUBrKk7H6B+oI9sCwa+0k2zQDjfkw aTSYNaGb5xFxk8I138DpgrO9B5pCBnb/XagzI624p46liQHUWtTaTeEqTkZM2p/QZpdyU6OvCu0fd gHFmuLkfSeGdBvBgtcn894lR+hSy1r0M4q8tbpv5Q2TLgV42n5cAd6qWYfAlxc61Lj1XNd1yzWgF+ m9GANulao6ArOxDDzWCHzfjX0zkkuCd0Sb0vjRvEUX4wTy3tZCNBL0SrH1LVh4uiorVJCw/2Bg4E2 r/m/vqH9vmTGMNnc9k/Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1plvP3-00Fe7x-0h; Mon, 10 Apr 2023 17:34:05 +0000 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1plvOz-00Fe7a-11 for linux-arm-kernel@lists.infradead.org; Mon, 10 Apr 2023 17:34:02 +0000 Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 33AFqbZn017675; Mon, 10 Apr 2023 17:33:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=sb6jpc0KNTLDv897qIhEwyKHMSgx7o9THMFXo2oD9bU=; b=dxGZsF62iaLppBkOy6SOUJELTdCvaPly5rVhisdckfB3Gc/dwgAJ8zGLulvP0Prbn6fM l5O1rm9zkhlXMekbQpqwNDji8IdPGrumaHaCyEovpwwkJcttosz4uujfLvtTpEI9Gehr moixAK/Sq5rY7ab9635XOZyzGa0F5Hhgig6NvGfjobGGKMH1wgWZdCSFfTikio/LQNXV /yvMeTSw/ifdNyy52SXD35v73R+exi9farghvxMx+jAxwF7kFTAKSapMAnWQIjHBcZnr EZM+FO/4stKpzUL36nYbEFYpkjOAiXIcpqHvEGh+60/kT/0BvKOWx3OJg9ykfUWOPSDG Dg== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3pvmnagd0d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 10 Apr 2023 17:33:54 +0000 Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com [10.47.97.35]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 33AHXrs1030256 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 10 Apr 2023 17:33:53 GMT Received: from [10.110.88.83] (10.80.80.8) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Mon, 10 Apr 2023 10:33:53 -0700 Message-ID: <74551421-56df-73d3-3f4d-1708768e207a@quicinc.com> Date: Mon, 10 Apr 2023 10:33:52 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 1/2] dt-bindings: firmware: arm,scmi: support parameter passing in smc/hvc Content-Language: en-US To: Krzysztof Kozlowski , CC: , , , , , References: <20230409181918.29270-1-quic_nkela@quicinc.com> <20230409181918.29270-2-quic_nkela@quicinc.com> <5d264f46-b9e8-62ec-9bce-9d666fd1eaa8@linaro.org> From: Nikunj Kela In-Reply-To: <5d264f46-b9e8-62ec-9bce-9d666fd1eaa8@linaro.org> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01c.na.qualcomm.com (10.47.97.35) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: Yz9HcfcsfpGN7L2DzyzCAtch_uGvDWY1 X-Proofpoint-GUID: Yz9HcfcsfpGN7L2DzyzCAtch_uGvDWY1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-10_12,2023-04-06_03,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=984 impostorscore=0 adultscore=0 phishscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 bulkscore=0 priorityscore=1501 malwarescore=0 spamscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304100151 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230410_103401_384005_11C5AB09 X-CRM114-Status: GOOD ( 23.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/10/2023 10:20 AM, Krzysztof Kozlowski wrote: > On 09/04/2023 20:19, Nikunj Kela wrote: >> Currently, smc/hvc calls are made with smc-id only. The parameters are >> all set to zeros. This patch defines two optional device tree bindings, >> that can be used to pass parameters in smc/hvc calls. >> >> This is useful when multiple scmi instances are used with common smc-id. >> >> Signed-off-by: Nikunj Kela >> --- >> .../devicetree/bindings/firmware/arm,scmi.yaml | 16 ++++++++++++++++ >> 1 file changed, 16 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml >> index 5824c43e9893..08c331a79b80 100644 >> --- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml >> +++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml >> @@ -115,6 +115,22 @@ properties: >> description: >> SMC id required when using smc or hvc transports >> >> + arm,smc32-params: >> + $ref: /schemas/types.yaml#/definitions/uint32-array >> + description: >> + An optional parameter list passed in smc32 or hvc32 calls >> + default: 0 >> + minItems: 1 >> + maxItems: 6 >> + >> + arm,smc64-params: >> + $ref: /schemas/types.yaml#/definitions/uint64-array >> + description: >> + An optional parameter list passed in smc64 or hvc64 calls >> + default: 0 >> + minItems: 1 >> + maxItems: 6 > These do not look like hardware properties and the fact that you need > two properties for the same also points that you tied it to specific SW > interface. This is certainly not the H/W property but then smc-id is also not H/W property either but that gets passed via DTB. I could use the same property for both however I wasn't sure which datatype should be used, uint32-array/uint64-array. Moreover, I thought if users are passing parameters, they better know which SMC convention they are using hence used two explicit properties. > Why this should be board-specific? Actually better question - why this > should be fixed per board? Doesn't my software want to have different > parameters, depending on some other condition? Not sure I follow, I didn't say this is board specific. People can use the parameters to pass whatever their S/W demands. SMC/HVC calls are made by passing parameters which is what this patch is enabling. > > You also did not provide any DTS user for this, so difficult to judge > usefulness. The work is still on going and we will push the dts in few months, however that shouldn't stop making changes in advance. > Best regards, > Krzysztof > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel