From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 12AD2C433EF for ; Tue, 7 Dec 2021 22:51:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=MDgAUhxmg0XnlSCQpetqHwUr+idZEE5HNR462iBoTf0=; b=w1zXhorlluvXKwh3rD4weUR0rE XA2up7BW53e6iL8W+dAJTLKOUVQm+W0SFHQAIn5ST4SQdOl86GnfKQAQd27fI6URH/iuh86zb1vh5 r43caFvEv+pio5cux9RxcSVMg5CVAlGpkbNNWgKxDlzr2g30EhU34bRpcf3LJGtjqYdlt3sUvOTjF fXK/u36aFy5UDEzfuhPZPp42in3q0z/IK0jSV+a0gp9isXhR71P3g2onlpjTo5DKxyhv/SkbLiyWD xEhCXciTg/rKZn0CueoHp4WTEHYzp54pER3meG5l/eRZ1BADSLkXUW1XHbB6/gIWRXs0jQUhPof5c ULFsuIRA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mujHT-00AHix-TH; Tue, 07 Dec 2021 22:49:52 +0000 Received: from mail-pf1-x429.google.com ([2607:f8b0:4864:20::429]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mujHQ-00AHiB-Q7 for linux-arm-kernel@lists.infradead.org; Tue, 07 Dec 2021 22:49:50 +0000 Received: by mail-pf1-x429.google.com with SMTP id z6so757904pfe.7 for ; Tue, 07 Dec 2021 14:49:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=EdYea8gkEDGih1RnGbJo2dm6hJijWB5dNAEaQbMNm28=; b=XK03meLzpPySHZumczyM01BVWrjErrL8miiNiU6yeobYKNBv9QSMaGdcEymmy8pKvA hexe8G+raZtoCzLR6fX/tLWlgGWKycTffZxAk8iprUJzUvfjMMyd/hrtO35PebHSp8Iz 4ks7sXJKDtLEWXdPE+gPQrNiPfaIxR+TGRRhK6E6T9ijNgXLM3tsR+ekbTYauL/fd0ra 59eRWmywLaxmZd0TZtnrWWA+ZFVmxsjjcZ130/3mefw98BsQQiqrmtJ3COxu5wpgIhTN srIW00HiEdJaWNZRd9RrjBJzL2RTfIOWBGe05GMM9SadGETUQ8ttOkoAtV9YOABRAy73 HZ5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=EdYea8gkEDGih1RnGbJo2dm6hJijWB5dNAEaQbMNm28=; b=OQsCjuj9c5Xo7JbfvcJYZOO6CL/DEQNBLiRDKlQHLLTRJVkCXuJb8IxBrBhQ8Bxo0C Vp9MwyiJ4i2qhRC1AxDynZQ8eXGsQbtwz8XLsTlHP9+T+w8kuQI142Fdk8T/j9sXALNV VJ04fGPrmzrMMlsGt+P/ZHmswD8Hmb2QoZnaWBuhTK2nhapUX/jL1nLjYxda38AUEv+i Nz3hNXkZXhr77Vov/OA37Ekt8sWUXHTUDZr239A/7R0TpCleyB9HOImJfJVutDetQ8TP 7HFCo+ti6xDdFYik/SQWhG97wVqVgh1MBw3hYzExDO7f3FXhPVT5uka5UJzqAN2Bbfv3 NyUg== X-Gm-Message-State: AOAM530yIQi7+f4K18InFcCVjVbF0wan12jVCGvcqJnxe2WpTM3oMSD0 E+B3HGtL+gckLAbDUgEq+6g= X-Google-Smtp-Source: ABdhPJyBJRO4d61TzlSU1qqEV5Y3OLwZjRUGoq8bqkPyJdODmb4ru8puCWYQVdpmuJEv7I7g8yJr9A== X-Received: by 2002:a63:4e1c:: with SMTP id c28mr23399855pgb.318.1638917387522; Tue, 07 Dec 2021 14:49:47 -0800 (PST) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id na13sm551019pjb.11.2021.12.07.14.49.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Dec 2021 14:49:46 -0800 (PST) Subject: Re: [PATCH v2 1/5] ARM: dts: Cygnus: Fixed iProc PCIe controller properties To: Rob Herring , Florian Fainelli Cc: devicetree@vger.kernel.org, Bjorn Helgaas , Ray Jui , Scott Branden , "maintainer:BROADCOM IPROC ARM ARCHITECTURE" , "open list:PCI SUBSYSTEM" , "moderated list:BROADCOM IPROC ARM ARCHITECTURE" , open list References: <20211206185242.2098683-1-f.fainelli@gmail.com> <20211206185242.2098683-2-f.fainelli@gmail.com> From: Florian Fainelli Message-ID: <745799e8-dc2e-359a-0d35-58e74bf86055@gmail.com> Date: Tue, 7 Dec 2021 14:49:45 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211207_144948_892902_50CE6EB5 X-CRM114-Status: GOOD ( 18.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/7/21 12:08 PM, Rob Herring wrote: > On Tue, Dec 7, 2021 at 11:44 AM Florian Fainelli wrote: >> >> On 12/7/21 5:49 AM, Rob Herring wrote: >>> On Mon, Dec 6, 2021 at 12:52 PM Florian Fainelli wrote: >>>> >>>> Rename the msi controller unit name to 'msi' to avoid collisions >>>> with the 'msi-controller' boolean property and add the missing >>>> 'interrupt-controller' property which is necessary. We also need to >>>> re-arrange the 'ranges' property to show the two cells as being separate >>>> instead of combined since the DT checker is not able to differentiate >>>> otherwise. >>>> >>>> Signed-off-by: Florian Fainelli >>>> --- >>>> arch/arm/boot/dts/bcm-cygnus.dtsi | 14 ++++++++------ >>>> 1 file changed, 8 insertions(+), 6 deletions(-) >>>> >>>> diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi b/arch/arm/boot/dts/bcm-cygnus.dtsi >>>> index 8ecb7861ce10..ea19d1b56400 100644 >>>> --- a/arch/arm/boot/dts/bcm-cygnus.dtsi >>>> +++ b/arch/arm/boot/dts/bcm-cygnus.dtsi >>>> @@ -263,6 +263,7 @@ pcie0: pcie@18012000 { >>>> compatible = "brcm,iproc-pcie"; >>>> reg = <0x18012000 0x1000>; >>>> >>>> + interrupt-controller; >>> >>> How is this a fix? This doesn't even work before v5.16 with commit >>> 041284181226 ("of/irq: Allow matching of an interrupt-map local to an >>> interrupt controller"). >> >> What is the path forward? I suppose I could make the >> interrupt-controller property not required for this controller but then >> the default interrupt-controller schema is not terribly happy about >> seeing an interrupt-map/interrupt-map-mask properties without >> interrupt-controller. > > There's certainly no requirement for having 'interrupt-controller'. > What error are you getting? This was the error I was getting because I had made the 'interrupt-controller' a required property in the brcm,iproc-pcie.yaml binding, silly me: /home/fainelli/dev/linux/arch/arm/boot/dts/bcm958300k.dt.yaml: pcie@18012000: 'interrupt-controller' is a required property From schema: /home/fainelli/dev/linux/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml after taking it out from the required property there are no more warnings, I will spin a v3 with the changes, thanks! -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel