public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [GIT PULL] Integrator multiplatform migration for v3.19
Date: Thu, 06 Nov 2014 12:33:51 +0100	[thread overview]
Message-ID: <7467543.qEZBkbRV4B@wuerfel> (raw)
In-Reply-To: <20141106105246.GO4042@n2100.arm.linux.org.uk>

On Thursday 06 November 2014 10:52:47 Russell King - ARM Linux wrote:
> Unfortunately, this totally screws multiplatform support - with this
> merged, we now can enable all CPUs from ARM720T upwards into a single
> kernel - and that is illegal.
> 
> The problem is that Integrator can be ARM720T all the way up to ARMv6.
> So, when ARCH_INTEGRATOR is enabled, you are presented with the
> individual CPUs which the platform supports as options to select.
> This results in randconfig seeing all the CPU options, which it can
> then enable, resulting in:
> 
> CONFIG_CPU_ARM720T=y
> CONFIG_CPU_ARM920T=y
> CONFIG_CPU_ARM922T=y
> CONFIG_CPU_ARM926T=y
> CONFIG_CPU_ARM1020=y
> CONFIG_CPU_ARM1022=y
> CONFIG_CPU_ARM1026=y
> CONFIG_CPU_V6=y
> CONFIG_CPU_V6K=y
> CONFIG_CPU_V7=y
> 
> which then causes:
> 
> arch/arm/include/asm/cmpxchg.h:114:2: error: #error "SMP is not supported on this platform"
> arch/arm/include/asm/atomic.h:137:2: error: #error SMP not supported on pre-ARMv6 CPUs
> 
> Integrator doesn't fit into the "is it a pre-ARMv6 or not" platform
> structure chosen in the early days of multiplatform support, because
> it straddles that boundary.

I've thought about this issue before but hadn't realized that the patches
as they went into arm-soc already cause the problem.

I think it would be best to replace all the lines like

	bool "Support ARM926T processor" if ARCH_INTEGRATOR || MACH_REALVIEW_EB

with

	bool "Support ARM926T processor" if ARCH_MULTI_V5 || MACH_REALVIEW_EB

and ignore whether ARCH_INTEGRATOR is set or not. Since we have the
generic default platform for multiplatform kernels now, in theory you
could always have any other CPU enabled without even needing an
ARCH_* symbol, as long as the drivers are all present.

	Arnd

  reply	other threads:[~2014-11-06 11:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-22 12:13 [GIT PULL] Integrator multiplatform migration for v3.19 Linus Walleij
2014-11-04  6:32 ` Olof Johansson
2014-11-06 10:52   ` Russell King - ARM Linux
2014-11-06 11:33     ` Arnd Bergmann [this message]
2014-11-10 13:48       ` Linus Walleij
2014-11-10 13:56       ` Russell King - ARM Linux
2014-11-10 14:01         ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7467543.qEZBkbRV4B@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox