From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA393C352A3 for ; Tue, 11 Feb 2020 08:51:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8DC452051A for ; Tue, 11 Feb 2020 08:51:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RkiJe64n" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8DC452051A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+VfaJ8W83FI/EJnE8aI2z3YD+1NrhMEkEFaJApbInzc=; b=RkiJe64naKfllR Bu+sCtJIa5gpe+XaHfJ8LXGlD2UVMXWUpIWHZOHRJ3y5NuP0F7cRe8T12V4UjAz8tUl0IMhQCypEE W3DMWs4maxGlbiE9hCXZuJPyZ0cgRbBVeUXhiKrgytwqWq8miTqmM/Zh3kl8BvFM/V20NEnEtBlAy PYxlNgEDPQiJXPIIg+/8jtU1S3jmA/2fpeW7zHYmF5BWRstTN4tDDI+N29CgmapWKSTREL9L69qnB KHfBQSOg7MnSjywJS0ZmT2YmMKN6HX0MiPzsaZdalhXdx0CG8z8YWMeR1wm2cqEWphN0aCuzcs8Ta CmLPLBrq+m8AkVZccEtg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j1RGL-00086L-VW; Tue, 11 Feb 2020 08:51:21 +0000 Received: from kernel.crashing.org ([76.164.61.194]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j1RGI-00085s-En for linux-arm-kernel@lists.infradead.org; Tue, 11 Feb 2020 08:51:19 +0000 Received: from localhost (gate.crashing.org [63.228.1.57]) (authenticated bits=0) by kernel.crashing.org (8.14.7/8.14.7) with ESMTP id 01B8oi95016379 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 11 Feb 2020 02:50:46 -0600 Message-ID: <746b08aabf7ea976a382ad2ca30fa10a095e7ed8.camel@kernel.crashing.org> Subject: Re: [PATCH 1/3] usb: gadget: aspeed: read vhub config from of_device_id From: Benjamin Herrenschmidt To: Tao Ren Date: Tue, 11 Feb 2020 09:50:42 +0100 In-Reply-To: <20200210190744.GA5346@taoren-ubuntu-R90MNF91> References: <20200131222157.20849-1-rentao.bupt@gmail.com> <20200131222157.20849-2-rentao.bupt@gmail.com> <386e905fb705266efcac0c1b3a10053889c7fead.camel@kernel.crashing.org> <20200210190744.GA5346@taoren-ubuntu-R90MNF91> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200211_005118_684587_43E45051 X-CRM114-Status: GOOD ( 12.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Felipe Balbi , linux-aspeed , devicetree , Andrew Jeffery , Greg Kroah-Hartman , OpenBMC Maillist , linux-usb@vger.kernel.org, Linux Kernel Mailing List , Stephen Boyd , Rob Herring , Joel Stanley , Chunfeng Yun , Colin Ian King , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 2020-02-10 at 11:07 -0800, Tao Ren wrote: > > > This looks generally okay. We should wait for Ben's ack before > > > applying. > > > > Shouldn't we instead have DT fields indicating those values ? > > May I ask why we prefer adding dt fields (such as "aspeed,vhub-max-ports" > and "aspeed,vhub-max-endpoints") instead of assigning these values based > on aspeed family? For example, is it to allow users to set a smaller > number of ports/endpoints? It's not a strong drive but it makes it more convenient to add support to newer revisions if the only differences are those numbers. > > > Also we should add a DT representation for the various ID/strings of > > the hub itself so manufacturers can customize them. > > Sure. I will add DT nodes for vendor/product/device IDs/strings. As it's > not directly related to ast2600-support, shall I handle it in a separate > patch? Or I can include the patch in this patch series? Separate. Thanks ! Cheers, Ben. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel