From: Andrew Lunn <andrew@lunn.ch>
To: Caleb James DeLisle <cjd@cjdns.fr>
Cc: netdev@vger.kernel.org, daniel@makrotopia.org, dqfext@gmail.com,
SkyLake.Huang@mediatek.com, hkallweit1@gmail.com,
linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, matthias.bgg@gmail.com,
angelogioacchino.delregno@collabora.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Matheus Sampaio Queiroga <srherobrine20@gmail.com>
Subject: Re: [PATCH net-next] net: phy: mediatek: support MT7530 PHYs on EN71221 MCM
Date: Thu, 10 Sep 2026 04:03:19 +0200 [thread overview]
Message-ID: <746ebc26-e4ad-4988-a839-c5805d7ab319@lunn.ch> (raw)
In-Reply-To: <20260909213250.3184238-1-cjd@cjdns.fr>
> + /* Clause 22 local data. */
> + ret = phy_write(phydev, MII_CTRL1000, 0x1e00);
Please express this using
/* 1000BASE-T Control register */
#define ADVERTISE_1000FULL 0x0200 /* Advertise 1000BASE-T full duplex */
#define ADVERTISE_1000HALF 0x0100 /* Advertise 1000BASE-T half duplex */
#define CTL1000_PREFER_MASTER 0x0400 /* prefer to operate as master */
#define CTL1000_AS_MASTER 0x0800
#define CTL1000_ENABLE_MASTER 0x1000
Once we have symbolic names, it might be obvious what this is doing,
and if there is a better way to do it.
> + /* Vendor profile disables 100/1000BASE-T EEE advertisement. */
> + ret = phy_write_mmd(phydev, MDIO_MMD_AN, 0x003c, 0x0000);
> + if (ret < 0)
> + return ret;
Any idea why? Is EEE broken? If it is, phy_disable_eee().
Andrew
next prev parent reply other threads:[~2026-09-10 2:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-09 21:32 [PATCH net-next] net: phy: mediatek: support MT7530 PHYs on EN71221 MCM Caleb James DeLisle
2026-09-09 23:02 ` Daniel Golle
2026-09-09 23:26 ` Caleb James DeLisle
2026-09-10 1:55 ` Daniel Golle
2026-09-10 6:12 ` Caleb James DeLisle
2026-09-11 10:48 ` Caleb James DeLisle
2026-09-10 2:03 ` Andrew Lunn [this message]
2026-09-10 7:01 ` Caleb James DeLisle
2026-09-11 10:39 ` [PATCH v2 " Caleb James DeLisle
2026-09-11 11:58 ` Andrew Lunn
2026-09-11 12:03 ` Caleb James DeLisle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=746ebc26-e4ad-4988-a839-c5805d7ab319@lunn.ch \
--to=andrew@lunn.ch \
--cc=SkyLake.Huang@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=cjd@cjdns.fr \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=srherobrine20@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox