From: Florian Fainelli <f.fainelli@gmail.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>,
Florian Fainelli <f.fainelli@gmail.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
Kamal Dasu <kdasu.kdev@gmail.com>,
Richard Weinberger <richard@nod.at>,
open list <linux-kernel@vger.kernel.org>,
Marek Vasut <marek.vasut@gmail.com>,
"open list:BROADCOM STB NAND FLASH DRIVER"
<linux-mtd@lists.infradead.org>,
"open list:BROADCOM STB NAND FLASH DRIVER"
<bcm-kernel-feedback-list@broadcom.com>,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] mtd: rawnand: brcmnand: Fix sparse warning in has_flash_dma()
Date: Mon, 21 Oct 2019 09:41:46 -0700 [thread overview]
Message-ID: <747887ef-224b-8d4b-0165-4d043c8b87f5@gmail.com> (raw)
In-Reply-To: <20191019113824.15fa4f52@xps13>
On 10/19/19 2:39 AM, Miquel Raynal wrote:
> Hi Florian,
>
> Florian Fainelli <f.fainelli@gmail.com> wrote on Fri, 18 Oct 2019
> 16:38:44 -0700:
>
>> Sparse rightfully complained about has_flash_dma():
>> +drivers/mtd/nand/brcmnand/brcmnand.c:951:40: warning: Using plain integer as NULL pointer [sparse]
>
> I don't get why would sparse complain about this... Anyway I prefer
> the !!(<pointer>) alternative if you don't mind. Otherwise the "!=
> NULL" comparison feels wrong.
I did not read the sparse complaint correctly and mixed up two issues
(one downstream, one upstream) there is still one that is legitimately
reported by sparse and that will be fixed in a v2, thanks.
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-10-21 16:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 23:38 [PATCH] mtd: rawnand: brcmnand: Fix sparse warning in has_flash_dma() Florian Fainelli
2019-10-19 9:39 ` Miquel Raynal
2019-10-21 16:41 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=747887ef-224b-8d4b-0165-4d043c8b87f5@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=kdasu.kdev@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox