From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F3E98C6FD1D for ; Fri, 17 Mar 2023 11:36:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZG3EFBH12LQeXHGE7u5/KHPeMK4wIZSnZ2mSIGecX+g=; b=E5WsADg6RYIJfz V5tHoksRisq+ZFwwkfk4mBgzX0n5hV9kLd82aWBcbqyAN0H16mlpkf57H11rC3vleLgLwt6U5hAIk FKMIPvPq7TL2cXfh0NtvanwsZdvqg9EgbhZiaKiPH1yZL/Y61Msnm8emSUeSkSU7jdKjJiLPkkCCF lIQi586JAleTkBIwJZwgpacH/NZfWwG+euAbuUEY9L7DrL6Mhbe8mcHmGk9cck95mirYwuailO5ur tOeAwHIs7c5QJlYmXB/sZasi+nf4SKK0TNkePvULRi6nM5V6u6ql7NsI+4Xfn/KzflJbYoCD0Obg9 5crTQsp4V2IOF93wSCkg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pd8MM-0024Zs-2g; Fri, 17 Mar 2023 11:34:58 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pd8MI-0024Ye-0k for linux-arm-kernel@lists.infradead.org; Fri, 17 Mar 2023 11:34:56 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B4C621480; Fri, 17 Mar 2023 04:35:33 -0700 (PDT) Received: from [10.57.17.87] (unknown [10.57.17.87]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2D06D3F885; Fri, 17 Mar 2023 04:34:47 -0700 (PDT) Message-ID: <74d8b579-6ea8-d6f3-170f-ea13534b4565@arm.com> Date: Fri, 17 Mar 2023 11:34:49 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2 4/4] serial: qcom_geni: Use devm_krealloc_array Content-Language: en-US To: Jonathan Cameron , Krzysztof Kozlowski Cc: linux-kernel@vger.kernel.org, linux@roeck-us.net, michal.simek@amd.com, Jonathan Corbet , Jean Delvare , Anand Ashok Dumbre , Lars-Peter Clausen , Michal Simek , Andy Gross , Bjorn Andersson , Konrad Dybcio , Greg Kroah-Hartman , Jiri Slaby , linux-doc@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org References: <20230309150334.216760-1-james.clark@arm.com> <20230309150334.216760-5-james.clark@arm.com> <20230311191800.74ec2b84@jic23-huawei> From: James Clark In-Reply-To: <20230311191800.74ec2b84@jic23-huawei> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230317_043454_334822_A1A6B64E X-CRM114-Status: GOOD ( 22.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11/03/2023 19:18, Jonathan Cameron wrote: > On Thu, 9 Mar 2023 15:03:33 +0000 > James Clark wrote: > >> Now that it exists, use it instead of doing the multiplication manually. >> >> Signed-off-by: James Clark > > Hmm. I've stared at the users of this for a bit, and it's not actually obvious > that it's being used as an array of u32. The only typed user of this is as > the 2nd parameter of > tty_insert_flip_string() which is an unsigned char * > > I wonder if that sizeof(u32) isn't a 'correct' description of where the 4 is coming > from even if it has the right value? Perhaps the fifo depth is just a multiple of 4? > > Jonathan > The commit that added it (b8caf69a6946) seems to hint that something reads from it in words. And I see this: /* We always configure 4 bytes per FIFO word */ #define BYTES_PER_FIFO_WORD 4U Perhaps sizeof(u32) isn't as accurate of a description as using BYTES_PER_FIFO_WORD but I'd be reluctant to make a change because I don't really understand the implications. There is also this in handle_rx_console(): unsigned char buf[sizeof(u32)]; James > > >> --- >> drivers/tty/serial/qcom_geni_serial.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c >> index d69592e5e2ec..23fc33d182ac 100644 >> --- a/drivers/tty/serial/qcom_geni_serial.c >> +++ b/drivers/tty/serial/qcom_geni_serial.c >> @@ -1056,9 +1056,9 @@ static int setup_fifos(struct qcom_geni_serial_port *port) >> (port->tx_fifo_depth * port->tx_fifo_width) / BITS_PER_BYTE; >> >> if (port->rx_buf && (old_rx_fifo_depth != port->rx_fifo_depth) && port->rx_fifo_depth) { >> - port->rx_buf = devm_krealloc(uport->dev, port->rx_buf, >> - port->rx_fifo_depth * sizeof(u32), >> - GFP_KERNEL); >> + port->rx_buf = devm_krealloc_array(uport->dev, port->rx_buf, >> + port->rx_fifo_depth, sizeof(u32), >> + GFP_KERNEL); >> if (!port->rx_buf) >> return -ENOMEM; >> } > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel