From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1FFE7C47074 for ; Wed, 3 Jan 2024 08:40:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:Message-ID: In-Reply-To:Subject:cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZEMF4SBGrlt8feK/SSDVN0TTB6/hH2MM6GfWBLIbIuA=; b=WcifTmLL22J2L2 pBTSSzdqTgZTsOqps2QEDQpNHrQrKICf8x+EcjNY+qlxDP6pMnx7TB8GnmExJksoFxc6deVP3nvN4 I0zTbYxP/3J0V74vgo5vKd/zBQLYrm2zazdLtH3eM0UrwKZvZpWQrQLf7L4n1/yiOdcVb5UBHtUw3 CuGJgw/ishg0SKXS+BTk5346plw4d0dB1cZAljK2Pisg70eb5bKFbczSpX+3/J7Ni+cD8KXWPcQeD Qj+uNrUF7Lx7P2fzDXRUSzjsJOfWlQOjKL9TzMG8ffTux3NChER8/3nqGbH0+TOkSa1j2NLebW0bQ H4TLHONFE2o6JFDAkJvQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rKwnc-00A6Hq-08; Wed, 03 Jan 2024 08:40:28 +0000 Received: from relay4-d.mail.gandi.net ([217.70.183.196]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rKwnY-00A6Gr-0p for linux-arm-kernel@lists.infradead.org; Wed, 03 Jan 2024 08:40:26 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 7FAA7E000A; Wed, 3 Jan 2024 08:40:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1704271219; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mbyKDE6LxBB4pt4rAudS3Wo2lvqVspXh6sWUjAjOt3o=; b=FUWLmozv1lOWyRPl125r4yShizx8ZyjVEHwaVOariUJ7aXLVKDjpme/ubSiIwoqsb3nsdJ MtbyWBEq5ox8YUvWRRiRa3icEdGyTgTkPXYPRkyvIgUl96BAAf0KVyMtjC2mWFeqHxrTtD TvwTraBrLZvEI27cbHvuio22KdPXODO98rMo90wSFiN1ojp6FTmmhlN2p7B8odtybhjuyK ZV1vB3xRuVxiz47x6T+5D9MtRpNpQrzFKa4CsP9E5gO2G6mOdjPkpnsaxzPOfPnvojuO/i FvciG0Xd49tOV6gjichyIgNN5LHpMPldNPy09HTevxOnQHYt1tNsPXzUs7yybA== Date: Wed, 3 Jan 2024 09:40:40 +0100 (CET) From: Romain Gantois To: Florian Fainelli cc: Romain Gantois , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Miquel Raynal , Maxime Chevallier , Sylvain Girard , Vladimir Oltean , Andrew Lunn , Pascal EBERHARD , Richard Tresidder , Linus Walleij , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org Subject: Re: [PATCH net v2 1/1] net: stmmac: Prevent DSA tags from breaking COE on stmmac In-Reply-To: Message-ID: <753d4eab-5699-91e3-05a4-d0e03f7052e6@bootlin.com> References: <20240102162718.268271-1-romain.gantois@bootlin.com> <20240102162718.268271-2-romain.gantois@bootlin.com> MIME-Version: 1.0 X-GND-Sasl: romain.gantois@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240103_004024_455776_1FDCECB9 X-CRM114-Status: GOOD ( 11.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Florian, On Tue, 2 Jan 2024, Florian Fainelli wrote: ... > > Fixes: 6b2c6e4a938f ("net: stmmac: propagate feature flags to vlan") > > Cc: stable@vger.kernel.org > > Reported-by: Richard Tresidder > > Closes: > > https://lore.kernel.org/netdev/e5c6c75f-2dfa-4e50-a1fb-6bf4cdb617c2@electromag.com.au/ > > Reported-by: Romain Gantois > > Closes: > > https://lore.kernel.org/netdev/c57283ed-6b9b-b0e6-ee12-5655c1c54495@bootlin.com/ > > Fairly sure those should be Link: and Closes: should be used for bug tracker > entries. ACK > > + return (proto == htons(ETH_P_IP)) || (proto == htons(ETH_P_IPV6)) || > > + (proto == htons(ETH_P_8021Q)); > > Do you need to include ETH_P_8021AD in that list as well or is not stmmac > capable of checksuming beyond a single VLAN tag? The datasheet for my Ethernet controller doesn't mention 802.1ad tag handling and I ran some loopback tests that showed that this controller doesn't recognize 802.1ad frames as vlan frames. I also haven't seen anything in the stmmac driver that suggests that 802.1ad offloading is supported. Maybe the stmmac maintainers could weigh in on this? Best Regards, -- Romain Gantois, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel