From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 41B69EE7FF4 for ; Mon, 11 Sep 2023 11:09:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Q414YEM37Tjv2vjDuT6qTUTkW+fsrJq/XjRWGlnp+Pg=; b=YHSX3ZP/1xU/Kl 8jxcJ9ShCkVDl8FRv00Y2v5uFOI1kH6WSmTpF6w6tjs1AzVgdrrWhQs6Uj20gTfC5l1MEaRoK1t0B mGtQKd8qHAUvdKn2JAfqg1gpxqqWQ1GiHWD7tgVQYF3jKa4VIgKw4AuPbMie61k13PztEL98tmajn qlPknDtcm1lQxALQ7uWK16fFtuJ3Fy5uqgJAo/2ZqdiSBY67PJnhKA3/ohU/XBNNMc2rJrPYpsXVd lPasGtdzYDqL9D7ITBLVP7Wb9kISDFctA8/lzq8OHY7sutamM3PMyvyAOfIARYqtYgWZAs5RmuIU5 hbzXmGz51biuvma48z0w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qfemo-000MC6-0u; Mon, 11 Sep 2023 11:08:58 +0000 Received: from mail-lf1-x136.google.com ([2a00:1450:4864:20::136]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qfeml-000MBS-1o for linux-arm-kernel@lists.infradead.org; Mon, 11 Sep 2023 11:08:56 +0000 Received: by mail-lf1-x136.google.com with SMTP id 2adb3069b0e04-50079d148aeso7254723e87.3 for ; Mon, 11 Sep 2023 04:08:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1694430532; x=1695035332; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2r1pG42saIT1hQx+TELlhxvqJ0mmluvD/XCTWLDnio4=; b=FMaVg8WC2L6tyLeuFed3m64jRaYip9ApwPr9Ee5DsV74CgYTqTngHQTrAYf7/4p0jk FNusFyUlybrTvU9pXcaM33jy/NUtZqI5lEv5dEpXlsnQhe7y7cKBBBTrNk9hy8TiocQz lNMZkEwUGZBe5DydN6m3lIyVdLxIaZw1PWBvAfkUiNX96jjcAYWSFneQ/ODbUi5tbwRA oD3Oyf2HjqQGjG2Clt5hW+CSdr3/fDUxPMxSpL084bqXRQQ1rWsSHmmh7Jo8EAEVDteb dWVqgVDlrd6rO9BbJNO8fXh8mupAcPh5AXZbX4CFIAbfXDz06ot+jer6pDBuCsZU66SB NRlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694430532; x=1695035332; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2r1pG42saIT1hQx+TELlhxvqJ0mmluvD/XCTWLDnio4=; b=B33a2r8brCS6nUpLQRsgd6kudDZ5PdGZu5lOVYL4o2qEJbK3hchc7YZTlf6qfPkWxT t7yruq8/e9Qb/pwizYPkRd3S3e9055SY5g5NnWEEae4iH5vUNmroTJ3AD/OWo3wOAEoY jpda0GhtZt/NObJAUaUKNa1r6F0PssJpQjag7dIShnth8Fc+p5d5wSxEjqCLCDwXGLjo 8omzmHd05BRykjCjxpM7t6rcZDWXPFRh2v3AOkKm+UbT4rwpLt2z1Np/bzmGDwBW1zGs VCenftdrMiuO4nVMzcm0imlxELZ5RzRWQuE1yTeG4KqskDzd8LMoEvIgFlbL9IxGEwIO U+jg== X-Gm-Message-State: AOJu0Yx/XDlG2SH5lD0n5OnYa8HRw2oY+oZq0PEpOPGRfMgnEyNxnQg7 bV1VTDMlf5VG4yiwrYAbzwMJYg== X-Google-Smtp-Source: AGHT+IFhJr6aCH0nOA8CkPBUhMy540nMaAY+Mvm7js3Wpv0+d0W8u8lZbEJt3lbAgLcQPiDqKMNL3g== X-Received: by 2002:a05:651c:1994:b0:2bf:789e:b5dd with SMTP id bx20-20020a05651c199400b002bf789eb5ddmr5800990ljb.53.1694430532675; Mon, 11 Sep 2023 04:08:52 -0700 (PDT) Received: from [192.168.1.20] ([178.197.214.188]) by smtp.gmail.com with ESMTPSA id si28-20020a170906cedc00b009786c8249d6sm5244877ejb.175.2023.09.11.04.08.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Sep 2023 04:08:52 -0700 (PDT) Message-ID: <75466db4-3d19-33f6-b2de-db714186a96b@linaro.org> Date: Mon, 11 Sep 2023 13:08:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH v5 07/17] soc: qcom: minidump: Add pending region registration Content-Language: en-US To: Mukesh Ojha , corbet@lwn.net, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, keescook@chromium.org, tony.luck@intel.com, gpiccoli@igalia.com, mathieu.poirier@linaro.org, catalin.marinas@arm.com, will@kernel.org, linus.walleij@linaro.org, andy.shevchenko@gmail.com, vigneshr@ti.com, nm@ti.com, matthias.bgg@gmail.com, kgene@kernel.org, alim.akhtar@samsung.com, bmasney@redhat.com, quic_tsoni@quicinc.com Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-hardening@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-samsung-soc@vger.kernel.org, kernel@quicinc.com References: <1694290578-17733-1-git-send-email-quic_mojha@quicinc.com> <1694290578-17733-8-git-send-email-quic_mojha@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <1694290578-17733-8-git-send-email-quic_mojha@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230911_040855_603793_E1B3B742 X-CRM114-Status: GOOD ( 11.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 09/09/2023 22:16, Mukesh Ojha wrote: > static int qcom_apss_minidump_probe(struct platform_device *pdev) > { > struct minidump_global_toc *mdgtoc; > @@ -571,7 +688,10 @@ static int qcom_apss_minidump_probe(struct platform_device *pdev) > return ret; > } > > + mutex_lock(&md_plist.plock); > platform_set_drvdata(pdev, md); Why this is locked? > + qcom_apss_register_pending_regions(md); Why this one is locked? It seems ordering of your operations is not correct if you need to lock the providers probe(). > + mutex_unlock(&md_plist.plock); Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel