Re: [PATCH v6 4/7] dt-bindings: thermal: rockchip: document otp thermal trim

Nicolas Frattaroli
2025-07-10T21:07:49Z

On Thursday, 10 July 2025 13:21:19 Central European Summer Time Heiko Stuebner wrote:
> Am Dienstag, 10. Juni 2025, 14:32:40 Mitteleuropäische Sommerzeit schrieb Nicolas Frattaroli:
> > Several Rockchip SoCs, such as the RK3576, can store calibration trim
> > data for thermal sensors in OTP cells. This capability should be
> > documented.
> >
> > Such a rockchip thermal sensor may reference cell handles that store
> > both a chip-wide trim for all the sensors, as well as cell handles
> > for each individual sensor channel pointing to that specific sensor's
> > trim value.
> >
> > Additionally, the thermal sensor may optionally reference cells which
> > store the base in terms of degrees celsius and decicelsius that the trim
> > is relative to.
> >
> > Each SoC that implements this appears to have a slightly different
> > combination of chip-wide trim, base, base fractional part and
> > per-channel trim, so which ones do which is documented in the bindings.
> >
> > Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
> > Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
>
> Acked-by: Heiko Stuebner <heiko@sntech.de>
>
> with one question below
>
> > ---
> > .../bindings/thermal/rockchip-thermal.yaml | 61 ++++++++++++++++++++++
> > 1 file changed, 61 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/thermal/rockchip-thermal.yaml b/Documentation/devicetree/bindings/thermal/rockchip-thermal.yaml
> > index 49ceed68c92ce5a32ed8d4f39bd88fd052de0e80..573f447cc26ed7100638277598b0e745d436fd01 100644
> > --- a/Documentation/devicetree/bindings/thermal/rockchip-thermal.yaml
> > +++ b/Documentation/devicetree/bindings/thermal/rockchip-thermal.yaml
> > @@ -40,6 +40,17 @@ properties:
> > - const: tsadc
> > - const: apb_pclk
> >
> > + nvmem-cells:
> > + items:
> > + - description: cell handle to where the trim's base temperature is stored
> > + - description:
> > + cell handle to where the trim's tenths of Celsius base value is stored
> > +
> > + nvmem-cell-names:
> > + items:
> > + - const: trim_base
> > + - const: trim_base_frac
> > +
>
> are we sure, we want underscores here?
> trim-base, trim-base-frac looks somewhat nicer.

a quick grep of all the bindings shows me that _ vs. - is about even.
I'm not sure deviating from what downstream calls it, what I already
sent, and what the already sent driver expects is really worth anyone's
time and mailbox space for what boils down to a matter of personal
preference.

>
> Heiko
>

Kind regards,
Nicolas Frattaroli