From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C409C433E0 for ; Tue, 9 Jun 2020 11:03:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2CD082078D for ; Tue, 9 Jun 2020 11:03:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NgriWUBC"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ii3Kp2Ra" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2CD082078D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sr3QooKDP4nu9HWuzk41SaJYdtasRr8do7q+27Plfi0=; b=NgriWUBCzk3N4c NJTsWflbSyW9IkzRDVd1DZBbosIbchU/79dTK+ACrwLURG8uOxX0zrMPl0BPl+b6AOsNSUFmrb04M WvExAH6ureWQIEoPVjwo49/Nk0AALip4w/HM5Ac7R1f2MWoHaczMIBg5vyHWQPdOsttIzOa0m15BO WNP4ajAC0SNsSM0munK6PWIWxmi4BowcUDBAXtkseD62GZiaaaGiuSa01x29w7wTvTM9IeeIU45eu 6d0knMU6Dc5NIOV9V+7SUa8lS6LKxOiZWqsx/Ip/5xSz3zw+IVxmrGKHLOH+DoS9ONZXmsqQPg3Zx GK+mCLZ7t9yOdA80yl9w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jic2f-00058z-4K; Tue, 09 Jun 2020 11:03:41 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jic2c-00058Z-FU for linux-arm-kernel@lists.infradead.org; Tue, 09 Jun 2020 11:03:39 +0000 Received: by mail-wr1-x443.google.com with SMTP id l11so20809840wru.0 for ; Tue, 09 Jun 2020 04:03:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=cc:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=aJNdMPWPrN93u2hPRulOatep/HuM2hucF4eVhI1US+c=; b=ii3Kp2RazJaBkch/duwZbyVhWvA96NeuRemtYCHvICOVqGMZ9fqAL+tv4aY2oloHs9 UDYcukqmHcoFgL1W35n3tPruj6T2zltrIhmnjVJKYcMzdw3kY4cbMa6748DdrnJPCnUJ oSraDkPINlOIYc4UrVHatbWB/WE89OiSccHp4nT5Wjet9duVIlwNst85oyGlpoRrJ+a3 muWcYaRPuobHejZXDq9R7ANwndujzG0KmaUSe0wFZSrDNgX9eTmjralrY64We/7YDXyy L2/o77bqjU49hUmJCIIck8JsCiJuelfBRK8GHBQFVmDUsUTp8mDjKmR/SnqRJjXNnFL4 ExTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:cc:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=aJNdMPWPrN93u2hPRulOatep/HuM2hucF4eVhI1US+c=; b=GQQziA9qQT3TTe+Qhhax+MzruYnctA3lezZeN6QqZFjdaWM3NFWzGp+i6V0Itz+/vv hjCtWgh6yqvWfdhguVTTJOZkA/QKQ4kIXPCT9uq+giulLMfdbDyD2f/WEVCZpouqU+8Q EUKYZOPIMFissj8Yw2ZofEZka7rL74q8uICeKMqjXs8RfyQaZmGXG0FafiOi5Aoq9Tdo Fmxc7jtbcjNdIMDW5Dikd+W1/3zdMy8EU29f9fWSW8W33aJob2KrjdzZp58CNdEPE5hD BFo7vmLY73t+pg90W7gRjDJqq8J+p7mVQEC1cKjRlaFiVNfjjVfb54SER2+/Nc6EXyIC nkNg== X-Gm-Message-State: AOAM5307dY6VgvHUFik3x92pL6zEIAqo5DpGOHYHkKFS3fW0p9KPm/66 1VbQ1HM5+jU8g2NKgBB0QPM= X-Google-Smtp-Source: ABdhPJwVUqzL+yIQWFnqQp/zOzCZpAquIuPC80KWKaHY3VIwX9zTyBdZ/zHOQLPn14UQtgHcjaViHg== X-Received: by 2002:a05:6000:100e:: with SMTP id a14mr3732821wrx.349.1591700616981; Tue, 09 Jun 2020 04:03:36 -0700 (PDT) Received: from ?IPv6:2001:a61:253c:8201:b2fb:3ef8:ca:1604? ([2001:a61:253c:8201:b2fb:3ef8:ca:1604]) by smtp.gmail.com with ESMTPSA id 23sm2503265wmg.10.2020.06.09.04.03.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Jun 2020 04:03:36 -0700 (PDT) Subject: Re: [PATCH v2 5/6] prctl.2: Add PR_PAC_RESET_KEYS (arm64) To: Will Deacon , Dave Martin References: <1590614258-24728-1-git-send-email-Dave.Martin@arm.com> <1590614258-24728-6-git-send-email-Dave.Martin@arm.com> <20200609100202.GB25362@willie-the-truck> From: "Michael Kerrisk (man-pages)" Message-ID: <7571ba40-7b4e-ca6d-efb1-691b1c4a6d04@gmail.com> Date: Tue, 9 Jun 2020 13:03:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200609100202.GB25362@willie-the-truck> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200609_040338_519902_1C79601D X-CRM114-Status: GOOD ( 15.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, linux-man@vger.kernel.org, Catalin Marinas , mtk.manpages@gmail.com, Amit Daniel Kachhap , Mark Rutland , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Will, Thanks for reviewing. On 6/9/20 12:02 PM, Will Deacon wrote: > On Wed, May 27, 2020 at 10:17:37PM +0100, Dave Martin wrote: >> Add documentation for the PR_PAC_RESET_KEYS ioctl added in Linux >> 5.0 for arm64. > > [...] > >> +If the arguments are invalid, >> +and in particular if >> +.I arg2 >> +contains set bits that are unrecognized >> +or that correspond to a key not available on this platform, >> +the call fails with error >> +.BR EINVAL . >> +.IP >> +.B Warning: >> +Because the compiler or run-time environment >> +may be using some or all of the keys, >> +a successful >> +.IP >> +For more information, see the kernel source file >> +.I Documentation/arm64/pointer\-authentication.rst >> +.\"commit b693d0b372afb39432e1c49ad7b3454855bc6bed >> +(or >> +.I Documentation/arm64/pointer\-authentication.txt >> +before Linux 5.3). >> +.B PR_PAC_RESET_KEYS >> +may crash the calling process. > > I might be misreading this, but this looks like the kernel reference appears > mid-sentence. It's hidden as a comment (.\"). > Regardless, I think we should drop the kernel doc reference, > as I mentioned on the SVE patches. I actually request that people add these kinds of comments in the source. It helps me verify details in patches, and is also handy when checking details in the future. > With that: > > Acked-by: Will Deacon Thanks. Cheers, Michael -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel