linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] clocksource: disallow drivers for ARCH_USES_GETTIMEOFFSET
@ 2015-11-16 16:51 Arnd Bergmann
  0 siblings, 0 replies; only message in thread
From: Arnd Bergmann @ 2015-11-16 16:51 UTC (permalink / raw)
  To: linux-arm-kernel

We can now select clocksource drivers like ti-32k and CONFIG_OF
on ancient machines that still use gettimeoffset, and the combination
results in a link error.

arch/arm/kernel/built-in.o: In function `time_init':
(.init.text+0xc28): undefined reference to `clocksource_probe'

The reason for this is that the Makefile is hidden behind
CONFIG_ARCH_USES_GETTIMEOFFSET, but the Kconfig file is not, and
it has shown up just now because the ti-32k driver was added
and can be selected using COMPILE_TEST on all platforms.

This patch hides the Kconfig menu in CONFIG_ARCH_USES_GETTIMEOFFSET
as well.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: dfedaf105d60 ("clocksource: ti-32k: make it depend on GENERIC_CLOCKSOURCE")

diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index c479f815b99a..db240cb56da7 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -1,4 +1,5 @@
 menu "Clock Source drivers"
+	depends on !ARCH_USES_GETTIMEOFFSET
 
 config CLKSRC_OF
 	bool

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2015-11-16 16:51 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-16 16:51 [PATCH] clocksource: disallow drivers for ARCH_USES_GETTIMEOFFSET Arnd Bergmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).