From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78CDEC433E1 for ; Fri, 22 May 2020 09:17:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 350AA206B6 for ; Fri, 22 May 2020 09:17:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="k/V9GUUN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 350AA206B6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: MIME-Version:References:In-Reply-To:Date:To:From:Subject:Message-ID:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8/Oq+mGTmaQx3hig8M+SlYj8QZUohVs4Xu/9LVtuaT8=; b=k/V9GUUNc1Y7kXNDBDQjnoPTe YnMrfgfQ7kCqAE4DFYrxEv1IWNOm4iUVGsptO0nXyZ3dJhl1Ftt0MEKSO7MMYBxX3OrxwT+7SitpZ A1Hqi/VhN3/wuu32mKfc7SkVzyPOJBgn9oNteA8bDewvX9wagUb/tRkIpRpPlymdLjPqkk6YE0djh KUWyurxyKbM0DTKANKw8/eXShv2gj28w+mMb0Adv0UYnkFbjQqsgsWPMNPPLbG64bM4QWEYnxlser 8UcSrAt94REOyCKL5O7HoB2k9/mf8R9pPX/EgTNuy0Rzb4xz4Yoo5T8ITrQk8M8r1I/Opj1JSDYii 2SVQFTwDA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jc3ns-0008Jf-HF; Fri, 22 May 2020 09:17:20 +0000 Received: from mx2.suse.de ([195.135.220.15]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jc3np-0008IE-FD; Fri, 22 May 2020 09:17:18 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 4597EB215F; Fri, 22 May 2020 09:17:14 +0000 (UTC) Message-ID: <75a1dd87d18103f1e8b0afbd1e0718c74c4a77d4.camel@suse.de> Subject: Re: [PATCH 04/15] PCI: brcmstb: Add compatibily of other chips From: Nicolas Saenz Julienne To: Jim Quinlan Date: Fri, 22 May 2020 11:17:08 +0200 In-Reply-To: References: <20200519203419.12369-1-james.quinlan@broadcom.com> <20200519203419.12369-5-james.quinlan@broadcom.com> <5a52e39ce99214877e83104b8ea9f95c0d5b4e90.camel@suse.de> User-Agent: Evolution 3.36.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200522_021717_654167_59C78AEE X-CRM114-Status: GOOD ( 14.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Lorenzo Pieralisi , "open list:PCI NATIVE HOST BRIDGE AND ENDPOINT DRIVERS" , open list , Florian Fainelli , "maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , Bjorn Helgaas , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" Content-Type: multipart/mixed; boundary="===============7885263094276008737==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============7885263094276008737== Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-IGhRx3S6S3ntSbJkcWLj" --=-IGhRx3S6S3ntSbJkcWLj Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2020-05-21 at 15:35 -0400, Jim Quinlan wrote: > On Wed, May 20, 2020 at 7:51 AM Nicolas Saenz Julienne [...] > > > /* > > > @@ -602,20 +667,21 @@ static struct pci_ops brcm_pcie_ops =3D { > > >=20 > > > static inline void brcm_pcie_bridge_sw_init_set(struct brcm_pcie *pc= ie, > > > u32 > > > val) > > > { > > > - u32 tmp; > > > + u32 tmp, mask =3D pcie->reg_field_info[RGR1_SW_INIT_1_INIT_MAS= K]; > > > + u32 shift =3D pcie->reg_field_info[RGR1_SW_INIT_1_INIT_SHIFT]; > >=20 > > I don't think you need shift here, IIUC u32p_replace_bits() will take c= are > > of > > all the masking and shifting internally, moreover, you'd be able to dro= p the > > shift entry from reg_field_info. > I believe that u32p_replace_bits requires at least one of the value or > mask to be compile time constants to work and we don't have that here. Of course, sorry for the noise then. Regards, Nicolas --=-IGhRx3S6S3ntSbJkcWLj Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEErOkkGDHCg2EbPcGjlfZmHno8x/4FAl7HmJQACgkQlfZmHno8 x/70WAf+JoTHq0ZhGNKW8bxgqcUyLEW3dAtHwfItO+wAuflXC/o+CEKjpSFs2+j0 pG6Vatt7V46ZMMUgZb3clhJxgd2VQ/rJYIRPr8l9E7OplbhGdbmjXMD1CyD4y+j7 vyGxrliBdi63YKcBdLGwXjuzDG3kn2b35qWONfBb6j5n8N0tfQPUKNbJcw0VxVFB 0vC0MCEDYxGCWrW0jifLamw1U5OYZTN59aX7BW/9+csiXoWGLdwu8TmO1G3GAUf9 7hA1B8n9ReG8le34eQbsufe/qRrQuGwaBvjbYkMkOML2N8GL1tNDkglGA7OlAL+h pDvQnKJkJltAZ5+bOP4gaILPBLVVzQ== =eV6J -----END PGP SIGNATURE----- --=-IGhRx3S6S3ntSbJkcWLj-- --===============7885263094276008737== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============7885263094276008737==--