Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Babu Moger <babu.moger@amd.com>
To: tony.luck@intel.com, reinette.chatre@intel.com,
	ben.horgan@arm.com, Dave.Martin@arm.com, james.morse@arm.com,
	bp@alien8.de
Cc: corbet@lwn.net, skhan@linuxfoundation.org, rdunlap@infradead.org,
	x86@kernel.org, fustini@kernel.org, tglx@kernel.org,
	mingo@redhat.com, dave.hansen@linux.intel.com, hpa@zytor.com,
	fenghuay@nvidia.com, rppt@kernel.org, arnd@arndb.de,
	kmehltretter@gmail.com, dapeng1.mi@linux.intel.com,
	elver@google.com, enelsonmoore@gmail.com, jlayton@kernel.org,
	seanjc@google.com, ewanhai-oc@zhaoxin.com,
	binbin.wu@linux.intel.com, nikunj@amd.com, ashish.kalra@amd.com,
	peterz@infradead.org, superm1@kernel.org,
	thomas.lendacky@amd.com, prathyushi.nangia@amd.com,
	kim.phillips@amd.com, ricardo.neri-calderon@linux.intel.com,
	darwi@linutronix.de, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v7 17/19] fs/resctrl: Control visibility of global per-CPU kernel mode group files
Date: Mon, 16 Nov 2026 14:10:29 -0600	[thread overview]
Message-ID: <75c12dd8-f78b-49ee-8853-bb00e29f6919@amd.com> (raw)
In-Reply-To: <6af7466df1a5e64bc2804ba3d8c7e2e592793cae.1794437052.git.babu.moger@amd.com>



On 11/11/26 16:44, Babu Moger wrote:
> The kmode_cpus and kmode_cpus_list files are specific to the global per-CPU
> kernel mode. These files are created in a hidden state when an rdtgroup is
> created.
> 
> Introduce resctrl_kmode_global_files_show() to control the visibility of
> these files for individual resource groups. Show the files only for the
> group backing the active global per-CPU kernel mode and hide them for all
> other groups.
> 
> Suggested-by: Reinette Chatre <reinette.chatre@intel.com>
> Signed-off-by: Babu Moger <babu.moger@amd.com>
> ---
> v7: Updated the prototype rdtgroup_kmode_global_files_show().
>      Moved the patch after both rdtgroup_kmode_global_activate() and
>      rdtgroup_kmode_global_deactivate() is Introduced, so the change is
>      symmetrical.
>      Updated the changelog.
> 
> v6: Helper named for the global per-CPU files instead of unhiding every
>      hidden file on the group.
>      https://lore.kernel.org/lkml/34aa4824-810b-4c81-8188-f2f37e1dc277@intel.com/
> ---
>   fs/resctrl/rdtgroup.c | 20 ++++++++++++++++++++
>   1 file changed, 20 insertions(+)
> 
> diff --git a/fs/resctrl/rdtgroup.c b/fs/resctrl/rdtgroup.c
> index 1ad169e714a4..86bd6a66812b 100644
> --- a/fs/resctrl/rdtgroup.c
> +++ b/fs/resctrl/rdtgroup.c
> @@ -1136,6 +1136,24 @@ static int resctrl_kernel_mode_show(struct kernfs_open_file *of,
>   	return 0;
>   }
>   
> +/* Show or hide kmode_cpus and kmode_cpus_list on @kn. */
> +static void resctrl_kmode_global_files_show(struct rdtgroup *rdtgrp, bool show)
> +{
> +	struct kernfs_node *kn_file;
> +
> +	kn_file = kernfs_find_and_get(rdtgrp->kn, "kmode_cpus");
> +	if (kn_file) {
> +		kernfs_show(kn_file, show);
> +		kernfs_put(kn_file);
> +	}
> +
> +	kn_file = kernfs_find_and_get(rdtgrp->kn, "kmode_cpus_list");
> +	if (kn_file) {
> +		kernfs_show(kn_file, show);
> +		kernfs_put(kn_file);
> +	}
> +}
> +
>   /*
>    * resctrl_kmode_global_online_cpu() - Program kernel mode association for @cpu
>    * @cpu: CPU that has just been brought online
> @@ -1194,6 +1212,7 @@ static void rdtgroup_kmode_global_deactivate(struct rdtgroup *rdtgrp)
>   
>   	resctrl_configure_kmode_global(&rdtgrp->kmode_cpu_mask, rdtgrp, false);
>   	cpumask_clear(&rdtgrp->kmode_cpu_mask);
> +	resctrl_kmode_global_files_show(rdtgrp, false);
>   
>   	resctrl_kmode.rdtgrp = NULL;
>   	resctrl_kmode.active = RESCTRL_INHERIT_USER;
> @@ -1214,6 +1233,7 @@ static void rdtgroup_kmode_global_activate(struct rdtgroup *rdtgrp,
>   
>   	cpumask_copy(&rdtgrp->kmode_cpu_mask, cpu_online_mask);
>   	resctrl_configure_kmode_global(&rdtgrp->kmode_cpu_mask, rdtgrp, true);
> +	resctrl_kmode_global_files_show(rdtgrp, true);
>   }
>   
>   static int resctrl_kmode_parse_state(char *val, enum kmode_state *state)


Sashiko reported:

https://sashiko.dev/#/patchset/cover.1794437052.git.babu.moger%40amd.com?part=17

=============================================================================

commit 05ab3c952d1bee6b5476ced04f03000037d907a0
Author: Babu Moger <babu.moger@amd.com>

fs/resctrl: Control visibility of global per-CPU kernel mode group files

This commit introduces a helper to show or hide the kmode_cpus and
kmode_cpus_list kernfs files when a resource group activates or deactivates
global per-CPU kernel mode.

> diff --git a/fs/resctrl/rdtgroup.c b/fs/resctrl/rdtgroup.c
> index 68e72afada85a..e2a996102f7e1 100644
> --- a/fs/resctrl/rdtgroup.c
> +++ b/fs/resctrl/rdtgroup.c
> @@ -1136,6 +1136,24 @@ static int resctrl_kernel_mode_show(struct 
kernfs_open_file *of,
>  	return 0;
>  }
>
> +/* Show or hide kmode_cpus and kmode_cpus_list on @kn. */
> +static void resctrl_kmode_global_files_show(struct rdtgroup *rdtgrp, 
bool show)
> +{
> +	struct kernfs_node *kn_file;
> +
> +	kn_file = kernfs_find_and_get(rdtgrp->kn, "kmode_cpus");
> +	if (kn_file) {
> +		kernfs_show(kn_file, show);
> +		kernfs_put(kn_file);
> +	}
> +
> +	kn_file = kernfs_find_and_get(rdtgrp->kn, "kmode_cpus_list");
> +	if (kn_file) {
> +		kernfs_show(kn_file, show);
> +		kernfs_put(kn_file);
> +	}
> +}
> +
>  /*
>   * resctrl_kmode_global_online_cpu() - Program kernel mode 
association for @cpu
>   * @cpu: CPU that has just been brought online
> @@ -1194,6 +1212,7 @@ static void 
rdtgroup_kmode_global_deactivate(struct rdtgroup *rdtgrp)
>
>  	resctrl_configure_kmode_global(&rdtgrp->kmode_cpu_mask, rdtgrp, false);
>  	cpumask_clear(&rdtgrp->kmode_cpu_mask);
> +	resctrl_kmode_global_files_show(rdtgrp, false);
>
>  	resctrl_kmode.rdtgrp = NULL;
>  	resctrl_kmode.active = RESCTRL_INHERIT_USER;
> @@ -1214,6 +1233,7 @@ static void 
rdtgroup_kmode_global_activate(struct rdtgroup *rdtgrp,
>
>  	cpumask_copy(&rdtgrp->kmode_cpu_mask, cpu_online_mask);
>  	resctrl_configure_kmode_global(&rdtgrp->kmode_cpu_mask, rdtgrp, true);
> +	resctrl_kmode_global_files_show(rdtgrp, true);
>  }
>
>  static int resctrl_kmode_parse_state(char *val, enum kmode_state *state)

As reported by Reinette Chatre on v6 [1], should
resctrl_kmode_global_files_show() be renamed to
rdtgroup_kmode_global_files_show() to match its struct rdtgroup 
parameter, rdtgroup_kmode_global_activate(), and 
rdtgroup_kmode_global_deactivate() (as noted in the v7 patch changelog)? 
  The comment above the helper also still refers to @kn instead of @rdtgrp.

In addition, the commit message still omits the requested context 
explaining why kmode_cpus and kmode_cpus_list are specific to global 
per-CPU kernel mode (used by user space for per-CPU enable and disable 
of the mode) and why they are created hidden (a resource group can only 
be assigned to global per-CPU kernel mode after creation via a separate 
resctrl file).

[1] https://lore.kernel.org/r/c600a240-ed11-4e31-b3c3-779f01175f28@intel.com

=========================================================================

My bad. Yes. Will fix the naming to rdtgroup_kmode_global_files_show() 
and also will fix the comment about @kn

Thanks
Babu



  reply	other threads:[~2026-11-16 20:13 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-11 22:43 [PATCH v7 00/19] x86,fs/resctrl: Add kernel-mode (e.g., PLZA) support to the resctrl subsystem Babu Moger
2026-11-11 22:43 ` [PATCH v7 01/19] x86/cpufeatures: Support Privilege Level Zero Association (PLZA) Babu Moger
2026-11-11 22:43 ` [PATCH v7 02/19] x86/resctrl: Add PLZA support to command-line options Babu Moger
2026-11-11 22:43 ` [PATCH v7 03/19] x86/resctrl: Add PLZA MSR definition and field layout Babu Moger
2026-11-11 22:43 ` [PATCH v7 04/19] fs/resctrl: Introduce kernel mode enum Babu Moger
2026-11-16 20:07   ` Babu Moger
2026-11-11 22:43 ` [PATCH v7 05/19] arm,x86,fs/resctrl: Introduce arch hook to program global per-CPU kernel mode Babu Moger
2026-11-11 22:43 ` [PATCH v7 06/19] fs/resctrl: Introduce data structures for kernel mode configuration Babu Moger
2026-11-11 22:44 ` [PATCH v7 07/19] fs/resctrl: Introduce resctrl_set_kmode_support() to register supported modes Babu Moger
2026-11-11 22:44 ` [PATCH v7 08/19] x86/resctrl: Register RESCTRL_GLOBAL_ENABLE_PER_CPU when PLZA is available Babu Moger
2026-11-11 22:44 ` [PATCH v7 09/19] fs/resctrl: Rearrange top-level files in info directory Babu Moger
2026-11-11 22:44 ` [PATCH v7 10/19] fs/resctrl: Add interface to display kernel mode status Babu Moger
2026-11-11 22:44 ` [PATCH v7 11/19] fs/resctrl: Add support for hidden resource group files Babu Moger
2026-11-11 22:44 ` [PATCH v7 12/19] fs/resctrl: Introduce kmode_cpus/kmode_cpus_list per rdtgroup Babu Moger
2026-11-11 22:44 ` [PATCH v7 13/19] x86,fs/resctrl: Add CPU hotplug support for kernel mode Babu Moger
2026-11-16 20:08   ` Babu Moger
2026-11-11 22:44 ` [PATCH v7 14/19] fs/resctrl: Deactivate kernel mode when the group is removed Babu Moger
2026-11-11 22:44 ` [PATCH v7 15/19] fs/resctrl: Extend info/kernel_mode to configure the kernel mode Babu Moger
2026-11-16 20:09   ` Babu Moger
2026-11-11 22:44 ` [PATCH v7 16/19] fs/resctrl: Reject mode changes for groups backing " Babu Moger
2026-11-11 22:44 ` [PATCH v7 17/19] fs/resctrl: Control visibility of global per-CPU kernel mode group files Babu Moger
2026-11-16 20:10   ` Babu Moger [this message]
2026-11-11 22:44 ` [PATCH v7 18/19] fs/resctrl: Allow userspace to write kmode_cpus/kmode_cpus_list Babu Moger
2026-11-11 22:44 ` [PATCH v7 19/19] fs/resctrl: Add kernel mode documentation and examples Babu Moger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=75c12dd8-f78b-49ee-8853-bb00e29f6919@amd.com \
    --to=babu.moger@amd.com \
    --cc=Dave.Martin@arm.com \
    --cc=arnd@arndb.de \
    --cc=ashish.kalra@amd.com \
    --cc=ben.horgan@arm.com \
    --cc=binbin.wu@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=corbet@lwn.net \
    --cc=dapeng1.mi@linux.intel.com \
    --cc=darwi@linutronix.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=elver@google.com \
    --cc=enelsonmoore@gmail.com \
    --cc=ewanhai-oc@zhaoxin.com \
    --cc=fenghuay@nvidia.com \
    --cc=fustini@kernel.org \
    --cc=hpa@zytor.com \
    --cc=james.morse@arm.com \
    --cc=jlayton@kernel.org \
    --cc=kim.phillips@amd.com \
    --cc=kmehltretter@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=nikunj@amd.com \
    --cc=peterz@infradead.org \
    --cc=prathyushi.nangia@amd.com \
    --cc=rdunlap@infradead.org \
    --cc=reinette.chatre@intel.com \
    --cc=ricardo.neri-calderon@linux.intel.com \
    --cc=rppt@kernel.org \
    --cc=seanjc@google.com \
    --cc=skhan@linuxfoundation.org \
    --cc=superm1@kernel.org \
    --cc=tglx@kernel.org \
    --cc=thomas.lendacky@amd.com \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox