From mboxrd@z Thu Jan 1 00:00:00 1970 From: marek.vasut@gmail.com (Marek Vasut) Date: Fri, 3 Aug 2018 12:12:25 +0200 Subject: [PATCH] ARM: shmobile: silk: Add DA9063 PMIC node In-Reply-To: References: <20180730111817.5636-1-marek.vasut+renesas@gmail.com> <42d09bc8-a883-c3af-b0d6-0087b6e2558e@gmail.com> Message-ID: <75d2797a-48db-4979-c059-d7359eb39cff@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 08/02/2018 04:07 PM, Geert Uytterhoeven wrote: > Hi Marek, Hi, > On Thu, Aug 2, 2018 at 3:56 PM Marek Vasut wrote: >> On 08/01/2018 02:32 PM, Geert Uytterhoeven wrote: >>> On Mon, Jul 30, 2018 at 1:18 PM Marek Vasut wrote: >>>> Add DA9063 PMIC node to the I2C bus. >>>> >>>> Signed-off-by: Marek Vasut >>> >>> Thanks for your patch! >>> >>> Oneline-summary prefix should be "ARM: dts: silk:". >> >> Right, fixed >> >>>> --- a/arch/arm/boot/dts/r8a7794-silk.dts >>>> +++ b/arch/arm/boot/dts/r8a7794-silk.dts >>>> @@ -403,6 +403,18 @@ >>>> pinctrl-names = "i2c-hdmi"; >>>> >>>> clock-frequency = <400000>; >>>> + >>>> + pmic at 5a { >>> >>> Hmm, the da9063 is actually connected to two i2c buses: i2c1 (3.3v) >>> and i2c7 (1.8v). >>> On Koelsch, we describe the 1.8v connection, as that i2c bus >>> ("i2c_dvfs") is meant >>> for power control. >> >> On Koelsch, the pmic is sitting on i2c6 only. What am I missing ? > > On Koelsch, i2c6 is wired to the da9063' 2-wire bus, and i2c1 is wired to > the da9063's HS (high-speed) 2-wire bus. On Silk it's wired to i2c1 and i2c7 apparently, I checked with i2cdetect/i2cdump that the PMIC responds on both busses, although it has address 0x5a on i2c1 and 0x58 on i2c7 . > Wolfram: do you like i2c slaves connected to multiple buses? > > Gr{oetje,eeting}s, > > Geert > -- Best regards, Marek Vasut