From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 396B9C47080 for ; Tue, 1 Jun 2021 12:53:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 008D56135D for ; Tue, 1 Jun 2021 12:53:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 008D56135D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=1oaAly0+AR2/Yhf9d39AaswR9jogRrBuWrtONfoWl0M=; b=mYq4lIn4w3ykMkgTUOnp4qqJqM RiAgcEgUyhwxk7+h06t6j4A18UH8Y7l5YHM8yP8+IPxPgy1e8oKkWNPBC3jpN8+FBIWg1MWa11YCp Xp4eaU+vHMo/4DP7UWLRHBlKYbw6/kw+WiJZ64NQWbEHz5NuW0GfwFXF6RRw79tw5whii/1+cV8Z4 /2OabtUxyJkfYns5TG25ufSAjmZaCCzYGxtyFTdQ8yIFNktpeoy9bO+gXjw8bXi+CKOOdbmb33ZNT JLdEziDPPO8fCrlE6OI48gAswxwSAGdQIa6IRN2uJG8i64Tzb8xl4SRLIVzYCvA/Dj/s3UInQNTL3 QEumaI8w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lo3ss-00GcG9-RM; Tue, 01 Jun 2021 12:52:38 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lo3sn-00GcEO-O0; Tue, 01 Jun 2021 12:52:35 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 61F926D; Tue, 1 Jun 2021 05:52:32 -0700 (PDT) Received: from [192.168.0.110] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A6CDB3F719; Tue, 1 Jun 2021 05:52:30 -0700 (PDT) Subject: Re: [PATCH v2 0/4] PCI: of: Improvements to handle 64-bit attribute for non-prefetchable ranges To: Punit Agrawal , linux-rockchip@lists.infradead.org, linux-pci@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, wqu@suse.com, robin.murphy@arm.com, pgwipeout@gmail.com, ardb@kernel.org, briannorris@chromium.org, shawn.lin@rock-chips.com, helgaas@kernel.org, robh+dt@kernel.org References: <20210531221057.3406958-1-punitagrawal@gmail.com> From: Alexandru Elisei Message-ID: <75da0524-7588-4ace-a135-69236f2d1d5e@arm.com> Date: Tue, 1 Jun 2021 13:53:19 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: <20210531221057.3406958-1-punitagrawal@gmail.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210601_055233_875906_BBBB387F X-CRM114-Status: GOOD ( 18.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Punit, On 5/31/21 11:10 PM, Punit Agrawal wrote: > Hi, > > Here's an updated version of changes to improve handling of the 64-bit > attribute on non-prefetchable host bridge ranges. Previous version can > be found at [0]. > > The series addresses Rob and Bjorn's comments on the previous version > and updates the checks for 32-bit non-prefetchable window size to only > apply to non 64-bit ranges. Many thanks for the series. I've tested it on my rockpro64, and the NVME works as expected: Tested-by: Alexandru Elisei Thanks, Alex > > Thanks, > Punit > > Changes: > v2: > * Check ranges PCI / bus addresses rather than CPU addresses > * (new) Restrict 32-bit size warnings on ranges that don't have the 64-bit attribute set > * Refactor the 32-bit size warning to the range parsing loop. This > change also prints the warnings right after the window mappings are > logged. > > > [0] https://lore.kernel.org/linux-arm-kernel/20210527150541.3130505-1-punitagrawal@gmail.com/ > > Punit Agrawal (4): > PCI: of: Override 64-bit flag for non-prefetchable memory below 4GB > PCI: of: Relax the condition for warning about non-prefetchable memory > aperture size > PCI: of: Refactor the check for non-prefetchable 32-bit window > arm64: dts: rockchip: Update PCI host bridge window to 32-bit address > memory > > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 2 +- > drivers/pci/of.c | 17 ++++++++++++----- > 2 files changed, 13 insertions(+), 6 deletions(-) > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel